Allow users to share templates with Accounts or Projects through the by yadvr · Pull Request #3241 · apache/cloudstack

yadvr · 2019-03-28T09:42:16Z

Problem: CloudStack users want the ability to share templates with other accounts or projects through the UI.

Root Cause: The ‘updateTemplatePermissions’ is only available via API and needs to be integrated with the UI in order to allow users to share templates with other accounts within the same domain, and also with projects that the sharing account has access to.

Solution: The CloudStack UI template view has been extended to include a button that allows users to update template permissions through the ‘updateTemplatePermissions’ API. This API supports 3 operations i.e. add, remove or reset. The reset operation does not require any parameters and it simply removes all permissions for a template. The add and remove parameters require either accounts or projects to be specified for sharing or stop sharing templates. The ‘listAccounts’ API has been extended to allow users to see all the accounts within the same domain if the global setting ‘allow.view.all.domain.accounts’ is set to true. This allows the accounts selection to be a multi-selection.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

Reset Operation hides the Accounts and Project ID fields as this operation does not require any additional parameters to be set.

Operation = Reset; Account and Project fields not displayed

Operation = Add/Remove , global setting: 'allow.user.view.all.domain.accounts' = false;

Operation = Add , global setting: 'allow.user.view.all.domain.accounts' = true; Domain has 3 accounts in total (bt1, bt2 and bt3). Logged in user is bt1 and so it is not shown on the dropdown list.

Operation = Remove , global setting: 'allow.user.view.all.domain.accounts' = true; Domain has 3 accounts in total (bt1, bt2 and bt3). The current template was only shared with bt2 by bt1 so dropdown menu only shows accounts that the current template has been shared with.

How Has This Been Tested?

Create 2 Accounts (acc1 and acc2) within the same domain.
Log in to the CloudStack UI with acc1 user account and upload a private template for this user.
Navigate to the newly created UI and click on the "Update Template Permissions" button.
A new window should pop up, select "Add" for this window and input acc2 in the Accounts input field and then click OK.
With CloudMonkey/CloudStack UI, check for shared templates using acc2 user account. The template from acc1 user account should now be visible to acc2 under shared templates.

borisstoyanov · 2019-03-28T13:35:53Z

@blueorangutan package

blueorangutan · 2019-03-28T13:36:06Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-03-28T14:40:57Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2659

borisstoyanov

Thanks for this neat feature @rhtyd, I just have one issue with it
When adding a project I get an error saying 'an account or projectid needs to be passed', I suppose there's something wrong with the passing of the projectId
Here's the steps:

Click on the update permission button for a template
Select a project and click submit.

And get the following error:

borisstoyanov · 2019-04-04T10:56:05Z

@blueorangutan test

blueorangutan · 2019-04-04T10:56:37Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2019-04-04T20:15:07Z

Trillian test result (tid-3471)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31556 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3241-t3471-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 70 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

anuragaw · 2019-04-23T04:49:57Z

@blueorangutan package

blueorangutan · 2019-04-23T04:50:47Z

@anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-04-23T05:11:16Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2713

anuragaw · 2019-04-26T07:37:25Z

@blueorangutan test

blueorangutan · 2019-04-26T07:38:02Z

@anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2019-04-26T15:37:18Z

Trillian test result (tid-3530)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25768 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3241-t3530-kvm-centos7.zip
Smoke tests completed. 70 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

shwstppr · 2019-05-29T11:47:10Z

@rhtyd conflict issues with this.
For a non-public template in ROOT domain, Root admin cannot share template to a project in one of the subdomain?

yadvr · 2019-05-30T10:55:27Z

@shwstppr @anuragaw can you fix the merge conflicts, thanks.

anuragaw · 2019-06-04T08:28:29Z

Fixed merge conflicts and cleaned up some code left over. @rhtyd , @shwstppr

anuragaw · 2019-06-04T08:29:58Z

@rhtyd conflict issues with this.
For a non-public template in ROOT domain, Root admin cannot share template to a project in one of the subdomain?

We may have to ask @rhtyd or @PaulAngus if this is the expected behaviour or not.

yadvr · 2019-06-07T09:15:32Z

@anuragaw can you address this bug if you've time today?

anuragaw · 2019-06-07T10:18:08Z

Looking now @rhtyd

borisstoyanov · 2019-06-10T12:42:18Z

@blueorangutan package

blueorangutan · 2019-06-10T12:43:16Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-06-10T13:25:05Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2874

updateTemplate permissions API

The older UI was confusing as it showed both project and accounts. The list of accounts and projects with add/remove wasn't consistent and instead showed everything. This patch updates the dialogue layout logic to only allow users to select accounts or project one at a time. The lists are also populated such that users see accounts/projects which don't have permissions to add and accounts/projects that have permissions to remove.

…date template permissions

anuragaw · 2019-07-12T04:00:27Z

@blueorangutan package

blueorangutan · 2019-07-12T04:01:16Z

@anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-07-12T04:39:27Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-118

blueorangutan · 2019-07-12T07:01:46Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-120

…em in list api calls

anuragaw · 2019-07-17T10:52:16Z

When admins share project owned templates we will now get a distinct message.

anuragaw · 2019-07-17T10:52:24Z

@blueorangutan package

blueorangutan · 2019-07-17T10:52:40Z

@anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-07-17T11:28:38Z

Packaging result: ✔centos6 ✖centos7 ✔debian. JID-140

borisstoyanov · 2019-07-17T12:38:27Z

@blueorangutan package

blueorangutan · 2019-07-17T12:38:41Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-07-17T12:57:52Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-142

borisstoyanov · 2019-07-17T13:02:36Z

@blueorangutan test

blueorangutan · 2019-07-17T13:03:41Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

borisstoyanov · 2019-07-17T13:13:56Z

LGTM with the known issue of #3481

blueorangutan · 2019-07-17T22:02:56Z

Trillian test result (tid-171)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30578 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3241-t171-kvm-centos7.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

PaulAngus

LGTM based on manual testing for positive and negative results

yadvr added the status:work-in-progress label Mar 28, 2019

yadvr added this to the 4.13.0.0 milestone Mar 28, 2019

yadvr requested review from PaulAngus and borisstoyanov March 28, 2019 09:42

yadvr mentioned this pull request Mar 28, 2019
templates: allow users to share templates with accounts or projects through UI shapeblue/cloudstack#36
Closed
5 tasks

yadvr mentioned this pull request Apr 2, 2019
ui: allow user template sharing through UI #3220
Closed
5 tasks

borisstoyanov requested changes Apr 4, 2019
View reviewed changes

anuragaw force-pushed the allow-ui-template-sharing branch from 3202fec to 60ab5f8Compare June 4, 2019 08:25

anuragaw force-pushed the allow-ui-template-sharing branch from 0ccd63d to 999eb1aCompare June 11, 2019 08:26

Dingane Hlalukuand others added 8 commits July 12, 2019 09:14

Allow users to share templates with Accounts or Projects through the
b36eb37
updateTemplate permissions API

Allow project id to be passed in even if no account name is specified
0950b7f

Remove unused import
0fadb1d

Fixed typo in capabilities key
074e2ee

Change behaviour to show only supported projects and accounts with up…
4facf03
…date template permissions

Allow admins to see accounts dropdown and only hide lists for users
1555d31

Fix bug for hover animation
d383aa3

anuragaw force-pushed the allow-ui-template-sharing branch from bcefd68 to d383aa3Compare July 12, 2019 03:45

Don't allow sharing project owned templates as you cannot retrieve th…
e90bad4
…em in list api calls

borisstoyanov mentioned this pull request Jul 17, 2019
Can't share a template that is in a project #3481
Closed

borisstoyanov approved these changes Jul 17, 2019
View reviewed changes

PaulAngus approved these changes Jul 18, 2019
View reviewed changes

PaulAngus merged commit 5d81574 into apache:masterJul 18, 2019

yadvr changed the title ~~[WIP DO NOT MERGE] Allow users to share templates with Accounts or Projects through the~~Allow users to share templates with Accounts or Projects through theJul 18, 2019

Uh oh!

Conversation

yadvr commented Mar 28, 2019

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

borisstoyanov commented Mar 28, 2019

Uh oh!

blueorangutan commented Mar 28, 2019

Uh oh!

blueorangutan commented Mar 28, 2019

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

borisstoyanov commented Apr 4, 2019

Uh oh!

blueorangutan commented Apr 4, 2019

Uh oh!

blueorangutan commented Apr 4, 2019

Uh oh!

anuragaw commented Apr 23, 2019

Uh oh!

blueorangutan commented Apr 23, 2019

Uh oh!

blueorangutan commented Apr 23, 2019

Uh oh!

anuragaw commented Apr 26, 2019

Uh oh!

blueorangutan commented Apr 26, 2019

Uh oh!

blueorangutan commented Apr 26, 2019

Uh oh!

shwstppr commented May 29, 2019

Uh oh!

yadvr commented May 30, 2019

Uh oh!

anuragaw commented Jun 4, 2019

Uh oh!

anuragaw commented Jun 4, 2019

Uh oh!

yadvr commented Jun 7, 2019

Uh oh!

anuragaw commented Jun 7, 2019

Uh oh!

borisstoyanov commented Jun 10, 2019

Uh oh!

blueorangutan commented Jun 10, 2019

Uh oh!

blueorangutan commented Jun 10, 2019

Uh oh!

anuragaw commented Jul 12, 2019

Uh oh!

blueorangutan commented Jul 12, 2019

Uh oh!

blueorangutan commented Jul 12, 2019

Uh oh!

blueorangutan commented Jul 12, 2019

Uh oh!

anuragaw commented Jul 17, 2019

Uh oh!

anuragaw commented Jul 17, 2019

Uh oh!

blueorangutan commented Jul 17, 2019

Uh oh!

blueorangutan commented Jul 17, 2019

Uh oh!

borisstoyanov commented Jul 17, 2019

Uh oh!

blueorangutan commented Jul 17, 2019

Uh oh!

blueorangutan commented Jul 17, 2019

Uh oh!

borisstoyanov commented Jul 17, 2019

Uh oh!

blueorangutan commented Jul 17, 2019

Uh oh!

borisstoyanov commented Jul 17, 2019

Uh oh!