ui: instance settings visibility by shwstppr · Pull Request #3244 · apache/cloudstack

shwstppr · 2019-03-28T09:48:39Z

Description

Problem: Instance settings tab is visible only for stopped VMs but hidden otherwise. This creates confusion as users may not know that VMs need to be stopped to access settings page. Some VM details need to be read-only for the user.

Root Cause: The UI Code hides the settings tab for VMs that are not in stopped state. Instance setting tab should always be visible, but only changeable when VM is stopped. Required instance details are not read-only for the user.

Solution: The settings tab is now always visible for VMs. If VM is not in the stopped state, no interactions are allowed in the settings tab view by greying out its content and a popup is shown to advise users for stopping the VM. VM details can be made read-only in UI for the user using “user.vm.readonly.ui.details” which accepts a comma-separated list of details. For user, read-only details will be shown in the settings tab in UI but the action button for them will be disabled and greyed out. Admin can still update such details.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

Snapshot when VM is stopped.

Snapshot when VM is not stopped but Settings tab is clicked and Popup appears

When popup is dismissed

VM setting/detail made read-only

How Has This Been Tested?

borisstoyanov · 2019-04-02T07:50:03Z

@blueorangutan package

blueorangutan · 2019-04-02T07:50:28Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-04-02T08:25:58Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2668

borisstoyanov · 2019-04-02T12:09:53Z

@blueorangutan test

blueorangutan · 2019-04-02T12:10:31Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

borisstoyanov

LGTM, manually checked the restriction logic and the readonly setting

yadvr · 2019-05-23T06:18:50Z

@shwstppr please fix conflicts and rebase against latest master

shwstppr · 2019-05-23T06:41:41Z

@shwstppr please fix conflicts and rebase against latest master

Done @rhtyd

shwstppr · 2019-05-23T07:11:12Z

@blueorangutan package

blueorangutan · 2019-05-23T07:11:58Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-05-23T07:34:55Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2754

DaanHoogland · 2019-05-23T10:03:16Z

@shwstppr please rebase

This change allows instance Settings tab to be visible but inaccessible when instance is running. A warning is shown when user tries to access Settings for a running instance and tab content is greyed out. It also allows some admin defined instance settings/details to be made static for user. User will be able to see them in instance settings tab but cannot change their values as action buttons are disabled and greyed out. This can be achieved by providing a comma-separated list details for global settings key 'user.vm.readonly.ui.details'. A new value 'readonlyuidetails' has been added in UserVMResponse for UI manipulate editing functionality of settings/details. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2019-05-23T11:18:46Z

Rebased to latest master @DaanHoogland @rhtyd

DaanHoogland · 2019-05-23T12:10:20Z

@blueorangutan package

blueorangutan · 2019-05-23T12:10:58Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-05-23T12:31:51Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2758

DaanHoogland · 2019-05-23T12:46:26Z

@blueorangutan test

blueorangutan · 2019-05-23T12:46:58Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2019-05-23T14:32:26Z

@blueorangutan package

blueorangutan · 2019-05-23T14:32:59Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-05-23T16:48:12Z

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2768

blueorangutan · 2019-05-23T20:20:27Z

Trillian test result (tid-3574)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25549 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3244-t3574-kvm-centos7.zip
Smoke tests completed. 70 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

svenvogel · 2019-05-24T12:38:37Z

VM details can be made read-only in UI for the user using “user.vm.readonly.ui.details” which accepts a comma-separated list of details.

@shwstppr you wrote about a comma seperated list... do you have an example for that?

DaanHoogland · 2019-05-24T12:57:02Z

I apologise for merging before rename to remove the [WIP] tag.
i'll, as way of repent, search for a convenient way to block based on a label and/or title tag

shwstppr · 2019-05-25T20:52:55Z

VM details can be made read-only in UI for the user using “user.vm.readonly.ui.details” which accepts a comma-separated list of details.
@shwstppr you wrote about a comma seperated list... do you have an example for that?

I should have added this to PR desc @svenvogel

shwstppr mentioned this pull request Mar 28, 2019
ui: instance settings visibility shapeblue/cloudstack#38
Closed
5 tasks

borisstoyanov approved these changes Apr 3, 2019
View reviewed changes

yadvr mentioned this pull request Apr 5, 2019
api: instance and template details are free text #3240
Merged
5 tasks

yadvr requested review from DagSonsteboSB and PaulAngus May 23, 2019 06:18

yadvr added this to the 4.13.0.0 milestone May 23, 2019

shwstppr force-pushed the instance-settings-visibility branch from ed4c793 to 29a0e47Compare May 23, 2019 06:40

shwstppr force-pushed the instance-settings-visibility branch from 29a0e47 to 63b03b0Compare May 23, 2019 10:35

DaanHoogland added component:api type:bug component:UI labels May 23, 2019

yadvr approved these changes May 24, 2019
View reviewed changes

DaanHoogland merged commit 46a3279 into apache:masterMay 24, 2019

yadvr changed the title ~~[WIP DO NOT MERGE] ui: instance settings visibility~~ui: instance settings visibilityMay 24, 2019

yadvr mentioned this pull request Jun 25, 2019
User can see the setting tab of vms, and change the value of settings #3043
Closed

weizhouapache mentioned this pull request Dec 2, 2020
User vm details is readonly on UI but still can be changed via api or cloudmonkey/cmk #4514
Closed

Uh oh!

Conversation

shwstppr commented Mar 28, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

borisstoyanov commented Apr 2, 2019

Uh oh!

blueorangutan commented Apr 2, 2019

Uh oh!

blueorangutan commented Apr 2, 2019

Uh oh!

borisstoyanov commented Apr 2, 2019

Uh oh!

blueorangutan commented Apr 2, 2019

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented May 23, 2019

Uh oh!

shwstppr commented May 23, 2019

Uh oh!

shwstppr commented May 23, 2019

Uh oh!

blueorangutan commented May 23, 2019

Uh oh!

blueorangutan commented May 23, 2019

Uh oh!

DaanHoogland commented May 23, 2019

Uh oh!

shwstppr commented May 23, 2019

Uh oh!

DaanHoogland commented May 23, 2019

Uh oh!

blueorangutan commented May 23, 2019

Uh oh!

blueorangutan commented May 23, 2019

Uh oh!

DaanHoogland commented May 23, 2019

Uh oh!

blueorangutan commented May 23, 2019

Uh oh!

yadvr commented May 23, 2019

Uh oh!

blueorangutan commented May 23, 2019

Uh oh!

blueorangutan commented May 23, 2019

Uh oh!

blueorangutan commented May 23, 2019

Uh oh!

svenvogel commented May 24, 2019

Uh oh!

DaanHoogland commented May 24, 2019

Uh oh!

shwstppr commented May 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

shwstppr commented Mar 28, 2019•
edited
Loading