server: allow disk offering selection for volume from snapshot by shwstppr · Pull Request #3246 · apache/cloudstack

shwstppr · 2019-03-28T10:01:00Z

Description

Problem: Volume created from a snapshot does not show its disk offering.

Root Cause: The volume created from a snapshot of a root disk does not have a disk offering therefore the disk offering of the created volume from the snapshot is empty.

Solution: Refactored createVolume API and extended UI to allow user to select a disk offering while creating a volume using a root disk volume snapshot. For creating volumes using data disk volume snapshot, the disk offering given by the snapshot will be assigned. Disk offering selection in the UI form for volume creation from snapshot is depicted in screenshot below.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

From UI

Snapshots created for ROOT disk does not have disk offering id therefore when volume is created from them resulting volume also doesn't have any disk offering. This change allows selection of disk offering in UI when creating volumes from such snapshots. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

borisstoyanov · 2019-04-05T10:47:09Z

@blueorangutan package

blueorangutan · 2019-04-05T10:47:42Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-04-05T11:09:01Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2683

borisstoyanov · 2019-04-05T11:26:24Z

@blueorangutan test

blueorangutan · 2019-04-05T11:26:41Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2019-04-05T18:52:35Z

Trillian test result (tid-3476)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25091 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3246-t3476-kvm-centos7.zip
Smoke tests completed. 70 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

borisstoyanov

LGTM, manually checked

yadvr · 2019-05-23T14:34:59Z

@blueorangutan package

blueorangutan · 2019-05-23T14:36:03Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-05-23T17:55:02Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2770

yadvr · 2019-05-24T07:05:12Z

@blueorangutan test centos7 vmware-65u2

blueorangutan · 2019-05-24T07:06:03Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

blueorangutan · 2019-05-24T21:23:54Z

Trillian test result (tid-3580)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 49407 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3246-t3580-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 69 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_05_rvpc_multi_tiers	`Failure`	594.30	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	640.28	test_vpc_redundant.py

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

shwstppr · 2019-06-13T09:49:57Z

@blueorangutan package

blueorangutan · 2019-06-13T09:50:27Z

@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-06-13T10:10:36Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2887

borisstoyanov · 2019-06-17T09:02:57Z

@blueorangutan test

blueorangutan · 2019-06-17T09:03:44Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

borisstoyanov

LGTM, attached test results
test-results.xlsx

blueorangutan · 2019-06-17T17:39:34Z

Trillian test result (tid-3693)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 29473 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3246-t3693-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 71 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

borisstoyanov · 2019-06-21T10:47:41Z

@blueorangutan package

blueorangutan · 2019-06-21T10:48:01Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2019-06-21T11:10:57Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2921

yadvr · 2019-06-25T06:17:19Z

@blueorangutan test

blueorangutan · 2019-06-25T06:18:07Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2019-06-25T08:22:33Z

This can be merged as soon as the tests are in and are OK.

blueorangutan · 2019-06-25T14:01:53Z

Trillian test result (tid-11)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26329 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3246-t11-kvm-centos7.zip
Smoke tests completed. 71 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

shwstppr mentioned this pull request Mar 28, 2019
server: allow disk offering selection for volume from snapshot shapeblue/cloudstack#34
Closed
5 tasks

borisstoyanov approved these changes Apr 8, 2019
View reviewed changes

yadvr approved these changes May 23, 2019
View reviewed changes

yadvr added this to the 4.13.0.0 milestone May 27, 2019

ui: fix for extra diskofferingid param for data disk snaps to volume
bf4e50b
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

borisstoyanov approved these changes Jun 17, 2019
View reviewed changes

shwstpprand others added 3 commits June 20, 2019 16:41

ui: fix for allowing volume creation without offering
53d006b
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

server: added disk offering size check for volume creation from snapshot
8948344
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

ui: revert53d006b
b76e6c5
Signed-off-by: Abhishek Kumar <abhishek.kumar@shapeblue.com>

yadvr changed the title ~~[WIP DO NOT MERGE] server: allow disk offering selection for volume from snapshot~~server: allow disk offering selection for volume from snapshotJun 25, 2019

nvazquez approved these changes Jun 25, 2019
View reviewed changes

yadvr merged commit 1b79466 into apache:masterJun 25, 2019

Uh oh!

Conversation

shwstppr commented Mar 28, 2019• edited by borisstoyanov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

borisstoyanov commented Apr 5, 2019

Uh oh!

blueorangutan commented Apr 5, 2019

Uh oh!

blueorangutan commented Apr 5, 2019

Uh oh!

borisstoyanov commented Apr 5, 2019

Uh oh!

blueorangutan commented Apr 5, 2019

Uh oh!

blueorangutan commented Apr 5, 2019

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented May 23, 2019

Uh oh!

blueorangutan commented May 23, 2019

Uh oh!

blueorangutan commented May 23, 2019

Uh oh!

yadvr commented May 24, 2019

Uh oh!

blueorangutan commented May 24, 2019

Uh oh!

blueorangutan commented May 24, 2019

Uh oh!

shwstppr commented Jun 13, 2019

Uh oh!

blueorangutan commented Jun 13, 2019

Uh oh!

blueorangutan commented Jun 13, 2019

Uh oh!

borisstoyanov commented Jun 17, 2019

Uh oh!

blueorangutan commented Jun 17, 2019

Uh oh!

borisstoyanov left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jun 17, 2019

Uh oh!

borisstoyanov commented Jun 21, 2019

Uh oh!

blueorangutan commented Jun 21, 2019

Uh oh!

blueorangutan commented Jun 21, 2019

Uh oh!

yadvr commented Jun 25, 2019

Uh oh!

blueorangutan commented Jun 25, 2019

Uh oh!

yadvr commented Jun 25, 2019

Uh oh!

blueorangutan commented Jun 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

shwstppr commented Mar 28, 2019•
edited by borisstoyanov
Loading