Skip to content

User allowed to tag project created by him - #3323

Merged
DaanHoogland merged 1 commit into
apache:masterfrom
Spaceman1984:userOwnProjectTag
May 28, 2019
Merged

User allowed to tag project created by him#3323
DaanHoogland merged 1 commit into
apache:masterfrom
Spaceman1984:userOwnProjectTag

Conversation

@Spaceman1984

Copy link
Copy Markdown
Contributor

Description

Fixed issue where a user cannot tag a project.

To reproduce:

in the UI:

log in as a user type
create a project
tag the new created project

Fixes: #2823

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Tested from UI.

Created a new project, and tagged the project, no errors.

Tested with cloudmonkey

Tested under Ubuntu server 18.04.2 LTS using the simulator

@anuragawanuragaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followed up from #3318

The only comment left unanswered was "Is it safe to assume the project account id will map to the user who created the project? Looks like it is set up from the passed parameter to Create Project Command."

I still believe it's not safe to assume that it's the owner however, I tested and verified that when a user creates a project his username is fed into the API call from UI as "projectAccoundId". The only case where this may still not work is when user creates a project from CLI. But that is still better than current bug.

@DaanHoogland

Copy link
Copy Markdown
Contributor

@anuragaw you say "username is fed into ...", a username is not the same as an account name!
sounds like it's a hazardous assumption

@yadvr

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2801

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan test

@apacheapache deleted a comment from blueorangutanMay 27, 2019
@apacheapache deleted a comment from blueorangutanMay 27, 2019
@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@apacheapache deleted a comment from blueorangutanMay 27, 2019
@apacheapache deleted a comment from yadvrMay 27, 2019
@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-3594)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 27507 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3323-t3594-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Smoke tests completed. 70 look OK, 0 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File

@DaanHooglandDaanHoogland changed the title Fixed: User not allowed to tag project created by himUser allowed to tag project created by himMay 28, 2019
@DaanHoogland
DaanHoogland merged commit de18613 into apache:masterMay 28, 2019
@DaanHoogland

Copy link
Copy Markdown
Contributor

It seems this causes #3377 . we may have to revert :(

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

api: project: tag: User not allowed to tag project created by him

6 participants

@Spaceman1984@DaanHoogland@yadvr@blueorangutan@anuragaw@svenvogel