Skip to content

JDK11 support - #3601

Merged
yadvr merged 42 commits into
apache:masterfrom
shapeblue:jdk11-support
Feb 12, 2020
Merged

JDK11 support#3601
yadvr merged 42 commits into
apache:masterfrom
shapeblue:jdk11-support

Conversation

@yadvr

@yadvryadvr commented Sep 18, 2019

Copy link
Copy Markdown
Member

This splits the Debian10 base/template changes to this PR #3797

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

@widowido added this to the 4.14.0.0 milestone Sep 18, 2019
@wido

wido commented Sep 18, 2019

Copy link
Copy Markdown
Contributor

This is a good start!

In #3195@GabrielBrascher and me are working on porting scripts to Python 3.

Inside the SSVM we have a lot of Python 2 code which needs to be looked at.

Debian 10 still has Python 2, but the next Debian release won't have it anymore.

@weizhouapache

Copy link
Copy Markdown
Member

@weizhouapache this maybe related to jdk or mvn version. Can you try with latest mvn, I'm using 3.6.3 and jdk11 11.0.4 or above?

@rhtyd could be maven version related. I am using maven 3.6.0 and openjdk 11.0.6.
anyway, maven-jaxb2-plugin 0.7.1 is too old, it was released in 2010...
it should be better to use latest 0.14.0
https://mvnrepository.com/artifact/org.jvnet.jaxb2.maven2/maven-jaxb2-plugin

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr

yadvr commented Feb 8, 2020

Copy link
Copy Markdown
MemberAuthor

Fixed dependency version @weizhouapache
@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@yadvr

yadvr commented Feb 8, 2020

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@yadvr

yadvr commented Feb 9, 2020

Copy link
Copy Markdown
MemberAuthor

Manually rekicked packaging

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-794

@weizhouapache

Copy link
Copy Markdown
Member

@rhtyd have you build new systemvm template with jdk11 ?

@yadvr

yadvr commented Feb 9, 2020

Copy link
Copy Markdown
MemberAuthor

@weizhouapache

Copy link
Copy Markdown
Member

@weizhouapachehttp://download.cloudstack.org/systemvm/4.14/

@rhtyd thanks.
my mistake, I re-upload new systemvm template but did not clean template_spool_ref so systemvms still use old 4.11.3 template.
I will test it.

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-940)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31000 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t940-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 78 look OK, 1 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_02_vpc_privategw_static_routesFailure223.32test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanupFailure222.00test_privategw_acl.py
test_04_rvpc_privategw_static_routesFailure320.87test_privategw_acl.py

@yadvr

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-798

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-941)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35935 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t941-vmware-65u2.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 73 look OK, 1 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_02_vpc_privategw_static_routesFailure333.01test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanupFailure338.23test_privategw_acl.py
test_04_rvpc_privategw_static_routesFailure520.67test_privategw_acl.py

@yadvr

Copy link
Copy Markdown
MemberAuthor

VP failures are consistently failing on few others PRs.

The following tests on Travis are consistently failing:

| test_03_delete_detached_volume | Failure | 90.193 | test_volumes |
| test_11_destroy_vm_and_volumes | Failure | 46.104 | test_vm_life_cycle |
| test_09_delete_detached_volume | Failure | 5.401 | test_volumes 

@weizhouapache can you check ^^ and advise? This is also seen on master. cc @DaanHoogland@andrijapanicsb

@weizhouapache

Copy link
Copy Markdown
Member

@rhtyd @DaanHoogland I will check
Do we have same issue on other PRs ?

@yadvr

Copy link
Copy Markdown
MemberAuthor

Possibly @weizhouapache, the test failures hint at the recently merged feature perhaps. Can you check?

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-944)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31118 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t944-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 78 look OK, 1 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_02_vpc_privategw_static_routesFailure215.17test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanupFailure211.53test_privategw_acl.py
test_04_rvpc_privategw_static_routesFailure315.04test_privategw_acl.py

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-945)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45861 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3601-t945-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Smoke tests completed. 77 look OK, 2 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_02_vpc_privategw_static_routesFailure355.77test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanupFailure348.59test_privategw_acl.py
test_04_rvpc_privategw_static_routesFailure555.38test_privategw_acl.py
test_01_scale_vmFailure19.60test_scale_vm.py

@yadvr

Copy link
Copy Markdown
MemberAuthor

Smoketests LGTM, except for test_privategw_acl.py failures which are known. Travis LGTM except for the failures shared, I'll collaborate with @weizhouapache to get it addressed via #3880

@yadvr

Copy link
Copy Markdown
MemberAuthor

Considering no objections and lgtm from Andrija and Daan will merge this.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@yadvr@wido@blueorangutan@DaanHoogland@shwstppr@Pearl1594@weizhouapache@andrijapanicsb