Uh oh!
There was an error while loading. Please reload this page.
server: acquire IPv4 address when add secondary IP to nic if IP is not specified - #3635
Conversation
…t specified After commit fbf4884, admin need to specify an ipv4 or ipv6 addresses when add IP to nic which breaks backward compatibity. If IP is not specified, a IPv4 address should be returned.
ustcweizhou
commented
Oct 15, 2019
@wido@GabrielBrascher @rhtyd |
GabrielBrascher
left a comment
There was a problem hiding this comment.
Code LGTM, thanks @ustcweizhou.
yadvr
commented
Nov 11, 2019
@blueorangutan package |
blueorangutan
commented
Nov 11, 2019
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
blueorangutan
commented
Nov 11, 2019
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-344 |
Uh oh!
There was an error while loading. Please reload this page.
DaanHoogland
commented
Nov 20, 2019
@blueorangutan test |
blueorangutan
commented
Nov 20, 2019
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
blueorangutan
commented
Nov 20, 2019
Trillian test result (tid-503)
|
…t specified (apache#3635) After commit fbf4884, admin need to specify an ipv4 or ipv6 addresses when add IP to nic which breaks backward compatibity. If IP is not specified, a IPv4 address should be returned.
Description
After commit fbf4884, admin need to specify an ipv4 or ipv6 addresses when add IP to nic which breaks backward compatibity. If IP is not specified, a IPv4 address should be returned.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
When I add an IP to a nic and do not specify an IP,
Before this PR, it gives an error "Allocating ip to guest nic 111 failed"
After this PR, it succeeds.