Skip to content

Update SystemVM scripts from python2 to python3 - #3730

Closed
GabrielBrascher wants to merge 6 commits into
apache:masterfrom
CLDIN:python2to3vr
Closed

Update SystemVM scripts from python2 to python3#3730
GabrielBrascher wants to merge 6 commits into
apache:masterfrom
CLDIN:python2to3vr

Conversation

@GabrielBrascher

@GabrielBrascherGabrielBrascher commented Nov 29, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Description

  • Considering that Python 2.7 will not be maintained in 2020 (will be retired on 1st January 2020) next VR template should have Python3 installed to support python3 scripts; additionally, VR's Python2 codebase should be migrated to Python3.

  • This PR covers partially issue Python 3 compatibility #3195.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

@GabrielBrascherGabrielBrascher added this to the 4.14.0.0 milestone Nov 29, 2019
@GabrielBrascherGabrielBrascher self-assigned this Nov 29, 2019
@GabrielBrascher
GabrielBrascherforce-pushed the python2to3vr branch 2 times, most recently from 7f40fbb to de8d94fCompareNovember 29, 2019 21:27
@DaanHoogland

DaanHoogland commented Nov 30, 2019

Copy link
Copy Markdown
Contributor

some pylint errors in travis job 1, mostly requiring extra blank lines at places @GabrielBrascher .

@GabrielBrascher
GabrielBrascherforce-pushed the python2to3vr branch 8 times, most recently from d4d0458 to 199efd7CompareDecember 4, 2019 23:37
DaanHoogland
DaanHoogland reviewed Dec 5, 2019
View reviewed changes
Comment threadengine/components-api/src/main/java/com/cloud/ha/HighAvailabilityManager.java
* HighAvailabilityManager checks to make sure the VMs are running fine.
*/
public interface HighAvailabilityManager extends Manager {

@DaanHooglandDaanHooglandDec 5, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GabrielBrascher why do I see java changes in this PR?

@GabrielBrascherGabrielBrascherDec 5, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad @DaanHoogland, I was debugging this and did commit by mistake, will soon be removed soon.

@GabrielBrascherGabrielBrascher changed the title [WIP] update VR's scripts from python2 to python3[WIP DO NOT MERGE] update VR's scripts from python2 to python3Dec 5, 2019
@GabrielBrascher
GabrielBrascherforce-pushed the python2to3vr branch 2 times, most recently from aaa994b to 4356562CompareDecember 5, 2019 15:21
@DaanHoogland

DaanHoogland commented Jan 5, 2020

Copy link
Copy Markdown
Contributor

@GabrielBrascher can you give an indication on this. as we are out of time for python2 now?
how much more work needed and should it be reviewed yet!

@GabrielBrascher

GabrielBrascher commented Jan 6, 2020

Copy link
Copy Markdown
MemberAuthor

@DaanHoogland it still needs some work and testing, therefore, we can wait a bit for reviewing it.
I will be testing it tomorrow to re-assess the state; the plan is to address the pending points until the end of the week.

@GabrielBrascherGabrielBrascher mentioned this pull request Jan 15, 2020
Closed
8 tasks
@DaanHoogland

DaanHoogland commented Sep 25, 2020

Copy link
Copy Markdown
Contributor

@GabrielBrascher I see pylint errors again in travis job 1, can you have a look?

@GabrielBrascher
GabrielBrascherforce-pushed the python2to3vr branch 4 times, most recently from 99c2cad to 6259183CompareSeptember 26, 2020 04:43
@DaanHoogland

DaanHoogland commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

@GabrielBrascher@wido @rhtyd @weizhouapache@PaulAngus python3 work in general has been neglected for a while. Are we still going to push it for 4.15?
@blueorangutan package

@blueorangutan

blueorangutan commented Oct 20, 2020

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@GabrielBrascher

GabrielBrascher commented Oct 20, 2020

Copy link
Copy Markdown
MemberAuthor

@DaanHoogland I have been able to run some tests on the Advanced network with security groups, and a few tests on the basic network. But it still lacking some tests on advanced networks with VPC, etc.

With that said, I think that we will need a couple more months and also more review/test.

@blueorangutan

blueorangutan commented Oct 20, 2020

Copy link
Copy Markdown

Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2222

@DaanHoogland

DaanHoogland commented Oct 20, 2020

Copy link
Copy Markdown
Contributor

@GabrielBrascher that would mean moving to the next milestone!

@GabrielBrascher

GabrielBrascher commented Oct 20, 2020

Copy link
Copy Markdown
MemberAuthor

@DaanHoogland correct! I migrated it to 4.16 so we don't wait longer to release 4.15.

@GabrielBrascher

GabrielBrascher commented Feb 10, 2021

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

blueorangutan commented Feb 10, 2021

Copy link
Copy Markdown

@GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Feb 10, 2021

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2673

@DaanHooglandDaanHoogland mentioned this pull request Feb 24, 2021
Merged
12 tasks
@DaanHoogland

DaanHoogland commented Mar 1, 2021

Copy link
Copy Markdown
Contributor

@GabrielBrascher can we close this?

@GabrielBrascher

GabrielBrascher commented Mar 1, 2021

Copy link
Copy Markdown
MemberAuthor

@DaanHoogland sure! I will close this one, if necessary we can always re-open it.

@GabrielBrascher

GabrielBrascher commented Mar 1, 2021

Copy link
Copy Markdown
MemberAuthor

PR closed in favor of #4727.

@GabrielBrascherGabrielBrascher mentioned this pull request Mar 12, 2021
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swillswillAwaiting requested review from swill
@jayapalujayapaluAwaiting requested review from jayapalu
@DaanHooglandDaanHooglandAwaiting requested review from DaanHoogland
@yadvryadvrAwaiting requested review from yadvr
@andrijapanicsbandrijapanicsbAwaiting requested review from andrijapanicsb
@borisstoyanovborisstoyanovAwaiting requested review from borisstoyanov
@nvazqueznvazquezAwaiting requested review from nvazquez
@svenvogelsvenvogelAwaiting requested review from svenvogel
@widowidoAwaiting requested review from wido

Assignees

@GabrielBrascherGabrielBrascher

Labels

component:networkingcomponent:systemvm-isocomponent:systemvm-templatecomponent:virtual-routerPythonWarning... Python code Ahead!python3type:enhancement

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

7 participants

@GabrielBrascher@DaanHoogland@weizhouapache@yadvr@wido@blueorangutan@ACSGitBot