kvm: Enable virtio drivers based on guest os display name

[ustcweizhou]

Description

When we add new guest os, sometimes we missed the records in guest_os_hypervisor.
However, the guest disk model (virtio/ide) is determined by record in the table.
It causes the issue that some new guest os(eg Debian 8/9) uses e1000 instead of virtio nic, and ide disk instead of virtio disk.

To fix the issue permanantly, pass the guest os name in guest_os if the record for kvm is not found in guest_os_hypervisor.

Related commit:7ac9f00eeeb4cd37ec39efeba066e799b581b1a0

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

[svenvogel]

@weizhouapache can you explain it me a little bit better. if i understand it correctly if guestosmapping and host is null then we set guestOS.getDisplayName(). why display name? maybe i stand on the line 😕

[weizhouapache]

@weizhouapache can you explain it me a little bit better. if i understand it correctly if guestosmapping and host is null then we set guestOS.getDisplayName(). why display name? maybe i stand on the line 😕

@svenvogel
here is an example:
in guest_os, we have Debian 9

mysql> select id,name,display_name from guest_os where id in (289,290);
+-----+------+-----------------------------+
| id | name | display_name |
+-----+------+-----------------------------+
| 289 | NULL | Debian GNU/Linux 9 (32-bit) |
| 290 | NULL | Debian GNU/Linux 9 (64-bit) |
+-----+------+-----------------------------+
2 rows in set (0.01 sec)

however, in guest_os_hypervisor, there is no record for these guest oses on kvm

mysql> select * from guest_os_hypervisor where guest_os_id in (289,290) and hypervisor_type='KVM';
Empty set (0.00 sec)

when we start a vm with Debian 9, in StartCommand it shows

"arch":"x86_64","os":"Debian GNU/Linux 9 (64-bit)","platformEmulator":"Other"

so vm is started with ide disk and e1000 nic.

with this change, "platformEmulator" will be set to same value as "os"

[yadvr]

Some testing required - @DaanHoogland@andrijapanicsb

[andrijapanicsb]

@blueorangutan package

[blueorangutan]

@andrijapanicsb a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-856

[yadvr]

@ustcweizhou how about we check and fallback to "Other" in case guestOS.getDisplayName() is null or empty (unlikely but just to make code more defensive)?

[yadvr]

LGTM, left a minor remark. Did not test it.

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[DaanHoogland]

sorry @weizhouapache, i editted according to @rhtyd 's comment (kinda, revert if you want)

[weizhouapache]

@DaanHoogland thanks Daan !
I changed unknown to Other

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-887

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1015)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28098 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3879-t1015-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 76 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_vpc_privategw_static_routes	Failure	190.76	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	Failure	187.20	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	Failure	269.84	test_privategw_acl.py

[yadvr]

Tests LGTM, the failures are known issue

[shwstppr]

LGTM based on code changes and travis