Skip to content

Debian10 support - #4104

Merged
yadvr merged 11 commits into
apache:masterfrom
shapeblue:debian10-support
Jun 9, 2020
Merged

Debian10 support#4104
yadvr merged 11 commits into
apache:masterfrom
shapeblue:debian10-support

Conversation

@yadvr

@yadvryadvr commented May 27, 2020

Copy link
Copy Markdown
Member

This upgrades the systemvmtemplate base to Debian 10 with openjdk-11.
Fixes#3654

Prev. #3797

Public location: (testing purposes, until GA)
http://download.cloudstack.org/systemvm/4.15/

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

This upgrades the systemvmtemplate base to Debian 10 with openjdk-11.
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvryadvr added this to the 4.15.0.0 milestone May 27, 2020
@yadvr

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔debian. JID-1246

yadvr added 2 commits May 27, 2020 12:00
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔debian. JID-1248

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-1571)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40626 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4104-t1571-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLFailure356.68test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routersFailure342.19test_vpc_redundant.py

@DaanHoogland

Copy link
Copy Markdown
Contributor

@rhtyd can you incorporate teh change in #3921 in this one?

@DaanHooglandDaanHoogland changed the title [WIP] Debian10 supportDebian10 supportMay 28, 2020
@yadvr

Copy link
Copy Markdown
MemberAuthor

@Spaceman1984 can you merge/push your PR commits (or patch https://patch-diff.githubusercontent.com/raw/apache/cloudstack/pull/3921.patch) to this branch?

@yadvr

yadvr commented Jun 4, 2020

Copy link
Copy Markdown
MemberAuthor

Looks like testing with kvm passed, we'll need to kick tests against other hypervisors manually from Trillian.
@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✖centos7 ✖debian. JID-1277

@yadvr
yadvr marked this pull request as ready for review June 4, 2020 03:16
@yadvr

yadvr commented Jun 4, 2020

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔debian. JID-1287

@yadvr

yadvr commented Jun 4, 2020

Copy link
Copy Markdown
MemberAuthor

Kicked matrix smoketests on jenkins by overriding the built systemvmtemplates

@DaanHooglandDaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks ok, of course every body needs to test 🤒

@yadvr

yadvr commented Jun 4, 2020

Copy link
Copy Markdown
MemberAuthor

The systemvmtemplate build log: http://download.cloudstack.org/systemvm/4.15/build.log
Public URL for dev-testing until GA: http://download.cloudstack.org/systemvm/4.15/

@weizhouapache

Copy link
Copy Markdown
Member

@rhtyd I have two concerns
(1) does Trillian use new debian10 template in tests ?
(2) is python2 or python3 installed in debian10 ?

@yadvr

yadvr commented Jun 4, 2020

Copy link
Copy Markdown
MemberAuthor

Hi @weizhouapache

  • Trillian by default uses branch/version specific systevmtemplates, but allows option to override. For testing this PR, I'm not using BO but passing systemvmtemplate overide on our internal Jenkins. This gives us ability to test a PR with a new systemvmtemplate.
  • Currently, no python3 is not installed in this PR. Are you/anyone-else working to migrate VR scripts from py2 to py3, then I can make changes in this PR to install python3 (make the template future ready).

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-1619)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38950 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4104-t1619-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Smoke tests completed. 82 look OK, 1 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_01_add_delete_kubernetes_supported_versionError1807.60test_kubernetes_supported_versions.py

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-1620)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 59548 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4104-t1620-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 83 look OK, 0 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File

@weizhouapache

Copy link
Copy Markdown
Member

Hi @weizhouapache

  • Trillian by default uses branch/version specific systevmtemplates, but allows option to override. For testing this PR, I'm not using BO but passing systemvmtemplate overide on our internal Jenkins. This gives us ability to test a PR with a new systemvmtemplate.
  • Currently, no python3 is not installed in this PR. Are you/anyone-else working to migrate VR scripts from py2 to py3, then I can make changes in this PR to install python3 (make the template future ready).

@rhtyd nice, thanks.
let's merge it, and upgrade to python3 in systemvm template along with python2->python3 support (it seems to be part of centos8 support).

yadvr added 2 commits June 8, 2020 07:18
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit f9cb0bfe51e12f704b4106c2d5484e2dce61fd7c)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr

yadvr commented Jun 8, 2020

Copy link
Copy Markdown
MemberAuthor

@weizhouapache Thanks, we'll merge this once the xenserver tests are also in.

  • I checked python3 was already installed on the built systemvmtemplate, but I've added explicit pkg to be installed
  • python2->3 migration is not done in the centos8 support PR; the systemvm continue to be on Debian where python2 ships by default (with the python package)

@weizhouapache

Copy link
Copy Markdown
Member

code lgtm
did not test it

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-1638)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 64333 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4104-t1638-xenserver-71.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 80 look OK, 3 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_05_deploy_and_upgrade_kubernetes_ha_clusterFailure1863.68test_kubernetes_clusters.py
test_01_scale_vmFailure24.62test_scale_vm.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLFailure459.52test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routersFailure403.47test_vpc_redundant.py

@yadvr

yadvr commented Jun 9, 2020

Copy link
Copy Markdown
MemberAuthor

Checked test failures not related to this PR on XenServer, overall all tests have passed.
The cale_vm test case failure is due to license issue (it would pass on xcp-ng).

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remote VPN not working if site-to-site VPN exists

6 participants

@yadvr@blueorangutan@DaanHoogland@weizhouapache@PaulAngus@Spaceman1984