Role based users in Projects by Pearl1594 · Pull Request #4128 · apache/cloudstack

Pearl1594 · 2020-06-04T04:41:50Z

Description

Enabling Role Based users in projects
Primate PR related to the FR: apache/cloudstack-primate#382

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

…leBased-users

yadvr · 2020-06-04T04:59:36Z

@blueorangutan package

blueorangutan · 2020-06-04T05:00:33Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-06-04T05:34:02Z

Packaging result: ✔centos7 ✔debian. JID-1291

…e userid

Pearl1594 · 2020-06-11T06:19:40Z

@blueorangutan package

blueorangutan · 2020-06-11T06:20:09Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-06-11T06:46:48Z

Packaging result: ✔centos7 ✔debian. JID-1336

Pearl1594 · 2020-06-11T06:49:01Z

@blueorangutan test

blueorangutan · 2020-06-11T06:50:03Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2020-06-11T09:38:13Z

@Pearl1594 can you put the related Primate PR link in the PR description?

Pearl1594 · 2020-06-11T09:43:09Z

Primate PR related to the FR: apache/cloudstack-primate#382

…leBased-users

…es + Marvin tests

Pearl1594 · 2020-06-22T14:50:59Z

@rhtyd Could you please review the PR

blueorangutan · 2020-06-23T04:48:17Z

Packaging result: ✔centos7 ✔debian. JID-1429

Pearl1594 · 2020-08-10T04:20:38Z

@blueorangutan package

blueorangutan · 2020-08-10T04:21:57Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-08-10T04:55:25Z

Packaging result: ✔centos7 ✔debian. JID-1687

Pearl1594 · 2020-08-10T04:57:58Z

@blueorangutan test

Pearl1594 · 2020-08-10T04:58:25Z

@blueorangutan test

blueorangutan · 2020-08-10T04:59:01Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

yadvr · 2020-08-10T07:44:08Z

Rekicked travis

Pearl1594 · 2020-08-11T08:32:50Z

@blueorangutan package

blueorangutan · 2020-08-11T08:33:57Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-08-11T09:19:36Z

Packaging result: ✔centos7 ✔debian. JID-1708

yadvr · 2020-08-11T09:58:42Z

@blueorangutan test

blueorangutan · 2020-08-11T09:59:57Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

DaanHoogland · 2020-08-12T07:09:07Z

test env failed restarting
@blueorangutan test

blueorangutan · 2020-08-12T07:09:57Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2020-08-12T23:51:31Z

Trillian test result (tid-2381)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 58132 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4128-t2381-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 82 look OK, 2 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_02_deploy_kubernetes_ha_cluster	`Error`	3612.32	test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_cluster	`Error`	0.03	test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_cluster	`Error`	0.03	test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster	`Error`	0.03	test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster	`Error`	0.03	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	35.92	test_kubernetes_clusters.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	383.08	test_vpc_redundant.py

yadvr · 2020-08-13T10:13:52Z

Test LGTM, failure in CKS are env related

Enables creating role based users in projects UI for feature: apache/cloudstack#4128 Also addresses issue: #485 Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com>

Enables creating role based users in projects UI for feature: #4128 Also addresses issue: #485 Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com> Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Pearl Dsilva added 3 commits May 29, 2020 17:12

Enable role based users in projects
a205635

Merge branch 'master' of github.com:shapeblue/cloudstack into proj-ro…
2fe5317
…leBased-users

Merge branch 'master' of github.com:shapeblue/cloudstack into proj-ro…
1443602
…leBased-users

Pearl1594 mentioned this pull request Jun 5, 2020
Enabling Role based Users in Projects apache/cloudstack-primate#382
Merged

Modified list responses for projectAccounts and invitations to includ…
c9b9746
…e userid

yadvr added this to the 4.15.0.0 milestone Jun 8, 2020

Pearl Dsilva added 2 commits June 9, 2020 16:04

revert API parameter change
44aa239

changes for backward compatability
6e3af3c

yadvr self-requested a review June 12, 2020 04:36

restrict user invitation visibility to only that specific user
7e0a64c

Pearl1594 force-pushed the proj-roleBased-users branch from a58367d to 7e0a64cCompare June 12, 2020 10:57

Merge branch 'master' of github.com:shapeblue/cloudstack into proj-ro…
e2fbd31
…leBased-users

yadvr added the status:work-in-progress label Jun 16, 2020

Added additional response params - listProjectAccounts + schema chang…
b2730dd
…es + Marvin tests

Pearl1594 force-pushed the proj-roleBased-users branch from f45d7ec to b2730ddCompare June 18, 2020 08:46

Pearl Dsilva added 2 commits June 19, 2020 06:36

Refactored code
1f7a81b

Add marvin tests
0fcb210

Pearl1594 force-pushed the proj-roleBased-users branch from ef93f15 to 0fcb210Compare June 22, 2020 05:18

yadvr closed this Aug 10, 2020

yadvr reopened this Aug 10, 2020

DaanHoogland reviewed Aug 10, 2020
View reviewed changes

Comment threadresults.xml Outdated

Pearl Dsilva added 2 commits August 10, 2020 19:49

remove results.xml file
95a6a43

detailed description of api parameter
970acd0

Pearl1594 force-pushed the proj-roleBased-users branch from 581c3f2 to 970acd0Compare August 11, 2020 08:32

DaanHoogland approved these changes Aug 11, 2020
View reviewed changes

DaanHoogland marked this pull request as ready for review August 11, 2020 08:45

yadvr merged commit c578004 into apache:masterAug 13, 2020

DaanHoogland added type:new-feature and removed status:CI-running labels Oct 21, 2020

ACSGitBot added the type:new_feature label Nov 8, 2020

Uh oh!

Conversation

Pearl1594 commented Jun 4, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Uh oh!

yadvr commented Jun 4, 2020

Uh oh!

blueorangutan commented Jun 4, 2020

Uh oh!

blueorangutan commented Jun 4, 2020

Uh oh!

Pearl1594 commented Jun 11, 2020

Uh oh!

blueorangutan commented Jun 11, 2020

Uh oh!

blueorangutan commented Jun 11, 2020

Uh oh!

Pearl1594 commented Jun 11, 2020

Uh oh!

blueorangutan commented Jun 11, 2020

Uh oh!

yadvr commented Jun 11, 2020

Uh oh!

Pearl1594 commented Jun 11, 2020

Uh oh!

Pearl1594 commented Jun 22, 2020

Uh oh!

blueorangutan commented Jun 23, 2020

Uh oh!

Pearl1594 commented Aug 10, 2020

Uh oh!

blueorangutan commented Aug 10, 2020

Uh oh!

blueorangutan commented Aug 10, 2020

Uh oh!

Pearl1594 commented Aug 10, 2020

Uh oh!

Pearl1594 commented Aug 10, 2020

Uh oh!

blueorangutan commented Aug 10, 2020

Uh oh!

yadvr commented Aug 10, 2020

Uh oh!

Uh oh!

Pearl1594 commented Aug 11, 2020

Uh oh!

blueorangutan commented Aug 11, 2020

Uh oh!

blueorangutan commented Aug 11, 2020

Uh oh!

yadvr commented Aug 11, 2020

Uh oh!

blueorangutan commented Aug 11, 2020

Uh oh!

DaanHoogland commented Aug 12, 2020

Uh oh!

blueorangutan commented Aug 12, 2020

Uh oh!

blueorangutan commented Aug 12, 2020

Uh oh!

yadvr commented Aug 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Pearl1594 commented Jun 4, 2020•
edited
Loading