Skip to content

engine: add support for VMware 7.0 dependency and hypervisor capability - #4300

Merged
yadvr merged 1 commit into
apache:4.15from
shapeblue:vsphere7
Apr 15, 2021
Merged

engine: add support for VMware 7.0 dependency and hypervisor capability#4300
yadvr merged 1 commit into
apache:4.15from
shapeblue:vsphere7

Conversation

@yadvr

@yadvryadvr commented Sep 1, 2020

Copy link
Copy Markdown
Member

This adds support for VMware 7.0 with a jar dependency and sql upgrade path. The jar dependency has been added to support noredist pkging here:
https://github.com/rhtyd/cloudstack-nonoss/blob/master/install-non-oss.sh#L37

Fixes#4441
Fixes#4423

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

@yadvryadvr added this to the 4.16.0.0 milestone Sep 1, 2020
@yadvr

yadvr commented Sep 1, 2020

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1865

@yadvr

yadvr commented Sep 2, 2020

Copy link
Copy Markdown
MemberAuthor

@blueorangutan test centos7 vmware-67u3

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

10 similar comments
@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@apacheapache deleted a comment from blueorangutanSep 7, 2020
@yadvr

yadvr commented Sep 7, 2020

Copy link
Copy Markdown
MemberAuthor

@blueorangutan test centos7 vmware-67u3

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-2694)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 77101 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t2694-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 78 look OK, 2 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_01_add_delete_kubernetes_supported_versionError970.19test_kubernetes_supported_versions.py
test_07_reboot_ssvmFailure41.90test_ssvm.py
test_08_reboot_cpvmFailure42.89test_ssvm.py

@yadvr

Copy link
Copy Markdown
MemberAuthor

Kicked tests against vCenter 7 based env.

@yadvr

Copy link
Copy Markdown
MemberAuthor

Marvin tests with this PR and vCenter 7.0 with CentOS7 mgmt server but two 6.7u3 ESXi hosts:

TestResultTime (s)Test File
test_01_deploy_kubernetes_clusterError0.15test_kubernetes_clusters.py
test_02_deploy_kubernetes_ha_clusterError0.07test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_clusterError0.06test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_clusterError0.07test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_clusterError0.06test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_clusterError0.06test_kubernetes_clusters.py
test_01_add_primary_storage_disabled_hostError0.51test_primary_storage.py
test_01_primary_storage_nfsError0.18test_primary_storage.py
ContextSuite context=TestStorageTags>:setupError0.31test_primary_storage.py
test_02_list_snapshots_with_removed_data_storeError1.21test_snapshots.py
test_02_create_template_with_checksum_sha1Error5.28test_templates.py
test_03_create_template_with_checksum_sha256Error5.20test_templates.py
test_04_create_template_with_checksum_md5Error5.20test_templates.py
test_01_volume_usageError11.57test_usage.py
test_11_migrate_vmError50.32test_vm_life_cycle.py
test_01_create_volumeError134.77test_volumes.py
test_02_attach_volumeError44.96test_volumes.py
test_03_download_attached_volumeError1.10test_volumes.py
test_04_delete_attached_volumeError1.11test_volumes.py
test_05_detach_volumeError1.10test_volumes.py
test_06_download_detached_volumeError1.11test_volumes.py
test_07_resize_failError2.28test_volumes.py
test_08_resize_volumeError1.11test_volumes.py
test_09_delete_detached_volumeError12.63test_volumes.py
test_11_attach_volume_with_unstarted_vmError2.39test_volumes.py
ContextSuite context=TestVolumes>:teardownError19.09test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLFailure443.14test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsError3790.27test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsError3790.31test_vpc_redundant.py
test_05_rvpc_multi_tiersError0.01test_vpc_redundant.py
ContextSuite context=TestVPCRedundancy>:teardownError0.02test_vpc_redundant.py

@yadvr

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2250

@yadvr

Copy link
Copy Markdown
MemberAuthor

@blueorangutan test centos7 vmware-67u3

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 377

@nvazquez

Copy link
Copy Markdown
Contributor

@blueorangutan test centos7 vmware-67u3

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-399)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 37625 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t399-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_root_resize.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 86 look OK, 1 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
ContextSuite context=TestVAppsVM>:setupError82.81test_vm_life_cycle.py

@yadvr

Copy link
Copy Markdown
MemberAuthor

@nvazquez can you kick smoketests against vmware 7.0 as well? And if we can get support for vsphere7 in Trillian?

@nvazquez

Copy link
Copy Markdown
Contributor

@blueorangutan help

@blueorangutan

Copy link
Copy Markdown

@nvazquez I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu18', 'ubuntu20']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'xenserver-71', 'xenserver-65sp1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']

@apacheapache deleted a comment from blueorangutanApr 14, 2021
@nvazquez

Copy link
Copy Markdown
Contributor

@blueorangutan help

@blueorangutan

Copy link
Copy Markdown

@nvazquez I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv]
Mgmt OS options: ['centos6', 'centos7', 'centos8', 'ubuntu18', 'ubuntu20']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-centos8', 'kvm-ubuntu18', 'kvm-ubuntu20', 'xenserver-71', 'xenserver-65sp1', 'vmware-70u1', 'vmware-67u3', 'vmware-65u2', 'vmware-60u2', 'vmware-55u3', 'xcpng76', 'xcpng80', 'xcpng81', 'xenserver-74', 'xcpng74']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.

Blessed contributors for kicking Trillian test jobs: ['rhtyd', 'nvazquez', 'PaulAngus', 'borisstoyanov', 'DaanHoogland', 'shwstppr', 'andrijapanicsb', 'Spaceman1984', 'Pearl1594', 'davidjumani', 'harikrishna-patnala', 'vladimirpetrov', 'sureshanaparti']

@nvazquez

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 411

@nvazquez

Copy link
Copy Markdown
Contributor

@blueorangutan test centos7 vmware-70u1

@apacheapache deleted a comment from blueorangutanApr 14, 2021
@apacheapache deleted a comment from blueorangutanApr 14, 2021
@blueorangutan

Copy link
Copy Markdown

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-70u1) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-441)
Environment: vmware-70u1 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36325 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4300-t441-vmware-70u1.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 85 look OK, 2 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_10_traceroute_in_vrFailure61.16test_diagnostics.py
test_01_redundant_vpc_site2site_vpnFailure347.83test_vpc_vpn.py
test_01_vpc_site2site_vpnFailure243.03test_vpc_vpn.py

@nvazquez

Copy link
Copy Markdown
Contributor

@rhtyd @vladimirpetrov Vmware 7.0 support was introduced into Trillian and the last tests were executed on it, few errors which seem unrelated to this PR. Please advise if we are ready to merge it

@yadvr

Copy link
Copy Markdown
MemberAuthor

LGTM, @vladimirpetrov are you lgtm on this?

@vladimirpetrovvladimirpetrov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing finished, LGTM @nvazquez, @rhtyd !

@yadvr

Copy link
Copy Markdown
MemberAuthor

Merging based on tests and code reviews.

@yadvr
yadvr merged commit 0302750 into apache:4.15Apr 15, 2021
DaanHoogland pushed a commit to shapeblue/cloudstack that referenced this pull request May 20, 2022
shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Jan 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cpvm not support VMware 7.0 console Adding a cluster

8 participants

@yadvr@blueorangutan@nvazquez@DaanHoogland@sureshanaparti@vladimirpetrov@PaulAngus@ACSGitBot