Skip to content

Qemu 2.10 requires -U flag to read volume metadata - #4567

Merged
DaanHoogland merged 6 commits into
apache:masterfrom
GutoVeronezi:add-flag-to-qemu-to-read-volume-data
Mar 18, 2021
Merged

Qemu 2.10 requires -U flag to read volume metadata#4567
DaanHoogland merged 6 commits into
apache:masterfrom
GutoVeronezi:add-flag-to-qemu-to-read-volume-data

Conversation

@GutoVeronezi

@GutoVeroneziGutoVeronezi commented Jan 4, 2021•
edited by weizhouapache
Loading

Copy link
Copy Markdown
Contributor

Description

Qemu 2.10 added the requirement of a --force-share flag to 'qemu-img info' command when reading information about a disk that is in use by a guest. After this Qemu release, to obtain the attached disk metadata, we need to use a flag to force information reading.

This PR intends to add the required flag to the qemu-img info command if the qemu version is 2.10+. We can get the Qemu version in the LibvirtConnection.

Fixes: #4024

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

How Has This Been Tested?

It has been tested locally.

@GutoVeronezi
GutoVeroneziforce-pushed the add-flag-to-qemu-to-read-volume-data branch from 5f49669 to 849035fCompareJanuary 4, 2021 16:21
@yadvr

yadvr commented Jan 5, 2021

Copy link
Copy Markdown
Member

@GutoVeronezi what error/issue do you see and on which KVM distro?

@rafaelweingartner

rafaelweingartner commented Jan 5, 2021•
edited
Loading

Copy link
Copy Markdown
Member

@rhtyd I checked this one with him. The problem happens on Qemu 2.10+ (running on Ubuntu). The release notes from Qemu have the following message.

Qemu 2.10 added the requirement of a --force-share flag to qemu-img
info when reading information about a disk that is in use by a
guest. We do this a lot in Nova for operations like gathering
information before live migration.

The problem is happening when ACS tries to get some info from a volume using qemu-img. Then, one would get the following error.

qemu-img: Could not open '/mnt/.../../volumeID': Failed to get shared "write" lock
Is another process using the image?

@yadvr

yadvr commented Jan 5, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Okay but which specific version KVM/Linux distro is it reproducible on? I'll want to test this.

@GutoVeronezi

GutoVeronezi commented Jan 5, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@rhtyd It has been tested over Ubuntu 18.04 with KVM 2.11.1

weizhouapache
weizhouapache reviewed Jan 5, 2021
View reviewed changes

@weizhouapacheweizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm
@DaanHoogland @rhtyd we need this in 4.15.0.0 as well.

@yadvr

yadvr commented Jan 5, 2021

Copy link
Copy Markdown
Member

Looks like RC4 has been cut, given Ubuntu 18.04 has been around for quite some time should this be considered a blocker?

@blueorangutan

blueorangutan commented Jan 5, 2021

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2526

@yadvr

yadvr commented Jan 5, 2021

Copy link
Copy Markdown
Member

Pkging was kicked manually BO pkging integration for some reason is not working (I'll check tomorrow)
@blueorangutan test

@blueorangutan

blueorangutan commented Jan 5, 2021

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@yadvr

yadvr commented Jan 5, 2021

Copy link
Copy Markdown
Member

@GutoVeronezi@weizhouapache probably too late now - RC4 is cut; in order to get the PR into 4.15, the base branch needs to be changed

@GutoVeronezi

GutoVeronezi commented Jan 5, 2021

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review guys. To us, it is fine if it only goes to master.

@weizhouapache

weizhouapache commented Jan 5, 2021

Copy link
Copy Markdown
Member

Thanks for the review guys. To us, it is fine if it only goes to master.

ok, let's merge this after 4.15.0.0 release

RodrigoDLopez
RodrigoDLopez approved these changes Jan 6, 2021
View reviewed changes

@RodrigoDLopezRodrigoDLopez left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM...
I think we need Unit tests to cover these changes... But to do this you'll need to do some changes in many methods.
Maybe you can do this in another PR?

Another point ... maybe you can better explain how this branch can be tested.

It has been tested locally.

Your explanation does not tell us anything related to the tests.

@GutoVeronezi

GutoVeronezi commented Jan 8, 2021

Copy link
Copy Markdown
ContributorAuthor

@RodrigoDLopez to test this enhancement I had used the create snapshot API.
With my test instance running, I tried to take a snapshot from the volume. Whitout the -u flag I was getting qemu-img: Could not open '/mnt/...': Failed to get shared "write" lockIs another process using the image? error.

GabrielBrascher
GabrielBrascher approved these changes Jan 15, 2021
View reviewed changes

@GabrielBrascherGabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

However, considering that this impacts versions that have at least ubuntu 18.04 (if I am not mistaken Ubuntu 18.04 gets by default qemu-kvm 2.11). It would be nice to have this on prior LTSs.

Any comment on what branches/releases should we target this one? @rhtyd @weizhouapache@rafaelweingartner and others

@DaanHooglandDaanHoogland added this to the 4.16.0.0 milestone Jan 18, 2021
@yadvr
yadvr changed the base branch from master to 4.15January 28, 2021 10:28
@yadvr
yadvr changed the base branch from 4.15 to masterJanuary 28, 2021 10:28
@yadvr

yadvr commented Jan 28, 2021

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Jan 28, 2021

Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jan 28, 2021

Copy link
Copy Markdown

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2615

@DaanHoogland

DaanHoogland commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

blueorangutan commented Jan 28, 2021

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Jan 28, 2021

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2617

@DaanHoogland

DaanHoogland commented Jan 28, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

blueorangutan commented Jan 28, 2021

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@GabrielBrascher

GabrielBrascher commented Mar 11, 2021

Copy link
Copy Markdown
Member

Thanks, @GutoVeronezi!

GabrielBrascher
GabrielBrascher approved these changes Mar 15, 2021
View reviewed changes

@GabrielBrascherGabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests indicate that all LibvirtException have been handled. LGTM.

@DaanHoogland
DaanHoogland merged commit 4e90a8c into apache:masterMar 18, 2021
@apacheapache deleted a comment from yadvrMar 19, 2021
@apacheapache deleted a comment from blueorangutanMar 19, 2021
@apacheapache deleted a comment from blueorangutanMar 19, 2021
@apacheapache deleted a comment from yadvrMar 19, 2021
@apacheapache deleted a comment from blueorangutanMar 19, 2021
@apacheapache deleted a comment from yadvrMar 19, 2021
@apacheapache deleted a comment from blueorangutanMar 19, 2021
@apacheapache deleted a comment from blueorangutanMar 19, 2021
@apacheapache deleted a comment from blueorangutanMar 19, 2021
@apacheapache deleted a comment from yadvrMar 19, 2021
@apacheapache deleted a comment from blueorangutanMar 19, 2021
@apacheapache deleted a comment from blueorangutanMar 19, 2021
@apacheapache deleted a comment from blueorangutanMar 19, 2021
@apacheapache deleted a comment from yadvrMar 19, 2021
@apacheapache deleted a comment from blueorangutanMar 19, 2021
@apacheapache deleted a comment from blueorangutanMar 19, 2021
@apacheapache deleted a comment from yadvrMar 19, 2021
@apacheapache deleted a comment from blueorangutanMar 19, 2021
@apacheapache deleted a comment from blueorangutanMar 19, 2021
@apacheapache deleted a comment from blueorangutanMar 19, 2021
@blueorangutan

blueorangutan commented Mar 20, 2021

Copy link
Copy Markdown

[S] Trillian test result (tid-181)
Environment: xenserver-72 (x2), Advanced Networking with Mgmt server 7
Total time taken: 68625 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4567-t181-xenserver-72.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_global_settings.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermittent failure detected: /marvin/tests/smoke/test_reset_vm_on_reboot.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_secondary_storage.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 48 look OK, 29 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
ContextSuite context=TestLoadBalance>:setupError0.00test_loadbalance.py
test_01_port_fwd_on_src_natFailure607.85test_network.py
test_02_port_fwd_on_non_src_natFailure608.98test_network.py
test_reboot_routerFailure955.80test_network.py
test_network_rules_acquired_public_ip_1_static_nat_ruleError609.23test_network.py
test_network_rules_acquired_public_ip_2_nat_ruleError610.18test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_RuleError613.24test_network.py
ContextSuite context=TestDeployvGPUenabledVM>:setupError0.00test_deploy_vgpu_enabled_vm.py
test_isolate_network_password_serverFailure161.29test_password_server.py
test_02_vpc_privategw_static_routesFailure184.51test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanupFailure182.73test_privategw_acl.py
test_04_rvpc_privategw_static_routesFailure275.41test_privategw_acl.py
test_UpdateConfigParamWithScopeError0.13test_global_settings.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80Failure353.20test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80Failure373.27test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfacesError193.16test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfacesError225.16test_internal_lb.py
ContextSuite context=TestResetVmOnReboot>:setupError0.00test_reset_vm_on_reboot.py
ContextSuite context=TestRAMCPUResourceAccounting>:setupError0.00test_resource_accounting.py
ContextSuite context=TestRouterDHCPHosts>:setupError0.00test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setupError0.00test_router_dhcphosts.py
ContextSuite context=TestRouterDns>:setupError0.00test_router_dns.py
ContextSuite context=TestRouterDnsService>:setupError0.00test_router_dnsservice.py
ContextSuite context=TestRouterIpTablesPolicies>:setupError0.00test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setupError0.00test_routers_iptables_default_policy.py
ContextSuite context=TestIsolatedNetworks>:setupError0.00test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setupError0.00test_routers_network_ops.py
ContextSuite context=TestRouterServices>:setupError0.00test_routers.py
ContextSuite context=TestScaleVm>:setupError0.00test_scale_vm.py
test_01_sys_vm_startFailure0.08test_secondary_storage.py
ContextSuite context=TestServiceOfferings>:setupError1511.26test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setupError0.00test_snapshots.py
test_01_list_sec_storage_vmFailure0.03test_ssvm.py
test_02_list_cpvm_vmFailure0.02test_ssvm.py
test_03_ssvm_internalsFailure0.02test_ssvm.py
test_04_cpvm_internalsFailure0.02test_ssvm.py
test_05_stop_ssvmFailure0.03test_ssvm.py
test_06_stop_cpvmFailure0.03test_ssvm.py
test_07_reboot_ssvmFailure0.03test_ssvm.py
test_08_reboot_cpvmFailure0.03test_ssvm.py
test_09_destroy_ssvmFailure0.02test_ssvm.py
test_10_destroy_cpvmFailure0.02test_ssvm.py
test_02_create_template_with_checksum_sha1Error65.35test_templates.py
test_03_create_template_with_checksum_sha256Error65.37test_templates.py
test_04_create_template_with_checksum_md5Error65.37test_templates.py
test_05_create_template_with_no_checksumError65.36test_templates.py
ContextSuite context=TestTemplates>:setupError1.97test_templates.py
ContextSuite context=TestISOUsage>:setupError0.00test_usage.py
ContextSuite context=TestLBRuleUsage>:setupError0.00test_usage.py
ContextSuite context=TestNatRuleUsage>:setupError0.00test_usage.py
ContextSuite context=TestPublicIPUsage>:setupError0.00test_usage.py
ContextSuite context=TestSnapshotUsage>:setupError0.00test_usage.py
ContextSuite context=TestVmUsage>:setupError0.00test_usage.py
ContextSuite context=TestVolumeUsage>:setupError0.00test_usage.py
ContextSuite context=TestVpnUsage>:setupError0.00test_usage.py
ContextSuite context=TestDeployVM>:setupError0.00test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setupError1.67test_vm_life_cycle.py
test_change_service_offering_for_vm_with_snapshotsError1.15test_vm_snapshots.py
ContextSuite context=TestVmSnapshot>:setupError8.89test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setupError0.00test_volumes.py
ContextSuite context=TestVolumes>:setupError0.00test_volumes.py
ContextSuite context=TestVPCRedundancy>:setupError0.00test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setupError0.00test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setupError0.00test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setupError0.00test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setupError0.00test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setupError0.00test_vpc_vpn.py
test_02_cancel_host_maintenace_with_migration_jobsFailure186.55test_host_maintenance.py

@yadvr

yadvr commented Mar 21, 2021

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Mar 21, 2021

Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests [S]

@blueorangutan

blueorangutan commented Mar 22, 2021

Copy link
Copy Markdown

[S] Trillian test result (tid-188)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 104934 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4567-t188-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 57 look OK, 29 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_01_create_lb_rule_src_natFailure308.00test_loadbalance.py
test_02_create_lb_rule_non_natFailure34.66test_loadbalance.py
test_assign_and_removal_lbFailure35.64test_loadbalance.py
test_DeployVmAntiAffinityGroup_in_projectError62.32test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroupError37.65test_affinity_groups.py
test_01_verify_libvirtError602.79test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restartError609.97test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_diskError605.83test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspciError601.99test_deploy_virtio_scsi_vm.py
test_05_change_vm_ostype_restartError610.05test_deploy_virtio_scsi_vm.py
test_06_verify_guest_lspci_againError602.09test_deploy_virtio_scsi_vm.py
ContextSuite context=TestAddConfigtoDeployVM>:setupError0.00test_deploy_vm_extra_config_data.py
test_01_port_fwd_on_src_natFailure605.17test_network.py
test_02_port_fwd_on_non_src_natFailure607.94test_network.py
ContextSuite context=TestPrivateVlansL2Networks>:setupError1230.17test_network.py
test_reboot_routerFailure360.95test_network.py
test_network_rules_acquired_public_ip_1_static_nat_ruleError608.42test_network.py
test_network_rules_acquired_public_ip_2_nat_ruleError609.01test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_RuleError614.20test_network.py
test_01_deployVMInSharedNetworkError659.45test_network.py
test_02_verifyRouterIpAfterNetworkRestartError634.51test_network.py
test_03_destroySharedNetworkFailure1.08test_network.py
ContextSuite context=TestSharedNetwork>:teardownError2.14test_network.py
test_isolate_network_password_serverFailure156.99test_password_server.py
test_02_vpc_privategw_static_routesFailure754.60test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanupFailure758.82test_privategw_acl.py
test_04_rvpc_privategw_static_routesFailure861.23test_privategw_acl.py
test_01_disableHumanReadableLogsError602.63test_human_readable_logs.py
test_02_enableHumanReadableLogsError602.83test_human_readable_logs.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80Failure279.29test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80Failure343.17test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfacesError134.20test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfacesError182.11test_internal_lb.py
test_01_deploy_kubernetes_clusterFailure0.00test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_clusterFailure0.00test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_clusterFailure0.01test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_clusterFailure0.00test_kubernetes_clusters.py
test_05_delete_kubernetes_clusterFailure0.00test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_clusterFailure0.00test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_clusterFailure0.00test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_clusterFailure0.00test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_clusterFailure0.00test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_versionError0.01test_kubernetes_supported_versions.py
test_router_dhcphostsFailure157.13test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPHosts>:teardownError167.41test_router_dhcphosts.py
test_router_dhcp_optsError609.23test_router_dhcphosts.py
test_router_dns_guestipqueryFailure454.74test_router_dns.py
test_router_dns_guestipqueryFailure454.71test_router_dnsservice.py
test_02_routervm_iptables_policiesError661.50test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policiesError723.29test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_trueFailure210.57test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_falseFailure210.61test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_trueFailure250.08test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_falseFailure251.86test_routers_network_ops.py
test_03_RVR_Network_check_router_stateError696.14test_routers_network_ops.py
test_01_router_internal_basicError602.80test_routers.py
test_02_router_internal_advError602.80test_routers.py
test_04_restart_network_wo_cleanupError604.84test_routers.py
test_01_service_offering_cpu_limit_useError100.51test_service_offerings.py
test_04_change_offering_smallFailure708.08test_service_offerings.py
test_01_snapshot_root_diskError606.03test_snapshots.py
test_03_ssvm_internalsError602.81test_ssvm.py
test_04_cpvm_internalsError602.92test_ssvm.py
test_05_stop_ssvmError680.62test_ssvm.py
test_06_stop_cpvmError653.67test_ssvm.py
test_07_reboot_ssvmError718.17test_ssvm.py
test_08_reboot_cpvmError627.95test_ssvm.py
test_09_reboot_ssvm_forcedError739.74test_ssvm.py
test_10_reboot_cpvm_forcedError651.90test_ssvm.py
test_11_destroy_ssvmError673.81test_ssvm.py
test_12_destroy_cpvmError669.40test_ssvm.py
ContextSuite context=TestISOUsage>:setupError0.00test_usage.py
test_10_attachAndDetach_isoFailure607.70test_vm_life_cycle.py
test_01_create_vm_snapshotsFailure604.48test_vm_snapshots.py
test_02_revert_vm_snapshotsFailure601.43test_vm_snapshots.py
test_03_delete_vm_snapshotsFailure0.02test_vm_snapshots.py
test_01_create_volumeFailure607.74test_volumes.py
test_02_attach_volumeFailure606.62test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLError833.98test_vpc_redundant.py
test_02_redundant_VPC_default_routesError831.92test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routersError749.19test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsError716.04test_vpc_redundant.py
test_05_rvpc_multi_tiersError809.34test_vpc_redundant.py
test_05_rvpc_multi_tiersError836.25test_vpc_redundant.py
test_01_VPC_nics_after_destroyFailure722.20test_vpc_router_nics.py
test_02_VPC_default_routesFailure724.40test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpnFailure376.62test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_optionsError251.18test_vpc_vpn.py
test_01_vpc_site2site_vpnError282.78test_vpc_vpn.py
test_hostha_enable_ha_when_host_disconectedError605.03test_hostha_kvm.py
test_hostha_kvm_host_degradedFailure669.38test_hostha_kvm.py
test_hostha_kvm_host_fencingFailure644.98test_hostha_kvm.py
test_hostha_kvm_host_recoveringFailure643.97test_hostha_kvm.py

@blueorangutan

blueorangutan commented Mar 22, 2021

Copy link
Copy Markdown

[S] Trillian test result (tid-189)
Environment: kvm-ubuntu18 (x2), Advanced Networking with Mgmt server u18
Total time taken: 112373 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4567-t189-kvm-ubuntu18.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 60 look OK, 26 have error(s)
Only failed tests results shown below:

TestResultTime (s)Test File
test_01_create_lb_rule_src_natFailure309.68test_loadbalance.py
test_02_create_lb_rule_non_natFailure35.76test_loadbalance.py
test_assign_and_removal_lbFailure35.65test_loadbalance.py
test_01_verify_libvirtError603.97test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restartError611.00test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_diskError606.14test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspciError602.06test_deploy_virtio_scsi_vm.py
test_05_change_vm_ostype_restartError614.39test_deploy_virtio_scsi_vm.py
test_06_verify_guest_lspci_againError602.11test_deploy_virtio_scsi_vm.py
ContextSuite context=TestAddConfigtoDeployVM>:setupError0.00test_deploy_vm_extra_config_data.py
test_01_port_fwd_on_src_natFailure605.54test_network.py
test_02_port_fwd_on_non_src_natFailure608.15test_network.py
ContextSuite context=TestPrivateVlansL2Networks>:setupError1231.58test_network.py
test_reboot_routerFailure365.99test_network.py
test_network_rules_acquired_public_ip_1_static_nat_ruleError610.03test_network.py
test_network_rules_acquired_public_ip_2_nat_ruleError610.63test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_RuleError615.10test_network.py
test_01_deployVMInSharedNetworkError675.26test_network.py
test_02_verifyRouterIpAfterNetworkRestartError634.53test_network.py
test_03_destroySharedNetworkFailure1.09test_network.py
ContextSuite context=TestSharedNetwork>:teardownError2.21test_network.py
test_isolate_network_password_serverFailure157.20test_password_server.py
test_02_vpc_privategw_static_routesFailure765.29test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanupFailure763.28test_privategw_acl.py
test_04_rvpc_privategw_static_routesFailure854.37test_privategw_acl.py
test_01_disableHumanReadableLogsError604.85test_human_readable_logs.py
test_02_enableHumanReadableLogsError604.81test_human_readable_logs.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80Failure274.49test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80Failure324.70test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfacesError145.50test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfacesError185.34test_internal_lb.py
test_01_deploy_kubernetes_clusterFailure0.00test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_clusterFailure0.00test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_clusterFailure0.01test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_clusterFailure0.00test_kubernetes_clusters.py
test_05_delete_kubernetes_clusterFailure0.00test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_clusterFailure0.00test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_clusterFailure0.00test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_clusterFailure0.00test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_clusterFailure0.00test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_versionError0.01test_kubernetes_supported_versions.py
test_router_dhcphostsFailure157.40test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPHosts>:teardownError168.79test_router_dhcphosts.py
test_router_dhcp_optsError610.47test_router_dhcphosts.py
test_router_dns_guestipqueryFailure455.08test_router_dns.py
test_router_dns_guestipqueryFailure455.45test_router_dnsservice.py
test_02_routervm_iptables_policiesError663.90test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policiesError727.92test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_trueFailure212.10test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_falseFailure212.47test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_trueFailure249.00test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_falseFailure253.75test_routers_network_ops.py
test_03_RVR_Network_check_router_stateError696.97test_routers_network_ops.py
test_01_router_internal_basicError603.62test_routers.py
test_02_router_internal_advError603.61test_routers.py
test_04_restart_network_wo_cleanupError606.09test_routers.py
test_01_service_offering_cpu_limit_useError100.79test_service_offerings.py
test_04_change_offering_smallFailure716.39test_service_offerings.py
test_01_snapshot_root_diskError607.93test_snapshots.py
test_03_ssvm_internalsError604.39test_ssvm.py
test_04_cpvm_internalsError604.21test_ssvm.py
test_05_stop_ssvmError693.59test_ssvm.py
test_06_stop_cpvmError665.50test_ssvm.py
test_07_reboot_ssvmError722.43test_ssvm.py
test_08_reboot_cpvmError629.89test_ssvm.py
test_09_reboot_ssvm_forcedError760.96test_ssvm.py
test_10_reboot_cpvm_forcedError650.94test_ssvm.py
test_11_destroy_ssvmError659.09test_ssvm.py
test_12_destroy_cpvmError659.86test_ssvm.py
test_01_migrate_VM_and_root_volumeError84.52test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disksError68.36test_vm_life_cycle.py
test_01_secure_vm_migrationError731.15test_vm_life_cycle.py
test_02_unsecure_vm_migrationError643.56test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migrationError639.77test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migrationError639.04test_vm_life_cycle.py
test_08_migrate_vmError46.14test_vm_life_cycle.py
test_10_attachAndDetach_isoFailure607.66test_vm_life_cycle.py
test_01_create_vm_snapshotsFailure604.66test_vm_snapshots.py
test_02_revert_vm_snapshotsFailure601.61test_vm_snapshots.py
test_03_delete_vm_snapshotsFailure0.02test_vm_snapshots.py
test_01_create_volumeFailure610.23test_volumes.py
test_02_attach_volumeFailure605.79test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACLError837.34test_vpc_redundant.py
test_02_redundant_VPC_default_routesError839.97test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routersError764.30test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nicsError713.97test_vpc_redundant.py
test_05_rvpc_multi_tiersError0.50test_vpc_redundant.py
test_01_VPC_nics_after_destroyFailure732.24test_vpc_router_nics.py
test_02_VPC_default_routesFailure728.21test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpnFailure369.94test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_optionsError256.98test_vpc_vpn.py
test_01_vpc_site2site_vpnError297.65test_vpc_vpn.py
test_hostha_enable_ha_when_host_disconectedError605.87test_hostha_kvm.py
test_hostha_kvm_host_degradedError674.35test_hostha_kvm.py
test_hostha_kvm_host_fencingError646.22test_hostha_kvm.py
test_hostha_kvm_host_recoveringError646.88test_hostha_kvm.py

@DaanHoogland

DaanHoogland commented Mar 23, 2021

Copy link
Copy Markdown
Contributor

Tests indicate that all LibvirtException have been handled. LGTM.

@GabrielBrascher I merged based on this comment of yours, but then we had some internal discussion on whether it was tested enough. I don't think any of the failures above are due to this change, but still, can you comment a bit more on testing please? cc @GutoVeronezi

GabrielBrascher pushed a commit to CLDIN/cloudstack that referenced this pull request Jul 20, 2022
@GutoVeronezi@GabrielBrascher
Backport "Qemu 2.10 requires-Uflag to read volume metadata (apach…
7852a0c
…e#4567)"
Co-authored-by: Daniel Augusto Veronezi Salvador <daniel@scclouds.com.br>
* Conflicts:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ScaleIOStorageAdaptor.java
* Fixed conflict by removing the class above, which is introduced only on future releases.
Signed-off-by: gabriel <gabriel@apache.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GabrielBrascherGabrielBrascherGabrielBrascher approved these changes
@weizhouapacheweizhouapacheweizhouapache approved these changes
+1 more reviewer
@RodrigoDLopezRodrigoDLopezRodrigoDLopez approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

complexity:trivial10 minnutes to a few days at mostSeverity:Majortype:enhancement

Projects

None yet

Milestone

4.16.0.0

Development

Successfully merging this pull request may close these issues.

qemu 2.10+: consider adding --force-share flag

10 participants

@GutoVeronezi@yadvr@rafaelweingartner@blueorangutan@weizhouapache@DaanHoogland@wido@shwstppr@GabrielBrascher@RodrigoDLopez