Skip to content

ui: fix update vm details wrt backend changes - #4670

Merged
yadvr merged 1 commit into
apache:4.15from
shapeblue:fix-ui-vm-readonly-settings
Mar 11, 2021
Merged

ui: fix update vm details wrt backend changes#4670
yadvr merged 1 commit into
apache:4.15from
shapeblue:fix-ui-vm-readonly-settings

Conversation

@shwstppr

@shwstpprshwstppr commented Feb 9, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

PR #4629 made changes in updateVirtualMachine behaviour wrt readonly details.
This change updates UI wrt new behaviour.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  • Deployed a VM as user.
  • As admin added a new detail to the VM. Made the detail read-only by putting it in global config - user.vm.readonly.ui.details
  • As user, tried add, edit and delete details operation on the VM.

Screenshot from 2021-03-01 16-35-10
readonly

@shwstppr
ui: fix update vm details wrt backend changes
e2d4421
PR apache#4629 made changes in updateVirtualMachine behaviour wrt readonly details.
This change updates UI wrt new behaviour.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstpprshwstppr added this to the 4.15.1.0 milestone Feb 9, 2021
@shwstppr

shwstppr commented Feb 9, 2021

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan ui

@blueorangutan

blueorangutan commented Feb 9, 2021

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Feb 9, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4670 (JID-3834)

@Pearl1594

Pearl1594 commented Feb 11, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

blueorangutan commented Feb 11, 2021

Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Feb 11, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4670 (JID-3835)

@blueorangutan

blueorangutan commented Feb 11, 2021

Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@Pearl1594

Pearl1594 commented Feb 11, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

blueorangutan commented Feb 11, 2021

Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@Pearl1594

Pearl1594 commented Feb 11, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

blueorangutan commented Feb 11, 2021

Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Feb 11, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4670 (JID-12)

@yadvr
yadvr self-requested a review February 26, 2021 07:03
@shwstppr
shwstppr marked this pull request as ready for review March 1, 2021 06:40
@weizhouapache

weizhouapache commented Mar 1, 2021

Copy link
Copy Markdown
Member

@shwstppr can you upload some screenshots for this ui change ?

@shwstppr

shwstppr commented Mar 1, 2021

Copy link
Copy Markdown
ContributorAuthor

@weizhouapache added screenshot

@davidjumani

davidjumani commented Mar 6, 2021

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

blueorangutan commented Mar 6, 2021

Copy link
Copy Markdown

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Mar 6, 2021

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4670 (JID-3850)

yadvr
yadvr approved these changes Mar 6, 2021
View reviewed changes

@yadvryadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs testing

@yadvr

yadvr commented Mar 11, 2021

Copy link
Copy Markdown
Member

Tests LGTM - from gif. Fixes existing UI minor feature from legacy UI.

@yadvr
yadvr merged commit a691e87 into apache:4.15Mar 11, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvryadvryadvr approved these changes
@davidjumanidavidjumaniAwaiting requested review from davidjumani
@Pearl1594Pearl1594Awaiting requested review from Pearl1594
@weizhouapacheweizhouapacheAwaiting requested review from weizhouapache

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.15.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@shwstppr@blueorangutan@Pearl1594@weizhouapache@davidjumani@yadvr