Skip to content

CLOUDSTACK-8556: Unable to delete attached volume in cleanup - #481

Closed
pritisarap12 wants to merge 8 commits into
apache:masterfrom
pritisarap12:deleteVolume
Closed

CLOUDSTACK-8556: Unable to delete attached volume in cleanup#481
pritisarap12 wants to merge 8 commits into
apache:masterfrom
pritisarap12:deleteVolume

Conversation

@pritisarap12

@pritisarap12pritisarap12 commented Jun 18, 2015

Copy link
Copy Markdown

No description provided.

@asfbot

asfbot commented Jun 18, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #487 FAILURE
Looks like there's a problem with this pull request

gauravaradhye
gauravaradhye reviewed Jun 18, 2015
View reviewed changes
Comment threadtest/integration/testpaths/testpath_snapshot_limits.py Outdated

@gauravaradhyegauravaradhyeJun 18, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why reboot and then delete? Also add suitable description and test run log results to the description.

@pritisarap12
pritisarap12force-pushed the deleteVolume branch 2 times, most recently from e291f8c to ae17385CompareJune 19, 2015 11:40
@pritisarap12

pritisarap12 commented Jun 19, 2015

Copy link
Copy Markdown
Author

Removed reboot as it is not needed.
Below is the test result after removing reboot function:

Storage and Snapshot Limit ... === TestName: test_01_storage_snapshots_limits | Status : SUCCESS ===
ok

Ran 1 test in 300.585s

OK

@gauravaradhye

gauravaradhye commented Jun 19, 2015

Copy link
Copy Markdown

Can you please explain why the test case was failing before? Why the cleanup was failing for volume?

@asfbot

asfbot commented Jun 19, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #502 FAILURE
Looks like there's a problem with this pull request

@asfbot

asfbot commented Jun 19, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #501 SUCCESS
This pull request looks good

@asfbot

asfbot commented Jun 19, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #504 FAILURE
Looks like there's a problem with this pull request

@asfbot

asfbot commented Jun 19, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #503 SUCCESS
This pull request looks good

@pritisarap12

pritisarap12 commented Jun 25, 2015

Copy link
Copy Markdown
Author

Delete volume was failing in cleanup before because volume was not in detached state as snapshot creation failed and detach volume command did not get executed so volume remains in attached state.
Now the detach volume is executed in tearDown class itself so clean up does not fail for volume.

@asfbot

asfbot commented Jun 25, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #647 SUCCESS
This pull request looks good

gauravaradhye
gauravaradhye reviewed Jun 25, 2015
View reviewed changes
Comment threadtest/integration/testpaths/testpath_snapshot_limits.py Outdated

@gauravaradhyegauravaradhyeJun 25, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup has to be declared before skipping the test case

@pritisarap12pritisarap12Jun 26, 2015

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated testpath as per the review comment.

@asfbot

asfbot commented Jun 26, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #662 SUCCESS
This pull request looks good

@wido

wido commented Jul 14, 2015

Copy link
Copy Markdown
Contributor

The description of the pull request isn't really specific. Looking at the files changed it is only a test case which changed, right? No CS code itself.

@asfbot

asfbot commented Jul 14, 2015

Copy link
Copy Markdown

Sanjeev N on dev@cloudstack.apache.org replies:
You are right Wido. It is only a test case change to handle volume cleanup.

@wido

wido commented Jul 14, 2015

Copy link
Copy Markdown
Contributor

In that case LGTM

Next time try to be more descriptive, since the Jira issue didn't show it either. I really didn't know what you meant.

@yadvr

yadvr commented Jul 16, 2015

Copy link
Copy Markdown
Member

LGTM, squashing and merging; please squash your changes in future as you iterate on your PR

maneesha-p pushed a commit to maneesha-p/cloudstack that referenced this pull request Jul 31, 2015
pritisarap12Maneesha P
CLOUDSTACK-8556: Unable to delete attached volume in cleanup
1c4775d
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
This closesapache#481
yadvr pushed a commit that referenced this pull request Jan 20, 2021
Hoang Nguyen@yadvr
src: fix doclinks and translation across UI (#481)
4f97fea
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pritisarap12@asfbot@gauravaradhye@wido@yadvr