server: detach data disks before destroying vms

[weizhouapache]

Description

This PR fixes#4902

The testing results with this change:

• When destroy VM without expunge and when no data disk is selected for deletion
  destroy vm: VM is stopped, data disk is detached from vm (in Ready state)
  recover vm: vm is ready only with root disk.

• When destroy VM without expunge and when one or more data disks are selected for deletion
  destroy vm: VM is stopped, Data disks marked for deletion are detached and in Destroy state . the remaining disks are detached from VM
  recover vm: vm is ready only with root disk.
  recover data disk in Destroy: volume is ready, and not attached to vm.

• When destroy VM with expunge and when no data disk is selected for deletion
  VM is destroyed and expunged completely.
  data disks are detached from vm.

• When destroy VM with expunge and few data disks are selected for deletion
  VM is destroyed and expunged completely.
  Data disks marked for deletion are deleted. the remaining disks are detached from VM

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 978

[nvazquez]

LGTM - needs testing

[nvazquez]

@weizhouapache can you target this PR to the main branch?

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 993

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1761)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33898 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5356-t1761-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[davidjumani]

Tested with multiple DataDisks, all 4 scenarios work as expected

[weizhouapache]

Tested with multiple DataDisks, all 4 scenarios work as expected

great, thanks for testing @davidjumani

@rhtyd @PaulAngus@DaanHoogland@nvazquez
are the expected results correct to you?

[DaanHoogland]

clgtm, tests done. I've given the failed travis tests another spin.

[yadvr]

@weizhouapache does this affect 4.15 too? If so, pl raise PR against 4.15 branch if it's a bug fix. Thanks.

[weizhouapache]

@weizhouapache does this affect 4.15 too? If so, pl raise PR against 4.15 branch if it's a bug fix. Thanks.

@rhtyd @nvazquez changed base branch back to 4.15

[nvazquez]

@blueorangutan package

[blueorangutan]

@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 1043

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1814)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35434 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5356-t1814-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Smoke tests completed. 87 look OK, 0 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File