ui: fix create account/user with saml by shwstppr · Pull Request #5481 · apache/cloudstack

shwstppr · 2021-09-21T06:31:23Z

Description

Fixes#5477
Fixes#5478

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

Before change:

After change:

How Has This Been Tested?

Fixesapache#5478 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr · 2021-09-21T06:40:59Z

@blueorangutan ui

yadvr · 2021-09-21T06:41:30Z

@blueorangutan ui

blueorangutan · 2021-09-21T06:43:04Z

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-09-21T06:47:27Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-673)

yadvr · 2021-09-21T07:09:10Z

@shwstppr couple of issues, not sure if they are due to the qa.cloudstack.cloud backend of 4.15.1: (the qa.cloudstack.cloud is SAMl enabled and can be used for testing)

Check if the normal user/role type should be shown this form, it fails:
On creating user as normal user type, that fails too (in its own account):
As domain admin, the IDP list was somehow not shown in the create user form:
As root admin, I created a new user 'rick' and while creating the user ticked authorise saml sso and selected the IDP however the newly-created user is not SAML2 type:
For an already authorised saml user, when clicking edit saml authorisation button the IDP is pre-selected as 0 (something wrong in option/value key?)

Note: this form also seems to pass invalid entityid in the API, so the user isn't really SAML enabled.

@shwstppr please also test/fix any issues with the createAccount form (which also has the saml authorisation option).

Fixesapache#5477 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2021-09-21T07:49:24Z

@rhtyd Verified mentioned issues with PR build:

Normal User role cannot create new users in their own account. Old UI doesn't provide the option and option wasn't there in this PR build as well.
Same as 1
Fixed this case
Fixed with this PR
Didn't see this behaviour with this PR build.

Addressed #5477 and #5478
@blueorangutan ui

blueorangutan · 2021-09-21T07:50:03Z

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2021-09-21T07:54:41Z

@blueorangutan ui

blueorangutan · 2021-09-21T07:55:02Z

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-09-21T07:56:53Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-674)

blueorangutan · 2021-09-21T08:00:35Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-675)

utchoang

LGTM!

yadvr · 2021-09-21T08:50:35Z

@blueorangutan ui

yadvr

LGTM - I'll test and confirm shortly

yadvr · 2021-09-21T08:51:24Z

@blueorangutan ui

blueorangutan · 2021-09-21T08:52:03Z

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-09-21T08:56:28Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-676)

yadvr · 2021-09-21T09:46:19Z

@shwstppr outstanding/new issues:

Minor - does not refresh user detail page on edit/saving the authorise saml sso form
As domain admin, the entity ID is not updating - still 0? And on saving the form still passes 0 as entityid
Minor - Create user form doesn't work for domain user the #/user path (as domainid is not passed)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr · 2021-09-21T11:35:26Z

@shwstppr is this ready for final test/merge, or you addressing minor issues too?
@blueorangutan ui

blueorangutan · 2021-09-21T11:36:02Z

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-09-21T11:41:49Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5481 (SL-JID-678)

shwstppr · 2021-09-21T11:46:00Z

@rhtyd let's move ahead with one for 2

As domain admin, the entity ID is not updating - still 0? And on saving the form still passes 0 as entityid

I'll fix 1 and 3 in another PR #5487

yadvr · 2021-09-21T12:02:43Z

LGTM tested!

ui: fix create user with saml
32243b1
Fixesapache#5478 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr added this to the 4.16.0.0 milestone Sep 21, 2021

yadvr added component:saml Severity:Critical Critical bug type:bug labels Sep 21, 2021

Pearl1594 mentioned this pull request Sep 21, 2021
ui: List Identity providers as domain admin #5482
Closed
10 tasks

fix listIdp issue for add account/user
1f0f09c
Fixesapache#5477 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr changed the title ~~ui: fix create user with saml~~ui: fix create account/user with samlSep 21, 2021

shwstppr added 2 commits September 21, 2021 13:21

Merge branch 'main' into fix-ui-create-user-saml
8f8d3ae

label fix
a493ba1
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr requested a review from Pearl1594 September 21, 2021 07:55

shwstppr requested review from Pearl1594, utchoang and yadvr and removed request for Pearl1594 September 21, 2021 07:55

utchoang approved these changes Sep 21, 2021
View reviewed changes

yadvr approved these changes Sep 21, 2021
View reviewed changes

fix idp selection
98c486f
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr merged commit 67be3da into apache:mainSep 21, 2021

weizhouapache mentioned this pull request Mar 23, 2022
SSO fails with error "Expired session, missing signature, or missing apiKey" #6127
Closed

Uh oh!

Conversation

shwstppr commented Sep 21, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

yadvr commented Sep 21, 2021

Uh oh!

yadvr commented Sep 21, 2021

Uh oh!

blueorangutan commented Sep 21, 2021

Uh oh!

blueorangutan commented Sep 21, 2021

Uh oh!

yadvr commented Sep 21, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shwstppr commented Sep 21, 2021

Uh oh!

blueorangutan commented Sep 21, 2021

Uh oh!

shwstppr commented Sep 21, 2021

Uh oh!

blueorangutan commented Sep 21, 2021

Uh oh!

blueorangutan commented Sep 21, 2021

Uh oh!

blueorangutan commented Sep 21, 2021

Uh oh!

utchoang left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Sep 21, 2021

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Sep 21, 2021

Uh oh!

blueorangutan commented Sep 21, 2021

Uh oh!

blueorangutan commented Sep 21, 2021

Uh oh!

yadvr commented Sep 21, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yadvr commented Sep 21, 2021

Uh oh!

blueorangutan commented Sep 21, 2021

Uh oh!

blueorangutan commented Sep 21, 2021

Uh oh!

shwstppr commented Sep 21, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yadvr commented Sep 21, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

shwstppr commented Sep 21, 2021•
edited
Loading

yadvr commented Sep 21, 2021•
edited
Loading

yadvr commented Sep 21, 2021•
edited
Loading

shwstppr commented Sep 21, 2021•
edited
Loading