Skip to content

CLOUDSTACK-8623: CPVM fails to start after MS is restarted during its… - #571

Closed
koushik-das wants to merge 2 commits into
apache:masterfrom
koushik-das:CS-8623
Closed

CLOUDSTACK-8623: CPVM fails to start after MS is restarted during its…#571
koushik-das wants to merge 2 commits into
apache:masterfrom
koushik-das:CS-8623

Conversation

@koushik-das

Copy link
Copy Markdown
Contributor

… initial start-up process

If SSVM cannot be started then the existing entry is removed and a new SSVM gets created. Made similar changes for CPVM as well.
Also cleaned up some log messages in SSVM and CPVM manager code.

… initial start-up process
If SSVM cannot be started then the existing entry is removed and a new SSVM gets created. Made similar changes for CPVM as well.
Also cleaned up some log messages in SSVM and CPVM manager code.
@asfbot

Copy link
Copy Markdown

cloudstack-pull-rats #25 SUCCESS
This pull request looks good

@asfbot

Copy link
Copy Markdown

cloudstack-pull-requests #720 SUCCESS
This pull request looks good

@kishankavala

Copy link
Copy Markdown
Contributor

LGTM.

@karuturi

Copy link
Copy Markdown
Member

Can you add some unit tests or marvin tests?

@yadvr

Copy link
Copy Markdown
Member

LGTM.

@DaanHoogland

Copy link
Copy Markdown
Contributor

I would like to see tests with such a change as well

@koushik-das

Copy link
Copy Markdown
ContributorAuthor

@karuturi@DaanHoogland Added unit tests for CPVM allocation.

@asfbot

Copy link
Copy Markdown

cloudstack-pull-rats #37 ABORTED

@DaanHoogland

Copy link
Copy Markdown
Contributor

test logic makes sense; LGTM

waiting for travis

@asfbot

Copy link
Copy Markdown

cloudstack-pull-requests #733 UNSTABLE
Looks like there's a problem with this pull request

@koushik-das

Copy link
Copy Markdown
ContributorAuthor

Although RAT build status is showing ABORTED, the report is clean. Also the build failed due to some random test failure. Since travis is green, I am going ahead with the merge.

yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request Jul 14, 2015
… initial start-up process
Added unit tests
This closesapache#571
@koushik-das

Copy link
Copy Markdown
ContributorAuthor

Manually closing PR. I did a rebase to do away with unnecessary merge commit.

@koushik-das
koushik-das deleted the CS-8623 branch July 14, 2015 06:50
maneesha-p pushed a commit to maneesha-p/cloudstack that referenced this pull request Jul 31, 2015
… initial start-up process
Added unit tests
This closesapache#571
@jburwelljburwell mentioned this pull request Oct 4, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@koushik-das@asfbot@kishankavala@karuturi@yadvr@DaanHoogland