Allow scaling VM to a service offering having different storage tags by Pearl1594 · Pull Request #5996 · apache/cloudstack

Pearl1594 · 2022-02-15T06:59:50Z

Description

This PR addresses #5512

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Screenshots (if appropriate):

How Has This Been Tested?

Test 1

With the global setting - match.storage.pool.tags.with.disk.offering set to true, scaling a VM to an offering with a different storage tag isn't possible.
Fails with the following exception (tried via cmk):

(localcloud) 🐱 > scale virtualmachine id=ce2897f9-90c0-46de-b3b5-0478175c8d0f serviceofferingid=d5b68cac-415d-4343-bef2-36b4b9787abf {
"accountid": "138951c3-8e39-11ec-a631-1e00fb00013b",
"cmd": "org.apache.cloudstack.api.command.admin.vm.ScaleVMCmdByAdmin",
"completed": "2022-02-15T09:20:06+0000",
"created": "2022-02-15T09:20:06+0000",
"jobid": "faa4faf1-83c5-4927-b135-89431c110782",
"jobprocstatus": 0,
"jobresult": {
"errorcode": 431,
"errortext": "Unable to upgrade virtual machine; the current service offering should have tags as subset of the new service offering tags. Current service offering tags: [pool2]; new service offering tags: [pool1]"
},
"jobresultcode": 530,
"jobresulttype": "object",
"jobstatus": 2,
"userid": "138a5a9a-8e39-11ec-a631-1e00fb00013b"
}
🙈 Error: async API failed for job faa4faf1-83c5-4927-b135-89431c110782

Also, the UI doesn't list the compute offering:

Test 2

With the global setting - match.storage.pool.tags.with.disk.offering set to false, scaling a VM to an offering with a different storage tag is possible with the automigrate option set to true. The UI also displays the other compute offerings - those with different storage tags, during scale operation:

Successfully scaled the VM & migrated the volume to the appropriate pool

Pearl1594 · 2022-02-15T09:24:35Z

@blueorangutan package

blueorangutan · 2022-02-15T09:25:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-15T10:03:53Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2611

Pearl1594 · 2022-02-15T10:04:37Z

@blueorangutan test

blueorangutan · 2022-02-15T10:05:03Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Pearl1594 · 2022-02-15T11:17:13Z

@blueorangutan test

blueorangutan · 2022-02-15T11:19:02Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-02-15T11:36:40Z

Trillian Build Failed (tid-3343)

Pearl1594 · 2022-02-15T12:28:02Z

@blueorangutan package

blueorangutan · 2022-02-15T12:29:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-15T13:27:30Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2615

Pearl1594 · 2022-02-15T14:42:18Z

@blueorangutan package

blueorangutan · 2022-02-15T14:44:05Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-15T14:56:25Z

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✖️ suse15. SL-JID 2619

Pearl1594 · 2022-02-15T15:35:02Z

@blueorangutan package

blueorangutan · 2022-02-15T15:36:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-15T16:32:00Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2622

Pearl1594 · 2022-02-15T16:32:56Z

@blueorangutan test

blueorangutan · 2022-02-15T16:34:04Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-02-16T02:06:31Z

Trillian test result (tid-3349)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32791 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5996-t3349-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_nic	`Error`	134.06	test_nic.py

harikrishna-patnala

Code changes LGTM

weizhouapache · 2022-02-17T17:46:08Z

@Pearl1594
did you test with 4.16 or 4.17 ?

I faced an issue when I tested this PR in 4.17 by following steps
(1) create a service offering with storage tag
(2) update storage tag of pool to same tag
(3) scale vm to new service offering, works
(4) change global setting to false, when scale vm to default "Small Instance". got an exception: "The new disk offering requires that a size be specified."

I think it is caused by @harikrishna-patnala 's PR #5008

Pearl1594 · 2022-02-18T06:10:57Z

I had tested it with main - but using non customized offering.

harikrishna-patnala · 2022-02-18T06:51:10Z

Yes @weizhouapache, you are correct. And @Pearl1594 's last commit will fix that issue of "The new disk offering requires that a size be specified."

Pearl1594 · 2022-02-18T06:57:23Z

@blueorangutan package

blueorangutan · 2022-02-18T06:58:03Z

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2022-02-18T07:33:03Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2655

Pearl1594 · 2022-02-18T07:34:30Z

@blueorangutan test

blueorangutan · 2022-02-18T07:35:02Z

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

weizhouapache · 2022-02-18T08:12:01Z

Yes @weizhouapache, you are correct. And @Pearl1594 's last commit will fix that issue of "The new disk offering requires that a size be specified."

@harikrishna-patnala thanks. that's great.
@Pearl1594 thanks for the fix

weizhouapache

manually tested ok

sureshanaparti

code LGTM

blueorangutan · 2022-02-18T16:35:50Z

Trillian test result (tid-3386)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31130 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5996-t3386-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

Pearl1594 added 2 commits February 15, 2022 11:05

Allow scaling VM to a service offering with different storage tags
888ef5e

list svc offerings with other stg tags when global setting is disabled
b9aa906

Pearl1594 added this to the 4.17.0.0 milestone Feb 15, 2022

Pearl1594 added the component:api label Feb 15, 2022

Pearl1594 changed the title ~~Allow change svc offering with diff stg tags~~Allow scaling VM to a service offering having different storage tagsFeb 15, 2022

sureshanaparti requested review from GabrielBrascher, GutoVeronezi, harikrishna-patnala and shwstppr February 15, 2022 08:00

sureshanaparti linked an issue Feb 15, 2022 that may be closed by this pull request
Improvement request: scale vm with new service offering, despite of storage tags #5512
Closed

Pearl1594 requested a review from weizhouapache February 15, 2022 09:18

Pearl1594 marked this pull request as ready for review February 15, 2022 09:33

apache deleted a comment from blueorangutan Feb 15, 2022

Pearl1594 force-pushed the allow-change-svc-offering-with-diff-stg-tags branch from b9aa906 to 1513c9aCompare February 15, 2022 15:30

harikrishna-patnala approved these changes Feb 16, 2022
View reviewed changes

remove check for size when disk is compute only
ba8b6bd

Pearl1594 force-pushed the allow-change-svc-offering-with-diff-stg-tags branch from 1513c9a to ba8b6bdCompare February 18, 2022 06:42

weizhouapache approved these changes Feb 18, 2022
View reviewed changes

sureshanaparti approved these changes Feb 18, 2022
View reviewed changes

DaanHoogland merged commit d311f88 into apache:mainFeb 18, 2022

yadvr added the type:enhancement label Mar 24, 2022

Uh oh!

Conversation

Pearl1594 commented Feb 15, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Screenshots (if appropriate):

How Has This Been Tested?

Test 1

Test 2

Uh oh!

Pearl1594 commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

Pearl1594 commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

Pearl1594 commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

Pearl1594 commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

Pearl1594 commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

Pearl1594 commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

Pearl1594 commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 15, 2022

Uh oh!

blueorangutan commented Feb 16, 2022

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Feb 17, 2022

Uh oh!

Pearl1594 commented Feb 18, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

harikrishna-patnala commented Feb 18, 2022

Uh oh!

Pearl1594 commented Feb 18, 2022

Uh oh!

blueorangutan commented Feb 18, 2022

Uh oh!

blueorangutan commented Feb 18, 2022

Uh oh!

Pearl1594 commented Feb 18, 2022

Uh oh!

blueorangutan commented Feb 18, 2022

Uh oh!

weizhouapache commented Feb 18, 2022

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Pearl1594 commented Feb 15, 2022•
edited
Loading

Pearl1594 commented Feb 18, 2022•
edited
Loading