kvm: support multiple local storage pools by weizhouapache · Pull Request #6147 · apache/cloudstack

weizhouapache · 2022-03-21T12:56:11Z

Description

This PR fixes#5987

The steps to support multiple storage pools
(1) if zone does not support local storage, go to zone details and edit zone, check "Enable local storage for User VMs"
(2) create local directories on kvm hosts
(3) edit /etc/cloudstack/agent/agent.properties, add extra directories and UUIDs (can be generated by uuidgen)
local.storage.uuid=a43943c1-1759-4073-9db1-bc0ea19203aa,f5b1220b-4446-42dc-a872-cffd281f9f8c
local.storage.path=/var/lib/libvirt/images,/var/lib/libvirt/images2
(4) restart cloudstack-agent

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

weizhouapache · 2022-03-21T12:57:35Z

@blueorangutan package

blueorangutan · 2022-03-21T12:59:03Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

nvazquez · 2022-03-21T13:18:05Z

+ String[] localStorageRelativePaths = _localStoragePath.split(CONFIG_VALUES_SEPARATOR);
+ String[] localStorageUUIDs = _localStorageUUID.split(CONFIG_VALUES_SEPARATOR, -1);
+ if (localStorageRelativePaths.length != localStorageUUIDs.length) {
+ throw new ConfigurationException("The path and UUID of local storage pools have different length");


I think that instead of killing the agent we can log the error and continue with at least the default local storage and UUID

blueorangutan · 2022-03-21T13:34:49Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2945

weizhouapache · 2022-03-21T14:13:45Z

@blueorangutan package

blueorangutan · 2022-03-21T14:14:03Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-03-21T15:02:28Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2948

nvazquez · 2022-03-21T15:05:33Z

@blueorangutan test

blueorangutan · 2022-03-21T15:06:03Z

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-03-22T00:16:46Z

Trillian test result (tid-3688)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31666 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6147-t3688-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

GutoVeronezi

Nice work, @weizhouapache.

CLGTM, I did not test it though.

I suggested only a minor (non-blocking) change in the var names.

weizhouapache · 2022-03-23T08:46:24Z

@blueorangutan package

blueorangutan · 2022-03-23T08:47:03Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-03-23T09:56:33Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2963

weizhouapache · 2022-03-23T10:02:55Z

@blueorangutan test

blueorangutan · 2022-03-23T10:04:03Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-03-23T19:21:20Z

Trillian test result (tid-3706)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32120 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6147-t3706-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

yadvr

Code LGTM - but needs testing. Pl see if unit tests may be added.

weizhouapache · 2022-03-24T10:35:05Z

Code LGTM - but needs testing. Pl see if unit tests may be added.

@rohityadavcloud
good point. I have just added unit tests as per your comment.

nvazquez

LGTM - manually tested on existing KVM environment:

Enabled zone local storage use
Edit agent.properties and create local directories on a host, restart agent
Local storage pools added
Tested migration of volumes across the pools

kvm: support multiple local storage pools
c4cdd72

weizhouapache requested review from andrijapanicsb and nvazquez March 21, 2022 12:56

nvazquez added type:enhancement component:kvm labels Mar 21, 2022

nvazquez added this to the 4.17.0.0 milestone Mar 21, 2022

nvazquez reviewed Mar 21, 2022
View reviewed changes

weizhouapache added 2 commits March 21, 2022 15:08

Updateapache#6147: add method configureLocalStorage
8178d33

Updateapache#6147: add method validateLocalStorageUUID
e58b673

weizhouapache marked this pull request as ready for review March 22, 2022 11:04

GutoVeronezi approved these changes Mar 22, 2022
View reviewed changes

Comment thread...ypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java Outdated

Updateapache#6147: remove underscore
c9b6286

yadvr approved these changes Mar 24, 2022
View reviewed changes

Updateapache#6147: add unit tests
a4e6c27

nvazquez approved these changes Mar 25, 2022
View reviewed changes

nvazquez merged commit 5845de4 into apache:mainMar 25, 2022

nvazquez added component:local-storage type:new-feature labels Mar 25, 2022

weizhouapache mentioned this pull request Sep 5, 2022
multi local storage handling for kvm #6699
Merged
12 tasks

weizhouapache deleted the 4.17-multiple-local-storages branch December 9, 2022 08:13

weizhouapache mentioned this pull request Jul 24, 2023
storage: add multiple local storages on kvm apache/cloudstack-documentation#333
Merged

Uh oh!

Conversation

weizhouapache commented Mar 21, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache commented Mar 21, 2022

Uh oh!

blueorangutan commented Mar 21, 2022

Uh oh!

nvazquezMar 21, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

blueorangutan commented Mar 21, 2022

Uh oh!

weizhouapache commented Mar 21, 2022

Uh oh!

blueorangutan commented Mar 21, 2022

Uh oh!

blueorangutan commented Mar 21, 2022

Uh oh!

nvazquez commented Mar 21, 2022

Uh oh!

blueorangutan commented Mar 21, 2022

Uh oh!

blueorangutan commented Mar 22, 2022

Uh oh!

GutoVeronezi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

weizhouapache commented Mar 23, 2022

Uh oh!

blueorangutan commented Mar 23, 2022

Uh oh!

blueorangutan commented Mar 23, 2022

Uh oh!

weizhouapache commented Mar 23, 2022

Uh oh!

blueorangutan commented Mar 23, 2022

Uh oh!

blueorangutan commented Mar 23, 2022

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Mar 24, 2022

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants