Skip to content

[VMWare] error when detaching volume - #6283

Merged
nvazquez merged 3 commits into
apache:mainfrom
scclouds:vmware-fix-detach-volume-exception
Apr 27, 2022
Merged

[VMWare] error when detaching volume#6283
nvazquez merged 3 commits into
apache:mainfrom
scclouds:vmware-fix-detach-volume-exception

Conversation

@SadiJr

@SadiJrSadiJr commented Apr 18, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Using the VMWare (version 6.5), when trying to detach a volume, vCenter detaches it successfully; however, ACS throws an exception. It already was reported in VMWare and ACS' communities, but it hasn't been fixed yet. For more information about this error, please check this links ([1], [2], [3]).

To know why ACS tries to check folder content, please check these links ([4], [5]). This error apparently only occurs with datastores that use the NFS protocol and n specific versions of VMWare. Users using VMFS or VMWare versions greater than 6.7 have not reported this error. If the operation performed is a volume detach, it was successful. If you want to know why this error occurs in VMWare, please contact VMWare's technical support.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

It was tested in a local lab:

  1. I created a new VM with two disks;
  2. I tried to detach the datadisk;
  3. Before, an exception was thrown, and, in the ACS database, the VM was still with two disks, however, in vCenter the volume was already detached;
  4. Now, detach volume process finish with success.

@acs-robot

acs-robot commented Apr 18, 2022

Copy link
Copy Markdown

Found Java/XML changes, kicking packaging job
@blueorangutan package

@blueorangutan

blueorangutan commented Apr 18, 2022

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Apr 18, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3204

@acs-robot

acs-robot commented Apr 18, 2022

Copy link
Copy Markdown

PR Coverage Report

CLASSINSTRUCTION MISSEDINSTRUCTION COVEREDBRANCH MISSEDBRANCH COVEREDLINE MISSEDLINE COVERED
VmwareStorageLayoutHelper1287011402000

@nvazqueznvazquez added this to the 4.17.0.0 milestone Apr 20, 2022
@nvazquez

nvazquez commented Apr 20, 2022

Copy link
Copy Markdown
Contributor

Hi @weizhouapache@Pearl1594 can you please review?

@weizhouapache

weizhouapache commented Apr 20, 2022

Copy link
Copy Markdown
Member

@SadiJr@nvazquez
there are 5 links in this PR which is difficult to maintain.
would it be better to point to a link which contains all the information ?

@nvazquez

nvazquez commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

@blueorangutan test centos7 vmware-65u2

@blueorangutan

blueorangutan commented Apr 21, 2022

Copy link
Copy Markdown

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@nvazquez

nvazquez commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

@weizhouapache I think the error message is very descriptive as it is but will be +1 to point to a single location with all the information - @SadiJr please advise

@nvazquez

nvazquez commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

@blueorangutan test centos7 vmware-65u2

@blueorangutan

blueorangutan commented Apr 22, 2022

Copy link
Copy Markdown

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Apr 22, 2022

Copy link
Copy Markdown

Trillian Build Failed (tid-3997)

@acs-robot

acs-robot commented Apr 22, 2022

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@SadiJr

SadiJr commented Apr 22, 2022

Copy link
Copy Markdown
ContributorAuthor

@weizhouapache@nvazquez thansk for the suggestion. I changed the description of the PR, adding all the links, and adding the link of this PR in the final message. What do you think?

@weizhouapache

weizhouapache commented Apr 22, 2022

Copy link
Copy Markdown
Member

@SadiJr thanks.
my concern is, is it good to ignore all the errors in detch volume on vmware ?
can we ignore the error only if some errors happen, for example by checking the error message e.getMessage().contains("xxxxxx") ?

cc @nvazquez

@acs-robot

acs-robot commented Apr 22, 2022

Copy link
Copy Markdown

PR Coverage Report

CLASSINSTRUCTION MISSEDINSTRUCTION COVEREDBRANCH MISSEDBRANCH COVEREDLINE MISSEDLINE COVERED
Network55404201070
Volume109020440
VirtualMachineGuru78040150
NetworkOrchestrationService010100010
ConnectedAgentAttache1490200400
VirtualMachineManagerImpl1565901500030790
NetworkOrchestrator980601206019280
DataCenterVnetVO58000240
VlanVO186020720
HostDaoImpl4983018008030
AccountGuestVlanMapVO46000190
NetworkOfferingVO414310012612
VolumeVO5291334017939
SystemVmTemplateRegistration177308603760
Upgrade41520to4160026217160625
Upgrade41610to41700159760432
DomainRouterVO11650004114
ConsoleProxyDaoImpl63502001440
DomainRouterDaoImpl160002202280
VolumeObject7736657739178117
CloudStackContextLoaderListener77020210
LibvirtComputingResource8888198810871471983451
LibvirtStartCommandWrapper7529516221572
VmwareResource2039502274043970
VmwareStorageLayoutHelper1263011401960
VmwareStorageProcessor98929940021222
CitrixResourceBase146585571456343169122
CitrixCheckSshCommandWrapper155133314
CitrixNetworkElementCommandWrapper0140004
CitrixRebootRouterCommandWrapper28253157
CitrixStartCommandWrapper6906281111616
KubernetesClusterManagerImpl4724048007600
KubernetesClusterActionWorker1540011402810
KubernetesClusterResourceModifierActionWorker1843014003250
MetricsServiceImpl2130013404460
ClusterMetricsResponse52301320600
VmMetricsResponse1420220250
VolumeMetricsResponse69080100
ZoneMetricsResponse50101260560
DomainChecker1206030002380
ApiDBUtils2374021005920
ApiResponseHelper1214401274027790
ResponseObjectTypeAdapter1618140372
ParamProcessWorker1050015502410
QueryManagerImpl1425701248024090
DomainRouterJoinDaoImpl80108001950
VolumeJoinDaoImpl77009401710
DomainRouterJoinVO237000800
VolumeJoinVO267000930
ConfigurationManagerImpl1810403032035700
ConsoleProxyManagerImpl3717042307260
LibvirtServerDiscoverer994011602180
IpAddressManagerImpl4045046108060
NetworkModelImpl61820838013000
NetworkServiceImpl1338301864025510
GuestNetworkGuru622298983412464
PrivateNetworkGuru3940460880
LoadBalancingRulesManagerImpl60240666012540
NetworkHelperImpl2073027404410
VirtualNetworkApplianceManagerImpl75850780015210
RulesManagerImpl4074049207900
VpcManagerImpl68830762013140
ConfigurationServerImpl2061017604950
ManagementServerImpl1215901076024280
StatsCollector2178012403590
StorageManagerImpl85800976017100
VolumeApiServiceImpl1085101500020350
AccountManagerImpl64460906013510
UserVmManagerImpl2079802566038690
CAManagerImpl63308001290
MockNetworkManagerImpl4850220830
SecondaryStorageManagerImpl35441493431162932
VirtualMachineMO8953135106317198231

@nvazquez

nvazquez commented Apr 23, 2022

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

blueorangutan commented Apr 23, 2022

Copy link
Copy Markdown

@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@nvazquez

nvazquez commented Apr 25, 2022

Copy link
Copy Markdown
Contributor

@blueorangutan test centos7 vmware-65u2

1 similar comment
@nvazquez

nvazquez commented Apr 25, 2022

Copy link
Copy Markdown
Contributor

@blueorangutan test centos7 vmware-65u2

@blueorangutan

blueorangutan commented Apr 25, 2022

Copy link
Copy Markdown

@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

@blueorangutan

blueorangutan commented Apr 25, 2022

Copy link
Copy Markdown

Trillian test result (tid-4018)
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 17646 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6283-t4018-vmware-65u2.zip
Smoke tests completed. 49 look OK, 0 have errors
Only failed tests results shown below:

TestResultTime (s)Test File

@nvazquez

nvazquez commented Apr 25, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

@SadiJr thanks for the changes in the error message - I was not able to reproduce the issue on main branch using vmware 6.5 + NFS following the steps in the PR description, however changes LGTM

@nvazqueznvazquez modified the milestones: 4.17.0.0, 4.17.1.0Apr 26, 2022
@SadiJr

SadiJr commented Apr 26, 2022

Copy link
Copy Markdown
ContributorAuthor

@SadiJr thanks. my concern is, is it good to ignore all the errors in detch volume on vmware ? can we ignore the error only if some errors happen, for example by checking the error message e.getMessage().contains("xxxxxx") ?

cc @nvazquez

Done, thanks for the suggestion.

@acs-robot

acs-robot commented Apr 26, 2022

Copy link
Copy Markdown

Found UI changes, kicking a new UI QA build
@blueorangutan ui

@blueorangutan

blueorangutan commented Apr 26, 2022

Copy link
Copy Markdown

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Apr 26, 2022

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6283 (SL-JID-1474)

weizhouapache
weizhouapache approved these changes Apr 26, 2022
View reviewed changes

@weizhouapacheweizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache

weizhouapache commented Apr 26, 2022

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

blueorangutan commented Apr 26, 2022

Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@acs-robot

acs-robot commented Apr 26, 2022

Copy link
Copy Markdown

PR Coverage Report

CLASSINSTRUCTION MISSEDINSTRUCTION COVEREDBRANCH MISSEDBRANCH COVEREDLINE MISSEDLINE COVERED
Network55404201070
Volume109020440
VirtualMachineGuru78040150
NetworkOrchestrationService010100010
AlertManager7900070
ConnectedAgentAttache1490200400
VirtualMachineManagerImpl1565901500030790
NetworkOrchestrator991001224019450
CapacityVO261000800
DataCenterVnetVO58000240
VlanVO186020720
VlanDaoImpl130705402180
EventVO140000580
HostDaoImpl4983018008030
AccountGuestVlanMapVO46000190
NetworkDetailsDaoImpl3004050
NetworkVO39615919114044
VpcOfferingDaoImpl137000250
VpcOfferingDetailsDaoImpl1730100310
NetworkOfferingVO414310012612
NetworkOfferingDaoImpl69102201140
VolumeVO5291334017939
SystemVmTemplateRegistration177308603760
Upgrade41520to4160026217160625
Upgrade41610to41700159760432
DomainRouterVO11650004114
ConsoleProxyDaoImpl63502001440
DomainRouterDaoImpl160002202280
NicDaoImpl139201201930
SnapshotObject7483064015111
VolumeObject7736657739178117
CloudStackContextLoaderListener77020210
LibvirtComputingResource8888198810871471983451
LibvirtStartCommandWrapper7529516221572
MockNetworkManagerImpl5100240880
SimulatorManagerImpl1394021403090
VmwareResource2039502274043970
VmwareStorageLayoutHelper1297011802010
VmwareStorageProcessor98929940021222
CitrixResourceBase146585571456343169122
CitrixCheckSshCommandWrapper155133314
CitrixNetworkElementCommandWrapper0140004
CitrixRebootRouterCommandWrapper28253157
CitrixStartCommandWrapper6906281111616
KubernetesClusterManagerImpl4724048007600
KubernetesClusterActionWorker1540011402810
KubernetesClusterResourceModifierActionWorker1843014003250
CreateKubernetesClusterCmd2150180610
MetricsServiceImpl2130013404460
ClusterMetricsResponse52301320600
VmMetricsResponse1420220250
VolumeMetricsResponse69080100
ZoneMetricsResponse50101260560
BigSwitchBcfGuestNetworkGuru66206201450
CreateServiceInstanceCmd2010160450
ContrailManagerImpl2218023404970
StopNetScalerVMCmd1140120260
OvsGuestNetworkGuru4090480900
VxlanGuestNetworkGuru8918011211639
LinkAccountToLdapCmd77105641823
ListAndSwitchSAMLAccountCmd18220530223834
DomainChecker1206030002380
AlertManagerImpl2133018304180
ApiAsyncJobDispatcher2120120530
ApiDBUtils2374021005920
ApiDispatcher2310420550
ApiResponseHelper1240001292028370
ApiServer2868112346067214
ResponseObjectTypeAdapter1618140372
ParamProcessWorker1050015502410
QueryManagerImpl1442901270024390
DomainRouterJoinDaoImpl80108001950
NetworkOfferingJoinDaoImpl2780120570
VolumeJoinDaoImpl77009401710
VpcOfferingJoinDaoImpl172060360
AsyncJobJoinVO86000310
DomainRouterJoinVO237000800
EventJoinVO100000350
NetworkOfferingJoinVO219000790
VolumeJoinVO267000930
VpcOfferingJoinVO120000370
ConfigurationManagerImpl1865203092036390
ConsoleProxyManagerImpl3717042307260
ActionEventInterceptor39819442907
ActionEventUtils92909001980
EventJoinDaoImpl3290180580
HypervisorGuruBase669385201335
LibvirtServerDiscoverer994011602180
ExternalFirewallDeviceManagerImpl1885019803810
ExternalLoadBalancerDeviceManagerImpl2591028805930
IpAddressManagerImpl4084046308140
Ipv6AddressManagerImpl3710320700
NetworkMigrationManagerImpl170609003550
NetworkModelImpl61820838013000
NetworkServiceImpl1364801902026130
FirewallManagerImpl2600039904660
ExternalGuestNetworkGuru84909201580
GuestNetworkGuru7022981143414264
PrivateNetworkGuru3940460880
PublicNetworkGuru3410420770
LoadBalancingRulesManagerImpl60240666012540
CommandSetupHelper4088030007710
NetworkHelperImpl2092027804450
VirtualNetworkApplianceManagerImpl77670792015440
RulesManagerImpl4074049207900
NetworkACLManagerImpl861011801820
NetworkACLServiceImpl2701030405200
VpcManagerImpl69360770013210
Site2SiteVpnManagerImpl2298021404680
ResourceManagerImpl85240982016590
RollingMaintenanceManagerImpl2041019203630
ResourceIconManagerImpl3280360700
ConfigurationServerImpl2061017604950
ManagementServerImpl1219701076024280
StatsCollector2178012403590
StorageManagerImpl85800976017100
VolumeApiServiceImpl1087301502020410
SnapshotManagerImpl4195041007530
SnapshotSchedulerImpl87108101970
ResourceManagerUtilImpl3560240710
TemplateManagerImpl50110696010450
AccountManagerImpl64600906013520
UserVmManagerImpl2079802566038690
VMSnapshotManagerImpl3151029606280
RoleManagerImpl737011401470
AffinityGroupServiceImpl791011201720
AnnotationManagerImpl1401016702840
BackupManagerImpl2779022404890
CAManagerImpl63308001290
DirectDownloadManagerImpl1684018603610
HAManagerImpl1391019402310
BasicNetworkVisitor53502801120
OutOfBandManagementServiceImpl1182013002370
PowerOperationTask109000170
MockNetworkManagerImpl5100240880
SecondaryStorageManagerImpl35441493431162932
VirtualMachineMO8953135106317198231

@blueorangutan

blueorangutan commented Apr 26, 2022

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3312

@nvazqueznvazquez modified the milestones: 4.17.1.0, 4.17.0.0Apr 27, 2022
@nvazquez
nvazquez merged commit 4cc830d into apache:mainApr 27, 2022
@SadiJr
SadiJr deleted the vmware-fix-detach-volume-exception branch May 4, 2022 15:19
DaanHoogland pushed a commit to shapeblue/cloudstack that referenced this pull request Jun 14, 2022
@SadiJrSadiJr@DaanHoogland
[VMWare] error when detaching volume (apache#6283)
43cc933
* Fix exception, in VMWare 6.5, when trying to detach volume
* Address reviews
* Address reviews
Co-authored-by: SadiJr <sadi@scclouds.com.br>
shwstppr pushed a commit to shapeblue/cloudstack that referenced this pull request Sep 22, 2022
@DaanHoogland
Merge pull request#56from shapeblue/sb10-ammendment
f9262b6
[VMWare] error when detaching volume (apache#6283)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvazqueznvazqueznvazquez approved these changes
@weizhouapacheweizhouapacheweizhouapache approved these changes
@Pearl1594Pearl1594Awaiting requested review from Pearl1594

Assignees

No one assigned

Labels

component:vmwaretype:bug

Projects

No open projects
Apache CloudStack 4.17.0
Status: Done

Milestone

4.17.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@SadiJr@acs-robot@blueorangutan@nvazquez@weizhouapache@DaanHoogland