Enable system VM volume migration for KVM by GutoVeronezi · Pull Request #6341 · apache/cloudstack

GutoVeronezi · 2022-04-29T22:49:29Z

Description

Release 4.16.0.0 introduced a feature for migrating system VM volumes (#4385). However, it was enabled only for VMWare.

This PR intends to enable the feature for KVM too.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
[ x] Minor

How Has This Been Tested?

It was tested in a local lab.

(I tested the process for each system VM type)

To test the SSVM and CPVM, I enabled a zone to create them. When they were created, I disabled the zone. I accessed the system VMs and created files to validate later. I stopped them and migrated the volumes. I checked the references in database and storage and then I started the system VMs. After that, I accessed them again and verified the files. The migration performed successfully, the data was kept and the system VMs were working fine.

To test the VR, I created a network. I accessed the VR and created a file to validate later. I stopped the VR and migrated the volume. I checked the reference in database and storage and then I started the VR. After that, I accessed it again and verified the file. The migration performed successfully, the data was kept and the VR was working fine.

acs-robot · 2022-04-29T22:50:22Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

acs-robot · 2022-04-29T23:38:19Z

PR Analysis

https://sonarcloud.io/summary/new_code?id=apachecloudstack&pullRequest=6341

PR Coverage Report

CLASS	INSTRUCTION MISSED	BRANCH MISSED	LINE MISSED
Upgrade41700to41710	89	4	25
ApiDBUtils	2350	204	585
ApiResponseHelper	12386	1288	2833
DomainRouterJoinDaoImpl	801	80	195
UserVmManagerImpl	20819	2566	3871

yadvr · 2022-05-04T06:26:49Z

Can you merge latest main branch to your PR branch @GutoVeronezi ?

GutoVeronezi · 2022-05-04T19:35:16Z

@rohityadavcloud, done.

github-actions · 2022-06-07T07:36:38Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

acs-robot · 2022-06-21T13:40:22Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-21T13:41:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-06-21T13:48:59Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6341 (SL-JID-1796)

DaanHoogland

clgtm

DaanHoogland · 2022-06-23T09:35:39Z

awful lot of travis failures

DaanHoogland · 2022-06-23T09:36:17Z

re-try

acs-robot · 2022-06-23T09:37:21Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-06-23T09:38:02Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

shwstppr · 2022-06-23T09:44:23Z

@GutoVeronezi PR is marked for milestone 4.17.1.0, schema changes are also in 4170to4171 upgrade path but base branch is main. Should it be changed to 4.17 instead? cc @DaanHoogland

blueorangutan · 2022-06-23T09:51:49Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6341 (SL-JID-1820)

blueorangutan · 2022-08-02T18:09:03Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-08-03T05:40:20Z

Trillian test result (tid-4597)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40100 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6341-t4597-kvm-centos7.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

acs-robot · 2022-08-03T05:45:34Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-08-03T05:46:02Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-08-03T05:51:39Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6341 (SL-JID-2064)

shwstppr · 2022-08-03T10:49:04Z

re-kicking travis

shwstppr · 2022-08-04T09:08:11Z

@GutoVeronezi can you please check why tests from test_vpc_routers are failing on travis repeatedly

shwstppr

@GutoVeronezi this is causing failures

acs-robot · 2022-08-05T19:25:44Z

Found UI changes, kicking a new UI QA build
@blueorangutan ui

blueorangutan · 2022-08-05T19:26:03Z

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2022-08-05T19:31:09Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6341 (SL-JID-2090)

sonarqubecloud · 2022-08-05T20:26:39Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

shwstppr · 2022-08-08T05:06:03Z

@blueorangutan package

blueorangutan · 2022-08-08T05:07:03Z

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-08-08T05:56:21Z

Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✖️ suse15. SL-JID 3932

blueorangutan · 2022-08-08T10:10:43Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3938

DaanHoogland · 2022-08-08T10:22:19Z

@blueorangutan test

blueorangutan · 2022-08-08T10:23:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-08-08T21:27:00Z

Trillian test result (tid-4645)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38400 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6341-t4645-kvm-centos7.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

Release 4.16.0.0 introduced a feature for migrating system VM volumes (apache#4385). However, it was enabled only for VMWare. This PR intends to enable the feature for KVM too. Co-authored-by: GutoVeronezi <daniel@scclouds.com.br>

GutoVeronezi added this to the 4.17.1.0 milestone Apr 29, 2022

boring-cyborgBot added the component:UI label Apr 29, 2022

nvazquez force-pushed the main branch from c56220f to 0f4c3afCompare June 6, 2022 15:14

github-actionsBot added the status:has-conflicts label Jun 7, 2022

github-actionsBot removed the status:has-conflicts label Jun 21, 2022

DaanHoogland approved these changes Jun 23, 2022
View reviewed changes

DaanHoogland closed this Jun 23, 2022

DaanHoogland reopened this Jun 23, 2022

GutoVeronezi changed the base branch from main to 4.17June 23, 2022 11:17

boring-cyborgBot added component:agent component:api component:build component:orchestration component:storage distro:ubuntu labels Jun 23, 2022

GutoVeronezi force-pushed the enable-systemvm-volume-migration-for-kvm branch from eb74c40 to fd3b829Compare June 23, 2022 11:20

shwstppr approved these changes Aug 3, 2022
View reviewed changes

shwstppr closed this Aug 3, 2022

shwstppr reopened this Aug 3, 2022

shwstppr closed this Aug 3, 2022

shwstppr reopened this Aug 3, 2022

shwstppr requested changes Aug 5, 2022
View reviewed changes

Comment threadengine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql Outdated

shwstppr reviewed Aug 5, 2022
View reviewed changes

Comment threadengine/schema/src/main/resources/META-INF/db/schema-41700to41710.sql Outdated

Use correct offering table
58dc1c1

GutoVeronezi requested a review from shwstppr August 5, 2022 19:25

shwstppr approved these changes Aug 8, 2022
View reviewed changes

shwstppr merged commit b0e780a into apache:4.17Aug 9, 2022

Uh oh!

Conversation

GutoVeronezi commented Apr 29, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

How Has This Been Tested?

Uh oh!

acs-robot commented Apr 29, 2022

Uh oh!

acs-robot commented Apr 29, 2022

PR Analysis

PR Coverage Report

Uh oh!

yadvr commented May 4, 2022

Uh oh!

GutoVeronezi commented May 4, 2022

Uh oh!

github-actionsBot commented Jun 7, 2022

Uh oh!

acs-robot commented Jun 21, 2022

Uh oh!

blueorangutan commented Jun 21, 2022

Uh oh!

blueorangutan commented Jun 21, 2022

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jun 23, 2022

Uh oh!

DaanHoogland commented Jun 23, 2022

Uh oh!

acs-robot commented Jun 23, 2022

Uh oh!

blueorangutan commented Jun 23, 2022

Uh oh!

shwstppr commented Jun 23, 2022

Uh oh!

blueorangutan commented Jun 23, 2022

Uh oh!

blueorangutan commented Aug 2, 2022

Uh oh!

blueorangutan commented Aug 3, 2022

Uh oh!

acs-robot commented Aug 3, 2022

Uh oh!

blueorangutan commented Aug 3, 2022

Uh oh!

blueorangutan commented Aug 3, 2022

Uh oh!

shwstppr commented Aug 3, 2022

Uh oh!

shwstppr commented Aug 4, 2022

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

acs-robot commented Aug 5, 2022

Uh oh!

blueorangutan commented Aug 5, 2022

Uh oh!

blueorangutan commented Aug 5, 2022

Uh oh!

sonarqubecloudBot commented Aug 5, 2022

Uh oh!

shwstppr commented Aug 8, 2022

Uh oh!

blueorangutan commented Aug 8, 2022

Uh oh!

blueorangutan commented Aug 8, 2022

Uh oh!

blueorangutan commented Aug 8, 2022

Uh oh!

DaanHoogland commented Aug 8, 2022

Uh oh!

blueorangutan commented Aug 8, 2022