Uh oh!
There was an error while loading. Please reload this page.
CLOUDSTACK-8703: Fixed issue when listing directory on S3. - #651
Conversation
…nly return objectSummaries when the anwser from the S3 System was truncated.
remibergsma
commented
Aug 3, 2015
The failing check is a Travis timeout. Seems not related, is it? |
There was a problem hiding this comment.
is ol guaranteed not to be null? I don't see any specific remark on this in the amazon javadoc.
There was a problem hiding this comment.
It is, it will thrown an exception not return null.
DaanHoogland
commented
Aug 3, 2015
@borisroman@remibergsma the timeout is not related to anything but travis and maybe to the way we use it |
DaanHoogland
commented
Aug 3, 2015
thanks for the comments Boris LGTM |
remibergsma
commented
Aug 3, 2015
I cannot test the functionality myself right now, although it looks OK. @wido can you verify and give a final LGTM? I'll then merge it. @borisroman my only comment is your commit message. Please use 50 chars or less on the first line (as a title), then an empty line and finally any extra info or a description. Example: CLOUDSTACK-8703: It would only return objectSummaries when the anwser from the S3 System was truncated. |
DaanHoogland
commented
Aug 3, 2015
@remibergsma Are you sure you don't want the issue ref on the first line? CLOUDSTACK-8703: Fixed issue when listing directory on S3 It would only return objectSummaries when the anwser from the S3 System was truncated. |
asfbot
commented
Aug 3, 2015
cloudstack-pull-rats #187 ABORTED |
remibergsma
commented
Aug 3, 2015
@DaanHoogland If it fits, its OK. Usually when people do this, it doesn't fit any more and GitHub will cut it. If the issue id is in the body, you can still search for it. |
wido
commented
Aug 3, 2015
@remibergsma I will look at this with @borisroman tomorrow at the office. I want to verify his logic. Code seems good for now. |
asfbot
commented
Aug 3, 2015
cloudstack-pull-requests #885 ABORTED |
asfbot
commented
Aug 3, 2015
cloudstack-pull-analysis #120 SUCCESS |
wido
commented
Aug 4, 2015
Reviewed the code. LGTM |
* pr/651: CLOUDSTACK-8703: Fixed issue when listing directory on S3, it would only return objectSummaries when the anwser from the S3 System was truncated. Signed-off-by: Remi Bergsma <github@remi.nl>
…nly return objectSummaries when the anwser from the S3 System was truncated. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com> This closes#651
* Prevent form from closing if validation fails * Prevent closing on failure for custom forms * Fixing group actions Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Correção em transação nas APIs do Quota Closes#651 See merge request scclouds/scclouds!1160
It would only return objectSummaries when the anwser from the S3 System was truncated. Due to: debcbcc