kvm: fix backup volume snapshot fails on RBD storage by weizhouapache · Pull Request #6790 · apache/cloudstack

weizhouapache · 2022-09-30T09:56:47Z

Description

This PR fixes the issue that volume snapshot fails on RBD storage with the following error

qemu-img: Could not open 'driver=raw,file.filename=rbd:cloudstack/test_wei.img:mon_host=10.0.32.254:auth_supported=cephx:id=cloudstack:key=AQDwHTNjjHXRKRAAJb+AToFr6x4a1AvKUc4Ksg==:rbd_default_format=2:client_mount_timeout=30': Could not open 'rbd:cloudstack/test_wei.img:mon_host=10.0.32.254:auth_supported=cephx:id=cloudstack:key=AQDwHTNjjHXRKRAAJb+AToFr6x4a1AvKUc4Ksg==:rbd_default_format=2:client_mount_timeout=30': No such file or directory

However, it works without using image options

Therefore, do not pass the image options if the image format is not QCOW2 and LUKS.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

volume snapshot fails on RBD storage with the following error qemu-img: Could not open 'driver=raw,file.filename=rbd:cloudstack/test_wei.img:mon_host=10.0.32.254:auth_supported=cephx:id=cloudstack:key=AQDwHTNjjHXRKRAAJb+AToFr6x4a1AvKUc4Ksg==:rbd_default_format=2:client_mount_timeout=30': Could not open 'rbd:cloudstack/test_wei.img:mon_host=10.0.32.254:auth_supported=cephx:id=cloudstack:key=AQDwHTNjjHXRKRAAJb+AToFr6x4a1AvKUc4Ksg==:rbd_default_format=2:client_mount_timeout=30': No such file or directory However, it works without using image options Therefore, do not pass the image options if the image format is not QCOW2 and LUKS.

weizhouapache · 2022-09-30T10:00:35Z

@mlsorensen
This PR has some changes in the file QemuImageOptions.java which was introduced by your nice PR (Volume encryption feature #6522).
can you review this PR ?

weizhouapache · 2022-09-30T10:00:46Z

@blueorangutan package

blueorangutan · 2022-09-30T10:01:03Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland

clgtm, test updated for this, though I am not clear on whether this can be tested more (unit, integration or monkey)

weizhouapache · 2022-09-30T10:40:19Z

@blueorangutan package

blueorangutan · 2022-09-30T10:41:03Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-09-30T10:45:42Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian. SL-JID 4324

weizhouapache · 2022-09-30T10:52:24Z

@blueorangutan test

blueorangutan · 2022-09-30T10:53:03Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-09-30T10:58:33Z

Trillian Build Failed (tid-5060)

blueorangutan · 2022-09-30T11:35:09Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4325

codecov · 2022-09-30T13:42:56Z

Codecov Report

Merging #6790 (73efc10) into main (784578d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@ Coverage Diff @@## main #6790 +/- ##
============================================
+ Coverage 10.52% 10.54% +0.01% - Complexity 6784 6794 +10 
============================================
Files 2464 2464 Lines 243989 244171 +182 Branches 38186 38204 +18 ============================================
+ Hits 25690 25751 +61 - Misses 215065 215170 +105 - Partials 3234 3250 +16

Impacted Files	Coverage Δ
...apache/cloudstack/utils/qemu/QemuImageOptions.java	`73.07% <100.00%> (+16.55%)`	⬆️
.../main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java	`27.34% <0.00%> (-0.74%)`	⬇️
...n/java/com/cloud/capacity/dao/CapacityDaoImpl.java	`3.24% <0.00%> (-0.13%)`	⬇️
.../src/main/java/com/cloud/vm/dao/UserVmDaoImpl.java	`0.77% <0.00%> (-0.07%)`	⬇️
...che/cloudstack/metrics/PrometheusExporterImpl.java	`0.00% <0.00%> (ø)`
...e/cloudstack/metrics/PrometheusExporterServer.java	`0.00% <0.00%> (ø)`
...c/main/java/com/cloud/user/dao/AccountDaoImpl.java	`30.12% <0.00%> (+2.23%)`	⬆️
...rg/apache/cloudstack/quota/QuotaStatementImpl.java	`40.26% <0.00%> (+3.98%)`	⬆️
...om/cloud/deploy/DeploymentPlanningManagerImpl.java	`27.29% <0.00%> (+4.25%)`	⬆️
...a/src/main/java/com/cloud/dc/ClusterDetailsVO.java	`61.53% <0.00%> (+7.69%)`	⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

weizhouapache · 2022-10-05T07:42:56Z

@blueorangutan package

blueorangutan · 2022-10-05T07:44:03Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sonarqubecloud · 2022-10-05T08:47:29Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

77.8% Coverage
0.0% Duplication

blueorangutan · 2022-10-05T08:52:57Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 4354

weizhouapache · 2022-10-05T14:10:12Z

@blueorangutan test

blueorangutan · 2022-10-05T14:11:03Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-10-06T02:51:31Z

Trillian test result (tid-5073)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 44191 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6790-t5073-kvm-centos7.zip
Smoke tests completed. 102 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	576.69	test_kubernetes_clusters.py

weizhouapache requested review from DaanHoogland and yadvr September 30, 2022 09:56

boring-cyborgBot added the component:kvm label Sep 30, 2022

DaanHoogland approved these changes Sep 30, 2022
View reviewed changes

Comment threadplugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImageOptions.java Outdated

kvm QemuImageOptions: use setFormat
3dc58ae

kvmapache#6790: fix code smell
1f6ac33

weizhouapache mentioned this pull request Sep 30, 2022
Support multiple ceph monitors #6792
Merged
7 tasks

GutoVeronezi reviewed Oct 4, 2022
View reviewed changes

Comment threadplugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/utils/qemu/QemuImageOptions.java Outdated

Updateapache#6790: use uppercase
73efc10

weizhouapache added a commit to weizhouapache/cloudstack that referenced this pull request Oct 5, 2022
kvmapache#6790: fix code smell
783e79b

weizhouapache added a commit to weizhouapache/cloudstack that referenced this pull request Oct 5, 2022
Updateapache#6790: use uppercase
d8a661c

yadvr approved these changes Oct 8, 2022
View reviewed changes

yadvr merged commit 6786c24 into apache:mainOct 8, 2022

yadvr added this to the 4.18.0.0 milestone Oct 8, 2022

yadvr added the type:bug label Oct 8, 2022

weizhouapache deleted the 4.18-fix-volume-snapshot-on-rbd branch December 9, 2022 10:38

Uh oh!

Conversation

weizhouapache commented Sep 30, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache commented Sep 30, 2022

Uh oh!

weizhouapache commented Sep 30, 2022

Uh oh!

blueorangutan commented Sep 30, 2022

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

weizhouapache commented Sep 30, 2022

Uh oh!

blueorangutan commented Sep 30, 2022

Uh oh!

blueorangutan commented Sep 30, 2022

Uh oh!

weizhouapache commented Sep 30, 2022

Uh oh!

blueorangutan commented Sep 30, 2022

Uh oh!

blueorangutan commented Sep 30, 2022

Uh oh!

blueorangutan commented Sep 30, 2022

Uh oh!

codecovBot commented Sep 30, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

weizhouapache commented Oct 5, 2022

Uh oh!

blueorangutan commented Oct 5, 2022

Uh oh!

sonarqubecloudBot commented Oct 5, 2022

Uh oh!

blueorangutan commented Oct 5, 2022

Uh oh!

weizhouapache commented Oct 5, 2022

Uh oh!

blueorangutan commented Oct 5, 2022

Uh oh!

blueorangutan commented Oct 6, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecovBot commented Sep 30, 2022•
edited
Loading