Fix typos and improve javadocs on ByteScaleUtils by GutoVeronezi · Pull Request #6877 · apache/cloudstack

GutoVeronezi · 2022-11-08T15:41:43Z

Description

PR #5909 introduced a class to convert bytes through the scales (B, KiB, KB, MiB, MB...); however, there are some typos in the javadocs and method names. This PR intends to fix those typos and improve the javadocs.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Bug Severity

GutoVeronezi · 2022-11-08T15:42:58Z

@blueorangutan package

blueorangutan · 2022-11-08T15:44:03Z

@GutoVeronezi a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-11-08T16:24:11Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. LL-JID 225

codecov · 2022-11-08T17:49:53Z

Codecov Report

Merging #6877 (b4eb76b) into main (4c5a2ba) will increase coverage by 0.02%.
The diff coverage is 75.00%.

@@ Coverage Diff @@## main #6877 +/- ##
============================================
+ Coverage 10.84% 10.87% +0.02% - Complexity 7105 7117 +12 
============================================
Files 2485 2485 Lines 245417 245499 +82 Branches 38326 38334 +8 ============================================
+ Hits 26622 26699 +77 - Misses 215526 215530 +4 - Partials 3269 3270 +1

Impacted Files	Coverage Δ
...ervisor/kvm/resource/LibvirtComputingResource.java	`17.03% <0.00%> (+1.34%)`	⬆️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	`6.72% <0.00%> (ø)`
...tionrule/presetvariables/PresetVariableHelper.java	`98.56% <100.00%> (ø)`
...resource/wrapper/LibvirtScaleVmCommandWrapper.java	`94.11% <100.00%> (ø)`
...er/src/main/java/com/cloud/hypervisor/KVMGuru.java	`73.22% <100.00%> (ø)`
...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java	`67.65% <0.00%> (+0.61%)`	⬆️
...ypervisor/kvm/resource/LibvirtDomainXMLParser.java	`50.61% <0.00%> (+2.11%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

weizhouapache · 2022-11-08T18:32:40Z

- * @return The parameter multiplied by 1048576 (1024 * 1024, 1 MiB).
+ * @return The parameter multiplied by 2²⁰ (1048576 | 1024 * 1024 | 1 MiB | ).
 */
 public static long mibToBytes(long mib) {


@GutoVeronezi
do we need to change this to miBToBytes as well ? looks a bit strange

@GutoVeronezi
thanks for fixing btw

@weizhouapache, what do you think about not using the symbols (e.g.: mebibytesToBytes) ? This way it would leave no doubt and would be consistent, as it is written ...ToBytes, and not ...toB.

@GutoVeronezi looks good to me.
@DaanHoogland what is your opinion?

I like @GutoVeronezi 's last proposal here, reading will actually be quicker as you don´t need to translate in your head.

DaanHoogland · 2022-11-09T13:27:43Z

@blueorangutan package

blueorangutan · 2022-11-09T13:28:14Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-11-09T14:19:40Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. LL-JID 232

DaanHoogland · 2022-11-09T17:27:04Z

@blueorangutan test

blueorangutan · 2022-11-09T17:28:03Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

weizhouapache

code lgtm

thanks @GutoVeronezi

weizhouapache · 2022-11-09T18:18:13Z

@blueorangutan package

blueorangutan · 2022-11-09T18:19:03Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-11-09T18:57:08Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. LL-JID 237

sonarqubecloud · 2022-11-09T19:13:43Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

81.2% Coverage
0.0% Duplication

blueorangutan · 2022-11-10T05:42:09Z

Trillian test result (tid-54)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42489 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6877-t54-kvm-centos7.zip
Smoke tests completed. 102 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	553.92	test_kubernetes_clusters.py
test_01_redundant_vpc_site2site_vpn	`Failure`	752.15	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Error`	1274.51	test_vpc_vpn.py
test_01_vpc_site2site_vpn	`Error`	545.05	test_vpc_vpn.py

DaanHoogland · 2022-11-10T09:14:13Z

the kubernetes error is intermittent and the vpc_vpn errors are due to a template download failure at the backend; merging

Fix typos and improve javadocs
39f8f31

boring-cyborgBot added component:kvm component:quota labels Nov 8, 2022

GutoVeronezi mentioned this pull request Nov 8, 2022
Quota custom tariffs #5909
Merged
7 tasks

GutoVeronezi requested review from DaanHoogland and weizhouapache November 8, 2022 15:42

GutoVeronezi changed the title ~~Fix typos and improve javadocs~~Fix typos and improve javadocs on ByteScaleUtilsNov 8, 2022

weizhouapache reviewed Nov 8, 2022
View reviewed changes

Use fullname instead of symbols
b4eb76b

weizhouapache approved these changes Nov 9, 2022
View reviewed changes

DaanHoogland approved these changes Nov 10, 2022
View reviewed changes

DaanHoogland merged commit b8b66b7 into apache:mainNov 10, 2022

Uh oh!

Conversation

GutoVeronezi commented Nov 8, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Bug Severity

Uh oh!

GutoVeronezi commented Nov 8, 2022

Uh oh!

blueorangutan commented Nov 8, 2022

Uh oh!

blueorangutan commented Nov 8, 2022

Uh oh!

codecovBot commented Nov 8, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapacheNov 8, 2022

Choose a reason for hiding this comment

Uh oh!

weizhouapacheNov 8, 2022

Choose a reason for hiding this comment

Uh oh!

GutoVeroneziNov 8, 2022

Choose a reason for hiding this comment

Uh oh!

weizhouapacheNov 8, 2022

Choose a reason for hiding this comment

Uh oh!

DaanHooglandNov 9, 2022

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Nov 9, 2022

Uh oh!

blueorangutan commented Nov 9, 2022

Uh oh!

blueorangutan commented Nov 9, 2022

Uh oh!

DaanHoogland commented Nov 9, 2022

Uh oh!

blueorangutan commented Nov 9, 2022

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Nov 9, 2022

Uh oh!

blueorangutan commented Nov 9, 2022

Uh oh!

blueorangutan commented Nov 9, 2022

Uh oh!

sonarqubecloudBot commented Nov 9, 2022

Uh oh!

blueorangutan commented Nov 10, 2022

Uh oh!

DaanHoogland commented Nov 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecovBot commented Nov 8, 2022•
edited
Loading