Ova checksums by DaanHoogland · Pull Request #7009 · apache/cloudstack

DaanHoogland · 2022-12-21T09:02:26Z

Description

This PR moves checksums from the test to test_data

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

sonarqubecloud · 2022-12-21T11:33:46Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

weizhouapache

code lgtm
left a minor comment

codecov · 2022-12-21T16:21:42Z

Codecov Report

Merging #7009 (7555311) into main (9ca5f28) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 7555311 differs from pull request most recent head 44dcb13. Consider uploading reports for the commit 44dcb13 to get more accurate results

@@ Coverage Diff @@## main #7009 +/- ##
=========================================
Coverage 12.68% 12.69% + Complexity 8656 8655 -1 
=========================================
Files 2718 2716 -2 Lines 256169 256117 -52 Branches 39932 39927 -5 =========================================
- Hits 32504 32503 -1 + Misses 219531 219482 -49 + Partials 4134 4132 -2

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions · 2022-12-30T07:58:52Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

yadvr · 2023-05-08T07:22:16Z

Thanks @DaanHoogland let's fix this and pull it out of draft then.

blueorangutan · 2023-05-09T16:19:31Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6047

blueorangutan · 2023-05-09T16:24:17Z

Trillian Build Failed (tid-6523)

blueorangutan · 2023-05-09T16:29:01Z

Trillian Build Failed (tid-6524)

yadvr · 2023-06-27T09:32:59Z

ping @DaanHoogland do we need/want this? (I see smoketests are passing)

DaanHoogland · 2023-07-03T09:38:06Z

@blueorangutan package

blueorangutan · 2023-07-03T09:40:03Z

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-07-03T10:46:52Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6389

DaanHoogland · 2023-07-04T06:41:30Z

@blueorangutan test rocky8 vmware-72u3

blueorangutan · 2023-07-04T06:42:03Z

@DaanHoogland [SF] unsupported parameters provided. Supported mgmt server os are: centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9. Supported hypervisors are: kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82

DaanHoogland · 2023-07-04T07:43:22Z

@blueorangutan test rocky8 vmware-70u3

blueorangutan · 2023-07-04T07:44:03Z

@DaanHoogland a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2023-07-04T22:30:45Z

[SF] Trillian test result (tid-6964)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 51345 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7009-t6964-vmware-70u3.zip
Smoke tests completed. 107 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_primary_storage_disabled_host	`Error`	0.26	test_primary_storage.py
test_03_migration_options_storage_tags	`Error`	0.02	test_primary_storage.py
test_05_update_cmd	`Error`	3.79	test_disk_provisioning_types.py
test_02_1_create_template_with_checksum_sha1_negative	`Error`	0.04	test_templates.py
test_02_create_template_with_checksum_sha1	`Error`	0.04	test_templates.py
test_03_1_create_template_with_checksum_sha256_negative	`Error`	0.04	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	0.04	test_templates.py
test_04_1_create_template_with_checksum_md5_negative	`Error`	0.04	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	0.05	test_templates.py
test_05_create_template_with_no_checksum	`Error`	0.04	test_templates.py
test_01_deploy_vm_on_specific_host	`Error`	0.09	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	0.14	test_vm_deployment_planner.py
test_03_live_migrate_VM_with_two_data_disks	`Error`	58.91	test_vm_life_cycle.py
test_08_migrate_vm	`Error`	0.06	test_vm_life_cycle.py
test_05_vmschedule_test_e2e	`Failure`	230.96	test_vm_schedule.py

DaanHoogland · 2023-07-05T09:17:20Z

@blueorangutan test rocky8 vmware-70u3

blueorangutan · 2023-07-05T09:18:03Z

@DaanHoogland a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2023-07-05T23:23:19Z

[SF] Trillian test result (tid-6983)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 48799 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7009-t6983-vmware-70u3.zip
Smoke tests completed. 112 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_1_create_template_with_checksum_sha1_negative	`Error`	0.06	test_templates.py
test_02_create_template_with_checksum_sha1	`Error`	0.06	test_templates.py
test_03_1_create_template_with_checksum_sha256_negative	`Error`	0.05	test_templates.py
test_03_create_template_with_checksum_sha256	`Error`	0.05	test_templates.py
test_04_1_create_template_with_checksum_md5_negative	`Error`	0.04	test_templates.py
test_04_create_template_with_checksum_md5	`Error`	0.04	test_templates.py
test_05_create_template_with_no_checksum	`Error`	0.04	test_templates.py

DaanHoogland · 2023-07-06T07:29:16Z

tretesting with adapted Trillian version

blueorangutan · 2023-07-06T07:31:41Z

[SF] Trillian Build Failed (tid-6999)

blueorangutan · 2023-07-06T08:30:04Z

[SF] Trillian Build Failed (tid-7001)

DaanHoogland · 2023-07-06T08:51:11Z

@weizhouapache @rohityadavcloud I will close this as the differential in shapeblue/Trillian has grown too big. Work there trumps this work at the moment.

boring-cyborgBot added component:integration-test component:kvm component:marvin Python Warning... Python code Ahead! labels Dec 21, 2022

DaanHoogland requested review from nvazquez, shwstppr and weizhouapache December 21, 2022 09:02

DaanHoogland force-pushed the ovaChecksums branch 2 times, most recently from 5fa3fe9 to 31d232bCompare December 21, 2022 10:38

DaanHoogland changed the base branch from main to 4.17December 21, 2022 10:39

weizhouapache previously approved these changes Dec 21, 2022
View reviewed changes

Comment threadtest/integration/smoke/test_templates.py Outdated

DaanHoogland commented Dec 29, 2022
View reviewed changes

Comment threadtools/marvin/marvin/config/test_data.py Outdated

DaanHoogland commented Dec 29, 2022
View reviewed changes

Comment threadtools/marvin/marvin/config/test_data.py Outdated

DaanHoogland force-pushed the ovaChecksums branch from 089b01d to d045620Compare December 30, 2022 07:58

boring-cyborgBot added component:agent component:api component:build component:integration labels Dec 30, 2022

github-actionsBot added the status:has-conflicts label Dec 30, 2022

DaanHoogland force-pushed the ovaChecksums branch from d045620 to c63acdfCompare December 30, 2022 10:26

github-actionsBot removed the status:has-conflicts label Dec 30, 2022

apache deleted a comment from blueorangutan Dec 30, 2022

vladimirpetrov mentioned this pull request May 23, 2023
Console proxy doesn't work since the beginning of May #7550
Closed

DaanHoogland added this to the 4.19.0.0 milestone Jun 22, 2023

DaanHoogland changed the base branch from main to 4.18July 3, 2023 09:37

boring-cyborgBot added component:database component:management-server component:orchestration component:storage labels Jul 3, 2023

DaanHoogland changed the base branch from 4.18 to mainJuly 3, 2023 09:37

DaanHoogland marked this pull request as ready for review July 5, 2023 09:17

DaanHoogland closed this Jul 6, 2023

Uh oh!

Conversation

DaanHoogland commented Dec 21, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

sonarqubecloudBot commented Dec 21, 2022

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecovBot commented Dec 21, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Dec 30, 2022

Uh oh!

yadvr commented May 8, 2023

Uh oh!

blueorangutan commented May 9, 2023

Uh oh!

blueorangutan commented May 9, 2023

Uh oh!

blueorangutan commented May 9, 2023

Uh oh!

yadvr commented Jun 27, 2023

Uh oh!

DaanHoogland commented Jul 3, 2023

Uh oh!

blueorangutan commented Jul 3, 2023

Uh oh!

blueorangutan commented Jul 3, 2023

Uh oh!

DaanHoogland commented Jul 4, 2023

Uh oh!

blueorangutan commented Jul 4, 2023

Uh oh!

DaanHoogland commented Jul 4, 2023

Uh oh!

blueorangutan commented Jul 4, 2023

Uh oh!

blueorangutan commented Jul 4, 2023

Uh oh!

DaanHoogland commented Jul 5, 2023

Uh oh!

blueorangutan commented Jul 5, 2023

Uh oh!

blueorangutan commented Jul 5, 2023

Uh oh!

DaanHoogland commented Jul 6, 2023

Uh oh!

blueorangutan commented Jul 6, 2023

Uh oh!

blueorangutan commented Jul 6, 2023

Uh oh!

DaanHoogland commented Jul 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecovBot commented Dec 21, 2022•
edited
Loading