Skip to content

ui: fix suitable shared network not showing while import - #7016

Merged
yadvr merged 1 commit into
apache:4.17from
shapeblue:fix-ui-importvm-sharednw-missing
Dec 23, 2022
Merged

ui: fix suitable shared network not showing while import#7016
yadvr merged 1 commit into
apache:4.17from
shapeblue:fix-ui-importvm-sharednw-missing

Conversation

@shwstppr

Copy link
Copy Markdown
Contributor

Description

In import VM form, shared network is not showing when it is in Setup state which should not be the case. This PR fixes that.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before:
Screenshot from 2022-12-22 12-49-00

After:
Screenshot from 2022-12-22 12-49-14

How Has This Been Tested?

In import VM form, shared network is not showing when it is in Setup state which should not be the case.
This PR fixes that.
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov

codecovBot commented Dec 22, 2022

Copy link
Copy Markdown

Codecov Report

Merging #7016 (f07293a) into 4.17 (08881d6) will increase coverage by 0.00%.
The diff coverage is n/a.

@@ Coverage Diff @@## 4.17 #7016 +/- ##
=========================================
Coverage 10.36% 10.36% - Complexity 6628 6630 +2 
=========================================
Files 2453 2453 Lines 242386 242386 Branches 37928 37928 =========================================
+ Hits 25116 25120 +4 + Misses 214163 214158 -5 - Partials 3107 3108 +1 
Impacted FilesCoverage Δ
...dstack/network/contrail/model/ModelObjectBase.java28.84% <0.00%> (+7.69%)⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DaanHooglandDaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@yadvryadvr added this to the 4.18.0.0 milestone Dec 23, 2022
@yadvr
yadvr merged commit 2bb6439 into apache:4.17Dec 23, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@shwstppr@yadvr@DaanHoogland