Skip to content

Userdata MySQL changes to use procedures to avoid duplicates - #7255

Merged
DaanHoogland merged 1 commit into
apache:mainfrom
shapeblue:FixUserDataMySQLchangesToUseProcedure
Feb 20, 2023
Merged

Userdata MySQL changes to use procedures to avoid duplicates#7255
DaanHoogland merged 1 commit into
apache:mainfrom
shapeblue:FixUserDataMySQLchangesToUseProcedure

Conversation

@harikrishna-patnala

@harikrishna-patnalaharikrishna-patnala commented Feb 17, 2023

Copy link
Copy Markdown
Member

Description

This PR fixes the issue of user_data table sql queries to use procedures to avoid duplicates

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@harikrishna-patnalaharikrishna-patnala added this to the 4.18.0.0 milestone Feb 17, 2023
@harikrishna-patnala

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

@weizhouapache

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5601

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5602

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed! Quality Gate passed

BugA0 Bugs
VulnerabilityA0 Vulnerabilities
Security HotspotA0 Security Hotspots
Code SmellA0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan test matrix

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@DaanHooglandDaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@codecov

codecovBot commented Feb 17, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7255 (b90ac42) into main (597a803) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## main #7255 +/- ##
=========================================
Coverage 12.67% 12.67% Complexity 8639 8639 =========================================
Files 2716 2716 Lines 256112 256112 Branches 39926 39926 =========================================
Hits 32456 32456 Misses 219528 219528 Partials 4128 4128 

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@weizhouapacheweizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@yadvryadvr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-6193)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 44059 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7255-t6193-vmware-67u3.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-6192)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48758 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7255-t6192-xenserver-71.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File
test_08_upgrade_kubernetes_ha_clusterError4053.16test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_clusterFailure0.05test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardownError101.76test_kubernetes_clusters.py

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-6194)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48953 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7255-t6194-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File
test_08_upgrade_kubernetes_ha_clusterError4014.60test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_clusterFailure0.04test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardownError75.80test_kubernetes_clusters.py

@borisstoyanovborisstoyanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM manually upgraded

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@harikrishna-patnala@blueorangutan@weizhouapache@DaanHoogland@yadvr@borisstoyanov