Uh oh!
There was an error while loading. Please reload this page.
UI: Add button to copy VM console URL to clipboard - #7351
Merged
Conversation
Codecov Report
@@ Coverage Diff @@## main #7351 +/- ##
=========================================
Coverage 12.68% 12.68% Complexity 8656 8656 =========================================
Files 2718 2718 Lines 256169 256169 Branches 39932 39932 =========================================
Hits 32504 32504 Misses 219531 219531 Partials 4134 4134 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed!
|
BryanMLima
commented
Mar 21, 2023
Contributor
blueorangutan
commented
Mar 21, 2023
@BryanMLima a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
blueorangutan
commented
Mar 21, 2023
UI build: ✔️ |
BryanMLima
commented
Mar 29, 2023
Contributor
LGTM |
DaanHoogland
commented
Mar 30, 2023
Contributor
Difd you test @BryanMLima ? |
BryanMLima
commented
Mar 31, 2023
Contributor
@DaanHoogland Yes, I tested in a local lab and in the QA environment. In both scenarios the URL was successfully copied. |
kishankavala pushed a commit
to shapeblue/cloudstack
that referenced
this pull request
Apr 13, 2023
Co-authored-by: Eduardo Zanetta <eduardo.zanetta@scclouds.com.br>
soreana pushed a commit
to leaseweb/cloudstack
that referenced
this pull request
May 19, 2023
Co-authored-by: Eduardo Zanetta <eduardo.zanetta@scclouds.com.br>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new button that allows the user to copy the VM console URL to the clipboard. VM consoles have a security mechanism that allows for a one-time use per URL (see #6577). Therefore, if the same URL is accessed again, an error message is displayed. When access to the console is requested via the UI button, a new tab is opened which automatically connects to the VM console. However, for the purpose of obtaining only the URL for later use or sharing, it is more convenient to copy the URL rather than opening it directly in a new tab. The new button appears alongside the existing button that opens the console in a new tab
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
I conducted manual testing in a local lab environment. During the testing process, I clicked the new added button and then accessed the copied URL. This allowed me to access the console in the same way as the existing "View Console" button.