VMware: add support for 8.0b (8.0.0.2), 8.0c (8.0.0.3) by weizhouapache · Pull Request #7380 · apache/cloudstack

weizhouapache · 2023-03-29T15:49:45Z

Description

This PR adds

The support (hypervisor capabilities) for VMware 8.0b (8.0.0.2) and 8.0c (8.0.0.3)

Refer to
https://docs.vmware.com/en/VMware-vSphere/8.0/rn/vsphere-esxi-80b-release-notes/index.html
https://docs.vmware.com/en/VMware-vSphere/8.0/rn/vsphere-esxi-80c-release-notes/index.html

The new guest os mappings introduced in VMware 8.0 (also supported by 8.0a and 8.0b/8.0c)

Refer to https://vdc-repo.vmware.com/vmwb-repository/dcr-public/c476b64b-c93c-4b21-9d76-be14da0148f9/04ca12ad-59b9-4e1c-8232-fd3d4276e52c/SDK/vsphere-ws/docs/ReferenceGuide/vim.vm.GuestOsDescriptor.GuestOsIdentifier.html

An extra step to determine the guest os mappings for a hypervisor version

Since VMware 8, each minor update has a newer patch version. For example ESXi host of VMware 8.0b has hypervisor version 8.0.0.2. It is different from previous versions, for example, ESXi host of VMware 7.0 update 3a/3b/3c have the same hypervisor version 7.0.3.0 (not 7.0.3.1/7.0.3.2/7.0.3.3).

This PR adds an extra step to determine the guest os mappings for a hypervisor version: If guest os mapping does not exist, then search for the guest os mapping of parent version. For example
X if guest os mapping of 8.0.0.2 does not exist, then search for guest os mapping for 8.0
X if guest os mapping of 8.0.3.2 does not exist, then search for guest os mapping for 8.0.3

Based on this, we do not need to add guest os mappings for 8.0b (8.0.0.2) and 8.0c (8.0.0.3), the guest os mappings for VMware 8.0 will be used.

Pleae note:
The hypervisor capabilitiy for VMware 8.0U1 (8.0.1.0) has been added in this PR, but there are some critical failures in the testing on VMware 8.0U1, thus it is not supported. (see more information at #7572 )

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

weizhouapache · 2023-03-29T15:50:02Z

@blueorangutan package

blueorangutan · 2023-03-29T15:51:03Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-03-29T16:48:07Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5805

The full list can be found at https://developer.vmware.com/apis/1355/vsphere

weizhouapache · 2023-03-31T09:50:31Z

@blueorangutan package

blueorangutan · 2023-03-31T09:51:03Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-03-31T10:54:57Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5825

codecov · 2023-03-31T11:00:23Z

Codecov Report

Merging #7380 (fc07405) into 4.18 (feb9509) will increase coverage by 0.01%.
The diff coverage is 20.27%.

@@ Coverage Diff @@## 4.18 #7380 +/- ##
============================================
+ Coverage 13.02% 13.03% +0.01% - Complexity 9032 9060 +28 
============================================
Files 2720 2720 Lines 257080 257220 +140 Branches 40088 40098 +10 ============================================
+ Hits 33476 33539 +63 - Misses 219400 219471 +71 - Partials 4204 4210 +6

Files Changed	Coverage Δ
.../hypervisor/dao/HypervisorCapabilitiesDaoImpl.java	`0.00% <0.00%> (ø)`
...ava/com/cloud/upgrade/dao/Upgrade41800to41810.java	`2.36% <0.00%> (-4.31%)`	⬇️
...oud/hypervisor/vmware/resource/VmwareResource.java	`4.49% <0.00%> (-0.02%)`	⬇️
...om/cloud/storage/dao/GuestOSHypervisorDaoImpl.java	`33.66% <50.00%> (+1.40%)`	⬆️
...src/main/java/com/cloud/upgrade/GuestOsMapper.java	`24.19% <62.96%> (+19.09%)`	⬆️
...com/cloud/hypervisor/guru/VmwareVmImplementer.java	`14.36% <88.88%> (+14.36%)`	⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-advanced-security · 2023-03-31T11:24:30Z

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

blueorangutan · 2023-04-05T19:23:49Z

Trillian test result (tid-6381)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 42108 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6381-vmware-80.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

…0% code coverage

DaanHoogland · 2023-04-06T08:56:34Z

@blueorangutan package

blueorangutan · 2023-04-06T09:11:03Z

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache · 2023-04-06T11:36:50Z

@blueorangutan package

blueorangutan · 2023-04-06T11:38:03Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-04-06T12:41:51Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5876

harikrishna-patnala

Code LGTM.

blueorangutan · 2023-04-17T23:56:11Z

Trillian test result (tid-6414)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 43090 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6414-vmware-80.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2023-04-18T00:37:10Z

Trillian test result (tid-6415)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 41770 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6415-vmware-80.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

andrijapanicsb · 2023-08-14T12:31:44Z

@blueorangutan test rocky8 vmware-80

blueorangutan · 2023-08-14T12:32:03Z

@andrijapanicsb a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-80) has been kicked to run smoke tests

andrijapanicsb · 2023-08-14T12:35:37Z

@blueorangutan test ubuntu22 vmware-80

blueorangutan · 2023-08-14T12:36:03Z

@andrijapanicsb a [SF] Trillian-Jenkins test job (ubuntu22 mgmt + vmware-80) has been kicked to run smoke tests

blueorangutan · 2023-08-15T01:40:07Z

[LL]Trillian test result (tid-6693)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server u22
Total time taken: 45726 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6693-vmware-80.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	`Error`	193.87	test_internal_lb.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true	`Error`	131.06	test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false	`Error`	160.30	test_routers_network_ops.py

blueorangutan · 2023-08-15T02:02:47Z

[SF] Trillian test result (tid-7407)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 46606 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t7407-vmware-80.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_create_pvlan_network	`Error`	0.09	test_pvlan.py

blueorangutan · 2023-08-15T03:10:43Z

[LL]Trillian test result (tid-6694)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 50983 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t6694-vmware-80.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_port_fwd_on_non_src_nat	`Error`	13.52	test_network.py
test_01_deploy_vm_on_specific_host	`Error`	18.57	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	3602.66	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	1.23	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	2.23	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	2.24	test_vm_deployment_planner.py

blueorangutan · 2023-08-15T03:42:30Z

[SF] Trillian test result (tid-7408)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server u22
Total time taken: 52410 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t7408-vmware-80.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_router_dhcphosts	`Failure`	146.75	test_router_dhcphosts.py

weizhouapache · 2023-08-15T10:33:45Z

@blueorangutan test rocky8 vmware-80

blueorangutan · 2023-08-15T10:34:03Z

@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-80) has been kicked to run smoke tests

weizhouapache · 2023-08-15T10:39:35Z

@blueorangutan test rocky8 vmware-67u3

blueorangutan · 2023-08-15T10:40:03Z

@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests

weizhouapache · 2023-08-15T10:45:09Z

@blueorangutan test ubuntu22 vmware-80

blueorangutan · 2023-08-15T10:46:03Z

@weizhouapache a [SF] Trillian-Jenkins test job (ubuntu22 mgmt + vmware-80) has been kicked to run smoke tests

blueorangutan · 2023-08-16T01:31:57Z

[SF] Trillian test result (tid-7428)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server u22
Total time taken: 51176 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t7428-vmware-80.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_cpvm_vm	`Failure`	0.06	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.05	test_ssvm.py
test_12_destroy_cpvm	`Error`	6.31	test_ssvm.py

blueorangutan · 2023-08-16T01:46:51Z

[SF] Trillian test result (tid-7427)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 52790 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t7427-vmware-67u3.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_deploy_vm_on_specific_host	`Error`	26.95	test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster	`Error`	3605.14	test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod	`Error`	1.39	test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster	`Error`	4.46	test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod	`Error`	1.33	test_vm_deployment_planner.py

blueorangutan · 2023-08-16T01:53:27Z

[SF] Trillian test result (tid-7426)
Environment: vmware-80 (x2), Advanced Networking with Mgmt server r8
Total time taken: 53187 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t7426-vmware-80.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	378.91	test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster	`Failure`	0.09	test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown	`Error`	4052.65	test_kubernetes_clusters.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	486.80	test_vpc_redundant.py

weizhouapache · 2023-08-16T18:54:17Z

@blueorangutan test ubuntu22 vmware-80

weizhouapache · 2023-08-16T18:55:07Z

@blueorangutan test rocky8 vmware-67u3

blueorangutan · 2023-08-16T19:02:03Z

@weizhouapache a [SF] Trillian-Jenkins test job (rocky8 mgmt + vmware-67u3) has been kicked to run smoke tests

weizhouapache · 2023-08-16T19:20:34Z

@blueorangutan test ubuntu22 vmware-80

blueorangutan · 2023-08-16T19:22:03Z

@weizhouapache a [SF] Trillian-Jenkins test job (ubuntu22 mgmt + vmware-80) has been kicked to run smoke tests

blueorangutan · 2023-08-17T07:23:11Z

[SF] Trillian test result (tid-7448)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 42970 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7380-t7448-vmware-67u3.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

VMware: add support for 8.0b (8.0.0.2)
7c04d06

weizhouapache added 3 commits March 31, 2023 11:37

VMware 8: add new guest os mappings in VirtualMachineGuestOsIdentifier
186812e
The full list can be found at https://developer.vmware.com/apis/1355/vsphere

VMware: get guest os mappings of parent version
ae48f0d

VMware8: remove guest os mappings for 8.0.0.2
746133f

boring-cyborgBot added the component:vmware label Mar 31, 2023

VMware8: fix code smells
4e5dd95

vmware: remove annotations in VmwareVmImplementerTest which caused 0.…
bd093f8
…0% code coverage

harikrishna-patnala approved these changes Apr 13, 2023
View reviewed changes

yadvr approved these changes Apr 13, 2023
View reviewed changes

yadvr added this to the 4.18.1.0 milestone Apr 13, 2023

VMware8: add a unit test case
e13699b

weizhouapache mentioned this pull request Apr 14, 2023
vmware8: update compatibility matrix apache/cloudstack-documentation#309
Merged

VMware: add support for 8.0c (8.0.0.3)
a25b3a3

weizhouapache changed the title ~~VMware: add support for 8.0b (8.0.0.2)~~VMware: add support for 8.0b (8.0.0.2) and 8.0c (8.0.0.3)Apr 17, 2023

weizhouapache self-assigned this Aug 15, 2023

weizhouapache marked this pull request as ready for review August 17, 2023 08:37

weizhouapache merged commit c8d6e50 into apache:4.18Aug 17, 2023

weizhouapache deleted the 4.18.1-add-support-vmware-8.0b branch September 5, 2023 11:03

andrijapanicsb mentioned this pull request Dec 28, 2023
VMware: VM ingestion broken in case of dynamically handled hypervisor/guest OS versions. #8412
Closed

weizhouapache mentioned this pull request Nov 6, 2025
First VM deployment from VMware template fails with VMDK locked; second deployment succeeds #11997
Open

DaanHoogland removed the status:needs-testing label Jan 28, 2026

Uh oh!

Conversation

weizhouapache commented Mar 29, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache commented Mar 29, 2023

Uh oh!

blueorangutan commented Mar 29, 2023

Uh oh!

blueorangutan commented Mar 29, 2023

Uh oh!

weizhouapache commented Mar 31, 2023

Uh oh!

blueorangutan commented Mar 31, 2023

Uh oh!

blueorangutan commented Mar 31, 2023

Uh oh!

codecovBot commented Mar 31, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-advanced-securityAI commented Mar 31, 2023

Uh oh!

blueorangutan commented Apr 5, 2023

Uh oh!

DaanHoogland commented Apr 6, 2023

Uh oh!

blueorangutan commented Apr 6, 2023

Uh oh!

weizhouapache commented Apr 6, 2023

Uh oh!

blueorangutan commented Apr 6, 2023

Uh oh!

blueorangutan commented Apr 6, 2023

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Apr 17, 2023

Uh oh!

blueorangutan commented Apr 18, 2023

Uh oh!

andrijapanicsb commented Aug 14, 2023

Uh oh!

blueorangutan commented Aug 14, 2023

Uh oh!

andrijapanicsb commented Aug 14, 2023

Uh oh!

blueorangutan commented Aug 14, 2023

Uh oh!

blueorangutan commented Aug 15, 2023

Uh oh!

blueorangutan commented Aug 15, 2023

Uh oh!

blueorangutan commented Aug 15, 2023

Uh oh!

blueorangutan commented Aug 15, 2023

Uh oh!

weizhouapache commented Aug 15, 2023

Uh oh!

blueorangutan commented Aug 15, 2023

Uh oh!

weizhouapache commented Aug 15, 2023

Uh oh!

blueorangutan commented Aug 15, 2023

Uh oh!

weizhouapache commented Aug 15, 2023

Uh oh!

blueorangutan commented Aug 15, 2023

Uh oh!

blueorangutan commented Aug 16, 2023

Uh oh!

blueorangutan commented Aug 16, 2023

weizhouapache commented Mar 29, 2023•
edited
Loading

codecovBot commented Mar 31, 2023•
edited
Loading