Skip to content

Fixed the Description coloumn in the UI for Quota traffic page - #7402

Merged
yadvr merged 2 commits into
apache:4.18from
kiranchavala:quotatariff
Apr 6, 2023
Merged

Fixed the Description coloumn in the UI for Quota traffic page#7402
yadvr merged 2 commits into
apache:4.18from
kiranchavala:quotatariff

Conversation

@kiranchavala

Copy link
Copy Markdown
Member

Description

This PR fixes the description column output in the ui for the quota Tariff page

The following PR #5909 changed the response for the quotaTariffList api call

https://cloudstack.apache.org/api/apidocs-4.18/apis/quotaTariffList.html

In 4.17 the response for the quotaTariffList api call contains the "description" feild


<quotatariff>
<usageType>1</usageType>
<usageName>RUNNING_VM</usageName>
<usageUnit>Compute-Month</usageUnit>
<usageDiscriminator/>
<tariffValue>0.00000</tariffValue>
<effectiveDate>2010-05-04T00:00:00+0000</effectiveDate>
<description>Running Vm Usage</description>
<currency>$</currency>
</quotatariff>

Screenshot

quota2

In 4.18 the response for the quotaTariffList api call contains the "usageTypeDescription" field due to that there is no response in the Description coloumn

<quotatariff>
<usageType>1</usageType>
<usageName>RUNNING_VM</usageName>
<usageUnit>Compute*Month</usageUnit>
<usageDiscriminator/>
<tariffValue>0.00000</tariffValue>
<effectiveDate>2010-05-04T00:00:00+0000</effectiveDate>
<usageTypeDescription>Running Vm Usage</usageTypeDescription>
<currency>$</currency>
<name>RUNNING_VM</name>
<uuid>115dca9d-d2a5-11ed-b49d-1e00cd000444</uuid>
</quotatariff>

Screenshot
quota1

Steps to reproduce the issue

  1. Enable the "quota.enable.service)" to true
  2. Restart the management server
  3. Go to UI >Quota > Tariff

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

Tested on the 4.18 docker simulator

Screenshot
quota3

@kiranchavala

Copy link
Copy Markdown
MemberAuthor

Not able to fix the column Name after making the change

Need help to fix the Name to Description

quota4

@shwstppr

Copy link
Copy Markdown
Contributor

Not able to fix the column Name after making the change

Need help to fix the Name to Description

quota4

@kiranchavala add a key in ui/public/locales/en.json,

"label.usageTypeDescription": "Usage description",

@kiranchavala

Copy link
Copy Markdown
MemberAuthor

@shwstppr Thanks it working now

quota4

@kiranchavala

Copy link
Copy Markdown
MemberAuthor

@shwstppr shall i retarget this fix to 4.18 branch ?

@shwstppr

Copy link
Copy Markdown
Contributor

@kiranchavala yes, that would be better since backend changes are there in 4.18

@kiranchavala

Copy link
Copy Markdown
MemberAuthor

@shwstppr Done, can you check if I performed the steps correctly, as it's showing 19 commits

I had done only 2 commits

@codecov

codecovBot commented Apr 5, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7402 (af41207) into 4.18 (9e13042) will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## 4.18 #7402 +/- ##
=========================================
Coverage 12.69% 12.69% Complexity 8661 8661 =========================================
Files 2717 2717 Lines 256165 256165 Branches 39928 39928 =========================================
Hits 32526 32526 Misses 219504 219504 Partials 4135 4135 

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shwstppr

Copy link
Copy Markdown
Contributor

@blueorangutan ui

@blueorangutan

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7402 (QA-JID-76)

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed! Quality Gate passed

BugA0 Bugs
VulnerabilityA0 Vulnerabilities
Security HotspotA0 Security Hotspots
Code SmellA0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-advanced-security

Copy link
Copy Markdown

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@yadvryadvr added this to the 4.18.1.0 milestone Apr 6, 2023
@yadvr
yadvr merged commit 9df1a7b into apache:4.18Apr 6, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@kiranchavala@shwstppr@blueorangutan@github-advanced-security@yadvr