Skip to content

schema: acquired for console_session turned into datetime - #7414

Merged
yadvr merged 6 commits into
apache:mainfrom
shapeblue:improve-consolesession-acquire
Apr 26, 2023
Merged

schema: acquired for console_session turned into datetime#7414
yadvr merged 6 commits into
apache:mainfrom
shapeblue:improve-consolesession-acquire

Conversation

@shwstppr

Copy link
Copy Markdown
Contributor

Description

Fixes#7159

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Fixesapache#7159
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov

codecovBot commented Apr 6, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7414 (60853ec) into main (8a42ab9) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@ Coverage Diff @@## main #7414 +/- ##
============================================
- Coverage 12.70% 12.70% -0.01% 
Complexity 8689 8689 ============================================
Files 2729 2729 Lines 256590 256590 Branches 39991 39991 ============================================
- Hits 32599 32596 -3 - Misses 219846 219849 +3 
Partials 4145 4145 
Impacted FilesCoverage Δ
...a/src/main/java/com/cloud/vm/ConsoleSessionVO.java0.00% <ø> (ø)
...n/java/com/cloud/vm/dao/ConsoleSessionDaoImpl.java0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Comment threadengine/schema/src/main/resources/META-INF/db/schema-41810to41900.sql Outdated
@shwstpprshwstppr changed the title schema: acquire for console_session turned into datetimeschema: acquired for console_session turned into datetimeApr 10, 2023
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5891

@github-actions

Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@yadvr
yadvr requested a review from nvazquezApril 13, 2023 09:47
@yadvryadvr added this to the 4.19.0.0 milestone Apr 13, 2023
@sonarqubecloud

Copy link
Copy Markdown

@weizhouapacheweizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm

@shwstppr
shwstppr marked this pull request as ready for review April 19, 2023 08:08
@yadvr

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5951

@yadvr

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-6462)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43734 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7414-t6462-kvm-centos7.zip
Smoke tests completed. 109 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File

@yadvr
yadvr merged commit 8e7c1f7 into apache:mainApr 26, 2023
@yadvr
yadvr deleted the improve-consolesession-acquire branch April 26, 2023 16:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve the console session acquired field

5 participants

@shwstppr@blueorangutan@yadvr@nvazquez@weizhouapache