engine/schema: fix duplicated guest OSes in 4.18.0.0 by weizhouapache · Pull Request #7799 · apache/cloudstack

weizhouapache · 2023-08-02T00:41:00Z

Description

This PR fixes#7783 and #7781

(Need to merge duplicated guest OSes, and keep only one of them)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

weizhouapache · 2023-08-02T01:13:11Z

@blueorangutan package

blueorangutan · 2023-08-02T01:16:03Z

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-08-02T02:09:54Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6622

codecov · 2023-08-02T02:10:25Z

Codecov Report

Merging #7799 (317045f) into 4.18 (db0e7a6) will decrease coverage by 0.01%.
The diff coverage is 1.75%.

@@ Coverage Diff @@## 4.18 #7799 +/- ##
============================================
- Coverage 13.06% 13.05% -0.01% + Complexity 9084 9083 -1 
============================================
Files 2720 2720 Lines 257289 257370 +81 Branches 40116 40124 +8 ============================================
Hits 33612 33612 - Misses 219455 219537 +82 + Partials 4222 4221 -1

Files Changed	Coverage Δ
...ain/java/com/cloud/storage/dao/GuestOSDaoImpl.java	`14.89% <0.00%> (-21.95%)`	⬇️
...om/cloud/storage/dao/GuestOSHypervisorDaoImpl.java	`34.00% <0.00%> (+0.33%)`	⬆️
...src/main/java/com/cloud/upgrade/GuestOsMapper.java	`17.24% <0.00%> (-6.96%)`	⬇️
...ain/java/com/cloud/hypervisor/guru/VMwareGuru.java	`1.06% <0.00%> (ø)`
server/src/main/java/com/cloud/api/ApiDBUtils.java	`0.17% <0.00%> (ø)`
...src/main/java/com/cloud/api/ApiResponseHelper.java	`4.53% <0.00%> (-0.01%)`	⬇️
...in/java/com/cloud/server/ManagementServerImpl.java	`5.67% <0.00%> (+0.01%)`	⬆️
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java	`31.50% <0.00%> (ø)`
...ava/com/cloud/upgrade/dao/Upgrade41800to41810.java	`2.91% <14.28%> (+0.61%)`	⬆️
...ema/src/main/java/com/cloud/storage/GuestOSVO.java	`14.28% <20.00%> (+1.24%)`	⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

harikrishna-patnala · 2023-08-02T06:59:18Z

+ }
+ guestOsId = getGuestOsId(categoryId, displayName);
+ } else {
+ // TODO: update is_user_defined to false


In my opinion, we better leave the user_defined flag as is to keep track of operator activities.

we can use the user_defined flag to decide which ones to remove and only keep the system defined one. In this case we, will have to allow for the ectra definition to begin with and deduplicate it right away.

In my opinion, we better leave the user_defined flag as is to keep track of operator activities.
If so, user will be able to remove the guest os

How about adding a new guest OS entry if the existing one is user-defined ?
We are anyways deduplicating the list from listGuestOS command starting 4.19 version, we will show only the latest entry if there duplicates. cc @DaanHoogland

@harikrishna-patnala is there another place the deduplication is already taking place (see my pseudo code)?
I do agree we should look at the user defined flag during deduplication. seems like the cleanest way.

@DaanHoogland I'm thinking of not doing any merge operation as it may affect the old entries in older versions as well.
I think the problem here is only that we have duplicate guest OS entries, which is not a critical/major issue.
My proposal is to leave them as is and make fix for future entries.
Regarding the "Red Hat Enterprise Linux 9" and other similar entries, instead of doing a merge operation, I would suggest adding new mapping entries for both the names (RHEL and RHEL9*) so that if the operator uses any of the Guest OSs it won't behave differently while deploying VM (otherwise if the mapping is not found, CS may choose "default").
@weizhouapache @DaanHoogland

github-actions · 2023-08-07T10:33:49Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2023-08-10T12:43:05Z

@blueorangutan package

blueorangutan · 2023-08-10T12:44:03Z

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-08-10T13:43:22Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6739

weizhouapache · 2023-08-11T07:27:28Z

+ GuestOSVO rc = null;
+ for (GuestOSVO guestOSVO: setOfGuestOSes) {
+ if (rc == null || (guestOSVO.getId() > rc.getId() && !guestOSVO.getIsUserDefined())) {
+ rc = guestOSVO;


just return guestOSVO here ?

no, bad pattern to have multiple exit points from a method

ok. you can add a break; then

weizhouapache · 2023-08-11T16:11:05Z

- usage_type = 24 AND usage_display like '% io write';
+ usage_type = 24 AND usage_display like '% io write';
+
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.guest_os', 'display', 'tinyint(1) DEFAULT ''1'' COMMENT ''should this guest_os be shown to the end user'' ');


@DaanHoogland
as we discussed, add this to 4.16.0->4.16.1->4.17.0->4.17.1->4.17.2 as well ?

no, I checked (and will test) the guestosmapper is not yet used in those.

DaanHoogland · 2023-08-14T08:01:18Z

@blueorangutan package

blueorangutan · 2023-08-14T08:02:03Z

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-08-14T09:00:48Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6769

blueorangutan · 2023-08-18T08:22:03Z

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-08-18T09:16:28Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6827

weizhouapache · 2023-08-18T10:24:32Z

@blueorangutan test keepEnv

blueorangutan · 2023-08-18T10:26:03Z

@weizhouapache a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-08-18T11:17:23Z

[SF] Trillian test result (tid-7471)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45682 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7799-t7471-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_upgrade_kubernetes_cluster	`Failure`	519.27	test_kubernetes_clusters.py

blueorangutan · 2023-08-18T23:26:13Z

[SF] Trillian test result (tid-7479)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45312 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7799-t7479-kvm-centos7.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

weizhouapache · 2023-08-21T07:31:28Z

test1: fresh installation with this PR, all looks good

MariaDB [cloud]> select display_name,count(1) as count from guest_os group by display_name having count >1;
+------------------+-------+
| display_name | count |
+------------------+-------+
| Oracle Linux 9 | 2 |
| SCO OpenServer 5 | 2 |
+------------------+-------+
2 rows in set (0.00 sec)
MariaDB [cloud]> MariaDB [cloud]> select * from guest_os join (select display_name,count(1) as count from guest_os group by display_name having count >1) dup where guest_os.display_name = dup.display_name;
+-----+-------------+------+--------------------------------------+------------------+---------------------+---------+-----------------+---------+------------------+-------+
| id | category_id | name | uuid | display_name | created | removed | is_user_defined | display | display_name | count |
+-----+-------------+------+--------------------------------------+------------------+---------------------+---------+-----------------+---------+------------------+-------+
| 85 | 9 | NULL | e37ab646-3db2-11ee-89e3-1e00fe0000fb | SCO OpenServer 5 | 2023-08-18 10:35:25 | NULL | 0 | 1 | SCO OpenServer 5 | 2 |
| 315 | 1 | NULL | f75a059f-3db2-11ee-89e3-1e00fe0000fb | Oracle Linux 9 | 2023-08-18 10:35:35 | NULL | 0 | 1 | Oracle Linux 9 | 2 |
| 329 | 3 | NULL | 68dea665-038b-4437-ae31-54599e892a24 | Oracle Linux 9 | 2023-08-18 10:35:37 | NULL | 0 | 0 | Oracle Linux 9 | 2 |
| 353 | 7 | NULL | 4988ca91-11aa-43e4-91bf-dc1de45265e1 | SCO OpenServer 5 | 2023-08-18 10:35:37 | NULL | 0 | 0 | SCO OpenServer 5 | 2 |
+-----+-------------+------+--------------------------------------+------------------+---------------------+---------+-----------------+---------+------------------+-------+
4 rows in set (0.00 sec)
MariaDB [cloud]> MariaDB [cloud]> select * from guest_os where display_name like "Red Hat Enterprise Linux 9%";
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+---------+
| id | category_id | name | uuid | display_name | created | removed | is_user_defined | display |
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+---------+
| 316 | 1 | NULL | f75a1769-3db2-11ee-89e3-1e00fe0000fb | Red Hat Enterprise Linux 9 | 2023-08-18 10:35:35 | NULL | 0 | 0 |
| 332 | 4 | NULL | be590632-316c-46ea-970c-9569dfd7e732 | Red Hat Enterprise Linux 9.0 | 2023-08-18 10:35:37 | NULL | 0 | 1 |
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+---------+
2 rows in set (0.00 sec)
MariaDB [cloud]> select * from guest_os_hypervisor where guest_os_id in (select id from guest_os where display_name like "Red Hat Enterprise Linux 9");
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| id | hypervisor_type | guest_os_name | guest_os_id | hypervisor_version | uuid | created | removed | is_user_defined |
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| 8584 | KVM | Red Hat Enterprise Linux 9 | 316 | default | f75a1f1e-3db2-11ee-89e3-1e00fe0000fb | 2023-08-18 10:35:35 | NULL | 0 |
| 8588 | VMware | rhel9_64Guest | 316 | 7.0 | f75a62c8-3db2-11ee-89e3-1e00fe0000fb | 2023-08-18 10:35:35 | NULL | 0 |
| 8592 | VMware | rhel9_64Guest | 316 | 7.0.1.0 | f75aa4cc-3db2-11ee-89e3-1e00fe0000fb | 2023-08-18 10:35:35 | NULL | 0 |
| 8596 | VMware | rhel9_64Guest | 316 | 7.0.2.0 | f75ae5aa-3db2-11ee-89e3-1e00fe0000fb | 2023-08-18 10:35:35 | NULL | 0 |
| 8600 | VMware | rhel9_64Guest | 316 | 7.0.3.0 | f75b2753-3db2-11ee-89e3-1e00fe0000fb | 2023-08-18 10:35:35 | NULL | 0 |
| 8827 | VMware | rhel9_64Guest | 316 | 8.0 | f75bafe2-3db2-11ee-89e3-1e00fe0000fb | 2023-08-18 10:35:35 | NULL | 0 |
| 9082 | VMware | rhel9_64Guest | 316 | 8.0.0.1 | f75c73f7-3db2-11ee-89e3-1e00fe0000fb | 2023-08-18 10:35:35 | NULL | 0 |
| 9631 | VMware | rhel9_64Guest | 316 | 8.0.1 | 047a6fc6-4649-4993-9be1-3407adb19d57 | 2023-08-18 10:35:37 | NULL | 0 |
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
8 rows in set (0.00 sec)
MariaDB [cloud]> select * from guest_os_hypervisor where guest_os_id in (select id from guest_os where display_name like "Red Hat Enterprise Linux 9.0");
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| id | hypervisor_type | guest_os_name | guest_os_id | hypervisor_version | uuid | created | removed | is_user_defined |
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| 9138 | VMware | rhel9_64Guest | 332 | 7.0.1.0 | 1d2b9b9d-0fd1-4b56-afa7-fd1ab544bf41 | 2023-08-18 10:35:37 | NULL | 0 |
| 9646 | KVM | Red Hat Enterprise Linux 9 | 332 | default | a179dc2e-2fa8-4d37-b02b-fc4f1c1e7a31 | 2023-08-18 10:35:37 | NULL | 0 |
| 9647 | VMware | rhel9_64Guest | 332 | 7.0 | 250aeb8a-9b28-425e-ad35-febd810ee7c3 | 2023-08-18 10:35:37 | NULL | 0 |
| 9648 | VMware | rhel9_64Guest | 332 | 7.0.2.0 | c5b5703e-9a63-4826-a7d2-d6abe56bad28 | 2023-08-18 10:35:37 | NULL | 0 |
| 9649 | VMware | rhel9_64Guest | 332 | 7.0.3.0 | b4eba39d-55c9-4c46-83e3-f7a31136e64a | 2023-08-18 10:35:37 | NULL | 0 |
| 9650 | VMware | rhel9_64Guest | 332 | 8.0 | 0657753f-1587-40e3-9785-439503ef979a | 2023-08-18 10:35:37 | NULL | 0 |
| 9651 | VMware | rhel9_64Guest | 332 | 8.0.0.1 | fd73ef92-e817-4f91-8963-b3711a7917b7 | 2023-08-18 10:35:37 | NULL | 0 |
| 9652 | VMware | rhel9_64Guest | 332 | 8.0.1 | 7cfdb21e-fbe0-471c-b2f3-6730901073a0 | 2023-08-18 10:35:37 | NULL | 0 |
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
8 rows in set (0.00 sec)

weizhouapache · 2023-08-21T08:08:09Z

test2: upgrade from 4.16.1.1 to 4.18, then to this PR

4.16.1.1, looks ok, only 1 duplicated guest OS

MariaDB [cloud]> select display_name,count(1) as count from guest_os group by display_name having count >1;
+------------------+-------+
| display_name | count |
+------------------+-------+
| SCO OpenServer 5 | 2 |
+------------------+-------+
1 row in set (0.00 sec)
MariaDB [cloud]> select * from guest_os join (select display_name,count(1) as count from guest_os group by display_name having count >1) dup where guest_os.display_name = dup.display_name;
+-----+-------------+------+--------------------------------------+------------------+---------------------+---------+-----------------+------------------+-------+
| id | category_id | name | uuid | display_name | created | removed | is_user_defined | display_name | count |
+-----+-------------+------+--------------------------------------+------------------+---------------------+---------+-----------------+------------------+-------+
| 85 | 9 | NULL | 221980dd-3d9d-11ee-af47-1e001e00011f | SCO OpenServer 5 | 2023-08-18 07:59:36 | NULL | 0 | SCO OpenServer 5 | 2 |
| 324 | 7 | NULL | 916d7fff-4c71-4a8e-9122-e705495a13ce | SCO OpenServer 5 | 2023-08-18 07:59:44 | NULL | 0 | SCO OpenServer 5 | 2 |
+-----+-------------+------+--------------------------------------+------------------+---------------------+---------+-----------------+------------------+-------+
2 rows in set (0.00 sec)
MariaDB [cloud]> MariaDB [cloud]> select * from guest_os where display_name like "Red Hat Enterprise Linux 9%";
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+
| id | category_id | name | uuid | display_name | created | removed | is_user_defined |
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+
| 348 | 4 | NULL | 9458424f-0b9a-4abe-8119-b91b7c705fb1 | Red Hat Enterprise Linux 9.0 | 2023-08-18 07:59:44 | NULL | 0 |
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+
1 row in set (0.00 sec)

upgrade to 4.18, 43 duplicated guest OSes

MariaDB [cloud]> select display_name,count(1) as count from guest_os group by display_name having count >1;
+-----------------------------------------------+-------+
| display_name | count |
+-----------------------------------------------+-------+
| Amazon Linux 2 (64 bit) | 2 |
| Amazon Linux 3 (64 bit) | 2 |
| Asianux Server 4 (32 bit) | 2 |
| Asianux Server 4 (64 bit) | 2 |
| Asianux Server 5 (32 bit) | 2 |
| Asianux Server 5 (64 bit) | 2 |
| Asianux Server 7 (32 bit) | 2 |
| Asianux Server 7 (64 bit) | 2 |
| Asianux Server 8 (64 bit) | 2 |
| Asianux Server 9 (64 bit) | 2 |
| CentOS 9 | 2 |
| Debian GNU/Linux 11 (32-bit) | 2 |
| Debian GNU/Linux 11 (64-bit) | 2 |
| eComStation 2.0 | 2 |
| Fedora Linux (64 bit) | 2 |
| FreeBSD 13 (32-bit) | 2 |
| FreeBSD 13 (64-bit) | 2 |
| Linux 3.x Kernel (32 bit) | 2 |
| Linux 3.x Kernel (64 bit) | 2 |
| Linux 5.x Kernel (32-bit) | 2 |
| Linux 5.x Kernel (64-bit) | 2 |
| macOS 10.13 (64 bit) | 2 |
| macOS 10.14 (64 bit) | 2 |
| macOS 10.15 (64 bit) | 2 |
| macOS 11 (64 bit) | 2 |
| Mandrake Linux | 2 |
| Mandriva Linux (64 bit) | 2 |
| NeoKylin Linux Server 7 | 2 |
| OpenSUSE Linux (32 bit) | 2 |
| OpenSUSE Linux (64 bit) | 2 |
| Oracle Linux 9 | 3 |
| OVF Configured OS | 2 |
| Red Hat Enterprise Linux 9.0 | 2 |
| Scientific Linux 7 | 2 |
| SCO OpenServer 5 | 3 |
| SCO OpenServer 6 | 2 |
| Solaris 11 (64 bit) | 2 |
| SUSE Linux Enterprise Desktop 12 SP3 (64-bit) | 2 |
| SUSE Linux Enterprise Desktop 12 SP4 (64-bit) | 2 |
| SUSE Linux Enterprise Server 12 SP4 (64-bit) | 2 |
| SUSE Linux Enterprise Server 16 (64-bit) | 2 |
| Ubuntu 20.04 LTS | 2 |
| VMware Photon (64 bit) | 2 |
+-----------------------------------------------+-------+
43 rows in set (0.01 sec)

the RHEL 9 issue also exist

MariaDB [cloud]> select * from guest_os where display_name like "Red Hat Enterprise Linux 9%";
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+
| id | category_id | name | uuid | display_name | created | removed | is_user_defined |
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+
| 348 | 4 | NULL | 9458424f-0b9a-4abe-8119-b91b7c705fb1 | Red Hat Enterprise Linux 9.0 | 2023-08-18 07:59:44 | NULL | 0 |
| 357 | 1 | NULL | 05a1e5a6-3ff8-11ee-af47-1e001e00011f | Red Hat Enterprise Linux 9 | 2023-08-21 07:54:57 | NULL | 0 |
| 377 | 4 | NULL | c5c314e4-5da2-4b72-927f-21fb35c8276a | Red Hat Enterprise Linux 9.0 | 2023-08-21 07:54:59 | NULL | 0 |
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+
3 rows in set (0.00 sec)

upgrade to this PR, looks ok (only 1 of duplications has display=1, which has all the guest os mappings of other duplications)

MariaDB [cloud]> select * from guest_os join (select display_name,count(1) as count from guest_os group by display_name having count >1) dup where guest_os.display_name = dup.display_name and display=1;
+-----+-------------+------+--------------------------------------+-----------------------------------------------+---------------------+---------+-----------------+---------+-----------------------------------------------+-------+
| id | category_id | name | uuid | display_name | created | removed | is_user_defined | display | display_name | count |
+-----+-------------+------+--------------------------------------+-----------------------------------------------+---------------------+---------+-----------------+---------+-----------------------------------------------+-------+
| 85 | 9 | NULL | 221980dd-3d9d-11ee-af47-1e001e00011f | SCO OpenServer 5 | 2023-08-18 07:59:36 | NULL | 0 | 1 | SCO OpenServer 5 | 3 |
| 305 | 11 | NULL | 0bc2fefa-7a5a-4926-b34d-8acdae172201 | OVF Configured OS | 2023-08-18 07:59:44 | NULL | 0 | 1 | OVF Configured OS | 2 |
| 307 | 2 | NULL | ebffba86-cd83-41c5-aafe-44138d677f37 | Linux 3.x Kernel (32 bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | Linux 3.x Kernel (32 bit) | 2 |
| 308 | 7 | NULL | fd352fb9-3dd9-4f97-8d46-1c879670dcce | Amazon Linux 2 (64 bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | Amazon Linux 2 (64 bit) | 2 |
| 310 | 7 | NULL | 88a61592-ed97-46b6-9d29-e0fd543acb1a | Asianux Server 4 (64 bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | Asianux Server 4 (64 bit) | 2 |
| 311 | 7 | NULL | c1a96eda-b0ba-4e43-86de-95b47194b814 | Asianux Server 5 (32 bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | Asianux Server 5 (32 bit) | 2 |
| 313 | 7 | NULL | 68ca7cd1-350b-4e57-a97b-93538a0b343a | Asianux Server 7 (32 bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | Asianux Server 7 (32 bit) | 2 |
| 314 | 7 | NULL | 7f67f35b-9b46-4997-8642-2241e74c110d | Asianux Server 7 (64 bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | Asianux Server 7 (64 bit) | 2 |
| 316 | 7 | NULL | ee6cd74c-814a-447e-b73c-5ee39736f3f4 | eComStation 2.0 | 2023-08-18 07:59:44 | NULL | 0 | 1 | eComStation 2.0 | 2 |
| 318 | 7 | NULL | b4bbae23-be50-45e2-ba80-07c7d6a60a58 | macOS 10.14 (64 bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | macOS 10.14 (64 bit) | 2 |
| 322 | 7 | NULL | b6458b04-7304-4f5a-841c-40c2d273cc41 | Mandriva Linux (64 bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | Mandriva Linux (64 bit) | 2 |
| 325 | 7 | NULL | 9044236c-4ac8-4217-b856-5b88b7789870 | SCO OpenServer 6 | 2023-08-18 07:59:44 | NULL | 0 | 1 | SCO OpenServer 6 | 2 |
| 326 | 7 | NULL | 71c7a8f9-6880-49b0-a293-e864a3e5084d | OpenSUSE Linux (64 bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | OpenSUSE Linux (64 bit) | 2 |
| 327 | 7 | NULL | 72f19dc8-0c18-49a4-911c-742fcfa17b2b | OpenSUSE Linux (32 bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | OpenSUSE Linux (32 bit) | 2 |
| 331 | 5 | NULL | fe0d744a-421c-4ce7-a3c1-cef3400ba0a8 | SUSE Linux Enterprise Desktop 12 SP4 (64-bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | SUSE Linux Enterprise Desktop 12 SP4 (64-bit) | 2 |
| 332 | 5 | NULL | 25f8ac9c-3c58-44a8-a4fc-3182544594e5 | SUSE Linux Enterprise Server 12 SP4 (64-bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | SUSE Linux Enterprise Server 12 SP4 (64-bit) | 2 |
| 334 | 9 | NULL | 366dc6ea-db79-4b5f-a9a0-1086aa359ac0 | NeoKylin Linux Server 7 | 2023-08-18 07:59:44 | NULL | 0 | 1 | NeoKylin Linux Server 7 | 2 |
| 336 | 7 | NULL | b513396d-37df-4374-a775-e78918f8789e | macOS 10.15 (64 bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | macOS 10.15 (64 bit) | 2 |
| 337 | 2 | NULL | 36bc3d0e-5e83-4774-9089-bbf5d4d60056 | Debian GNU/Linux 11 (64-bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | Debian GNU/Linux 11 (64-bit) | 2 |
| 340 | 7 | NULL | af0c0f2f-fc62-4f42-aa86-9a9cdac14756 | Asianux Server 9 (64 bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | Asianux Server 9 (64 bit) | 2 |
| 341 | 1 | NULL | 88de984a-677e-48a3-9bdb-42f541cc7c0d | CentOS 9 | 2023-08-18 07:59:44 | NULL | 0 | 1 | CentOS 9 | 2 |
| 343 | 9 | NULL | 200d1ad2-9e5f-4ee2-a3ee-88b790377700 | FreeBSD 13 (64-bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | FreeBSD 13 (64-bit) | 2 |
| 347 | 2 | NULL | edf33a5a-b36c-4863-a3d9-68770c4e5ac0 | Linux 5.x Kernel (32-bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | Linux 5.x Kernel (32-bit) | 2 |
| 349 | 5 | NULL | 3f128ad6-1aec-4f82-9e11-f8ad23ce7c11 | SUSE Linux Enterprise Server 16 (64-bit) | 2023-08-18 07:59:44 | NULL | 0 | 1 | SUSE Linux Enterprise Server 16 (64-bit) | 2 |
| 356 | 1 | NULL | 05a19dc1-3ff8-11ee-af47-1e001e00011f | Oracle Linux 9 | 2023-08-21 07:54:57 | NULL | 0 | 1 | Oracle Linux 9 | 3 |
| 359 | 5 | NULL | 75a4607f-7491-4a3a-8b6c-e21794e5927b | SUSE Linux Enterprise Desktop 12 SP3 (64-bit) | 2023-08-21 07:54:58 | NULL | 0 | 1 | SUSE Linux Enterprise Desktop 12 SP3 (64-bit) | 2 |
| 362 | 9 | NULL | fe13d4de-d9dd-4b2c-8be4-937a94a5da64 | Scientific Linux 7 | 2023-08-21 07:54:59 | NULL | 0 | 1 | Scientific Linux 7 | 2 |
| 364 | 10 | NULL | 6c757299-eb8c-42b5-b51b-cd74f8d1cfc2 | Ubuntu 20.04 LTS | 2023-08-21 07:54:59 | NULL | 0 | 1 | Ubuntu 20.04 LTS | 2 |
| 367 | 2 | NULL | 42429e68-bad2-44dc-9b78-207161bcb538 | Debian GNU/Linux 11 (32-bit) | 2023-08-21 07:54:59 | NULL | 0 | 1 | Debian GNU/Linux 11 (32-bit) | 2 |
| 368 | 7 | NULL | 03947e9b-f56d-48b8-a0e8-634cc267d391 | Amazon Linux 3 (64 bit) | 2023-08-21 07:54:59 | NULL | 0 | 1 | Amazon Linux 3 (64 bit) | 2 |
| 371 | 7 | NULL | 9d30f036-d023-471b-886a-e3b01fc261a3 | macOS 11 (64 bit) | 2023-08-21 07:54:59 | NULL | 0 | 1 | macOS 11 (64 bit) | 2 |
| 373 | 9 | NULL | dd4c2b9e-894a-4932-9ffc-b1ec749e3e41 | FreeBSD 13 (32-bit) | 2023-08-21 07:54:59 | NULL | 0 | 1 | FreeBSD 13 (32-bit) | 2 |
| 375 | 2 | NULL | 09653b9e-f6fa-4658-8330-cc870f61b245 | Linux 5.x Kernel (64-bit) | 2023-08-21 07:54:59 | NULL | 0 | 1 | Linux 5.x Kernel (64-bit) | 2 |
| 377 | 4 | NULL | c5c314e4-5da2-4b72-927f-21fb35c8276a | Red Hat Enterprise Linux 9.0 | 2023-08-21 07:54:59 | NULL | 0 | 1 | Red Hat Enterprise Linux 9.0 | 2 |
| 380 | 2 | NULL | 9c7b9808-e673-4303-a5a0-473aac98739b | Linux 3.x Kernel (64 bit) | 2023-08-21 07:54:59 | NULL | 0 | 1 | Linux 3.x Kernel (64 bit) | 2 |
| 383 | 7 | NULL | 6ce50259-0ac3-412d-a8ec-ecc869c40f9e | Asianux Server 4 (32 bit) | 2023-08-21 07:54:59 | NULL | 0 | 1 | Asianux Server 4 (32 bit) | 2 |
| 386 | 7 | NULL | fee0669e-b2b6-4f89-acda-727405809c95 | Asianux Server 5 (64 bit) | 2023-08-21 07:54:59 | NULL | 0 | 1 | Asianux Server 5 (64 bit) | 2 |
| 389 | 7 | NULL | c38bb854-bc4e-489f-909f-4816d7a6da95 | Asianux Server 8 (64 bit) | 2023-08-21 07:54:59 | NULL | 0 | 1 | Asianux Server 8 (64 bit) | 2 |
| 391 | 7 | NULL | 22bf5465-5341-4dde-91d0-f65204e02af4 | macOS 10.13 (64 bit) | 2023-08-21 07:54:59 | NULL | 0 | 1 | macOS 10.13 (64 bit) | 2 |
| 393 | 7 | NULL | 347a1787-35e8-483c-af45-ae72ab7c8a6b | Fedora Linux (64 bit) | 2023-08-21 07:54:59 | NULL | 0 | 1 | Fedora Linux (64 bit) | 2 |
| 395 | 7 | NULL | 7a08d54d-1bf2-43a8-aa2d-24da3b2ae8bf | Mandrake Linux | 2023-08-21 07:54:59 | NULL | 0 | 1 | Mandrake Linux | 2 |
| 402 | 7 | NULL | 8c05e3e9-1226-487f-9c0c-5bcfbaaa1dce | Solaris 11 (64 bit) | 2023-08-21 07:54:59 | NULL | 0 | 1 | Solaris 11 (64 bit) | 2 |
| 403 | 7 | NULL | 445ed80a-2eb3-46ad-9fb2-474aa45495d5 | VMware Photon (64 bit) | 2023-08-21 07:54:59 | NULL | 0 | 1 | VMware Photon (64 bit) | 2 |
+-----+-------------+------+--------------------------------------+-----------------------------------------------+---------------------+---------+-----------------+---------+-----------------------------------------------+-------+
43 rows in set (0.00 sec)
MariaDB [cloud]> select * from guest_os where display_name like "Red Hat Enterprise Linux 9%";
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+---------+
| id | category_id | name | uuid | display_name | created | removed | is_user_defined | display |
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+---------+
| 348 | 4 | NULL | 9458424f-0b9a-4abe-8119-b91b7c705fb1 | Red Hat Enterprise Linux 9.0 | 2023-08-18 07:59:44 | NULL | 0 | 0 |
| 357 | 1 | NULL | 05a1e5a6-3ff8-11ee-af47-1e001e00011f | Red Hat Enterprise Linux 9 | 2023-08-21 07:54:57 | NULL | 0 | 0 |
| 377 | 4 | NULL | c5c314e4-5da2-4b72-927f-21fb35c8276a | Red Hat Enterprise Linux 9.0 | 2023-08-21 07:54:59 | NULL | 0 | 1 |
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+---------+
3 rows in set (0.00 sec)
MariaDB [cloud]> select * from guest_os_hypervisor where guest_os_id in (select id from guest_os where display_name like "Red Hat Enterprise Linux 9");
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| id | hypervisor_type | guest_os_name | guest_os_id | hypervisor_version | uuid | created | removed | is_user_defined |
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| 8590 | KVM | Red Hat Enterprise Linux 9 | 357 | default | 05a1ee87-3ff8-11ee-af47-1e001e00011f | 2023-08-21 07:54:57 | NULL | 0 |
| 8594 | VMware | rhel9_64Guest | 357 | 7.0 | 05a2529a-3ff8-11ee-af47-1e001e00011f | 2023-08-21 07:54:57 | NULL | 0 |
| 8598 | VMware | rhel9_64Guest | 357 | 7.0.1.0 | 05a2f226-3ff8-11ee-af47-1e001e00011f | 2023-08-21 07:54:57 | NULL | 0 |
| 8602 | VMware | rhel9_64Guest | 357 | 7.0.2.0 | 05a372e3-3ff8-11ee-af47-1e001e00011f | 2023-08-21 07:54:57 | NULL | 0 |
| 8606 | VMware | rhel9_64Guest | 357 | 7.0.3.0 | 05a4299c-3ff8-11ee-af47-1e001e00011f | 2023-08-21 07:54:57 | NULL | 0 |
| 8834 | VMware | rhel9_64Guest | 357 | 8.0 | 05a53053-3ff8-11ee-af47-1e001e00011f | 2023-08-21 07:54:57 | NULL | 0 |
| 9089 | VMware | rhel9_64Guest | 357 | 8.0.0.1 | 05a64903-3ff8-11ee-af47-1e001e00011f | 2023-08-21 07:54:57 | NULL | 0 |
| 9638 | VMware | rhel9_64Guest | 357 | 8.0.1 | 6db6c79e-43e5-4d82-b412-2b9ecd3fea2d | 2023-08-21 08:04:58 | NULL | 0 |
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
8 rows in set (0.00 sec)
MariaDB [cloud]> select * from guest_os_hypervisor where guest_os_id in (select id from guest_os where display_name like "Red Hat Enterprise Linux 9.0");
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| id | hypervisor_type | guest_os_name | guest_os_id | hypervisor_version | uuid | created | removed | is_user_defined |
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| 9776 | KVM | Red Hat Enterprise Linux 9 | 348 | default | b62fd70c-019c-445c-865b-40c17895501b | 2023-08-21 08:04:59 | NULL | 0 |
| 9777 | VMware | rhel9_64Guest | 348 | 7.0 | 636e53e6-66a3-4568-ac95-1ae2ce364841 | 2023-08-21 08:04:59 | NULL | 0 |
| 9778 | VMware | rhel9_64Guest | 348 | 7.0.1.0 | 9cf341ca-063e-40c3-ad47-92f044642c78 | 2023-08-21 08:04:59 | NULL | 0 |
| 9779 | VMware | rhel9_64Guest | 348 | 7.0.2.0 | 636ee96e-bda4-4dfe-9317-a308cf4b2131 | 2023-08-21 08:04:59 | NULL | 0 |
| 9780 | VMware | rhel9_64Guest | 348 | 7.0.3.0 | 48a54aa1-3662-4709-94da-350642c27d01 | 2023-08-21 08:04:59 | NULL | 0 |
| 9781 | VMware | rhel9_64Guest | 348 | 8.0 | 731ad32f-df0c-43ba-8b7e-1b5d909219f8 | 2023-08-21 08:04:59 | NULL | 0 |
| 9782 | VMware | rhel9_64Guest | 348 | 8.0.0.1 | ab30dfdd-908c-456b-bebc-0ab3a4364148 | 2023-08-21 08:04:59 | NULL | 0 |
| 9783 | VMware | rhel9_64Guest | 348 | 8.0.1 | b4ddf210-11a9-49d1-afa1-4c2f3cb3987a | 2023-08-21 08:04:59 | NULL | 0 |
| 9144 | VMware | rhel9_64Guest | 377 | 7.0.1.0 | a4b5f7f0-8a29-4cb7-9f98-457282d8d5da | 2023-08-21 07:54:59 | NULL | 0 |
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
9 rows in set (0.00 sec)
MariaDB [cloud]> MariaDB [cloud]> select * from guest_os_hypervisor where guest_os_id in (select id from guest_os where display_name like "Ubuntu 20.04 LTS" and display=1);
+------+-----------------+--------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| id | hypervisor_type | guest_os_name | guest_os_id | hypervisor_version | uuid | created | removed | is_user_defined |
+------+-----------------+--------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| 9129 | Xenserver | Ubuntu Focal Fossa 20.04 | 364 | 8.2.0 | a5e42d13-290e-47d3-8325-4cb8cf08d335 | 2023-08-21 07:54:59 | NULL | 0 |
| 9381 | VMware | ubuntu64Guest | 364 | 6.5 | 79944b11-0a6f-4f94-91d1-6fd5a476fd8a | 2023-08-21 08:04:57 | NULL | 0 |
| 9382 | VMware | ubuntu64Guest | 364 | 6.7 | 8a08b735-850d-4a03-b328-1cdbedca5579 | 2023-08-21 08:04:57 | NULL | 0 |
| 9383 | VMware | ubuntu64Guest | 364 | 6.7.1 | 021af9c9-3315-4ded-a480-3f868b7a30b3 | 2023-08-21 08:04:57 | NULL | 0 |
| 9384 | VMware | ubuntu64Guest | 364 | 6.7.2 | 389b791b-9203-4ae7-838a-664ebe96686f | 2023-08-21 08:04:57 | NULL | 0 |
| 9385 | VMware | ubuntu64Guest | 364 | 6.7.3 | cb5cf938-4db6-4ec6-9ca4-90ba551fce43 | 2023-08-21 08:04:57 | NULL | 0 |
| 9386 | VMware | ubuntu64Guest | 364 | 7.0 | 858d1865-012b-4c69-afad-dbce831a6b38 | 2023-08-21 08:04:57 | NULL | 0 |
| 9387 | VMware | ubuntu64Guest | 364 | 7.0.1.0 | 008f4bb7-eb8c-460e-a36d-f647b6ed7eb9 | 2023-08-21 08:04:57 | NULL | 0 |
| 9388 | VMware | ubuntu64Guest | 364 | 7.0.2.0 | 8865f272-19aa-4f15-b493-26a501e1d497 | 2023-08-21 08:04:57 | NULL | 0 |
| 9389 | VMware | ubuntu64Guest | 364 | 7.0.3.0 | 42b1b50a-1d28-4a10-b59d-34ac2decd4f4 | 2023-08-21 08:04:57 | NULL | 0 |
| 9390 | VMware | ubuntu64Guest | 364 | 8.0 | d6d3f917-793f-464d-8540-04737a2940fe | 2023-08-21 08:04:57 | NULL | 0 |
| 9641 | VMware | ubuntu64Guest | 364 | 8.0.1 | 26f3a929-00c0-42b7-8c7d-f8bd14ef14f7 | 2023-08-21 08:04:58 | NULL | 0 |
| 9742 | KVM | Ubuntu 20.04 LTS | 364 | default | aa0aaf44-c676-4701-8d28-36c6ea187d3e | 2023-08-21 08:04:59 | NULL | 0 |
+------+-----------------+--------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
13 rows in set (0.00 sec)

weizhouapache · 2023-08-21T08:10:37Z

test3:
upgrade from 4.18 to this PR

4.18, 6 duplicated guest OSes, RHEL issue exist

MariaDB [cloud]> select display_name,count(1) as count from guest_os group by display_name having count >1;
+------------------------------+-------+
| display_name | count |
+------------------------------+-------+
| CentOS 9 | 2 |
| Debian GNU/Linux 11 (32-bit) | 2 |
| Debian GNU/Linux 11 (64-bit) | 2 |
| Oracle Linux 9 | 2 |
| SCO OpenServer 5 | 2 |
| Ubuntu 20.04 LTS | 2 |
+------------------------------+-------+
6 rows in set (0.01 sec)
MariaDB [cloud]> select * from guest_os join (select display_name,count(1) as count from guest_os group by display_name having count >1) dup where guest_os.display_name = dup.display_name;
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+------------------------------+-------+
| id | category_id | name | uuid | display_name | created | removed | is_user_defined | display_name | count |
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+------------------------------+-------+
| 85 | 9 | NULL | 6ad2fab8-3da1-11ee-aef3-1e004c000468 | SCO OpenServer 5 | 2023-08-18 08:30:17 | NULL | 0 | SCO OpenServer 5 | 2 |
| 305 | 10 | NULL | 7ae9a5a8-3da1-11ee-aef3-1e004c000468 | Ubuntu 20.04 LTS | 2023-08-18 08:30:25 | NULL | 0 | Ubuntu 20.04 LTS | 2 |
| 311 | 2 | NULL | 7b9ce2c8-3da1-11ee-aef3-1e004c000468 | Debian GNU/Linux 11 (64-bit) | 2023-08-18 08:30:26 | NULL | 0 | Debian GNU/Linux 11 (64-bit) | 2 |
| 312 | 2 | NULL | 7b9cfc5e-3da1-11ee-aef3-1e004c000468 | Debian GNU/Linux 11 (32-bit) | 2023-08-18 08:30:26 | NULL | 0 | Debian GNU/Linux 11 (32-bit) | 2 |
| 314 | 1 | NULL | 7ba926e2-3da1-11ee-aef3-1e004c000468 | CentOS 9 | 2023-08-18 08:30:26 | NULL | 0 | CentOS 9 | 2 |
| 315 | 1 | NULL | 7ba93b0d-3da1-11ee-aef3-1e004c000468 | Oracle Linux 9 | 2023-08-18 08:30:26 | NULL | 0 | Oracle Linux 9 | 2 |
| 323 | 10 | NULL | 9683f899-208c-416d-a4e9-297354da87d0 | Ubuntu 20.04 LTS | 2023-08-18 08:30:28 | NULL | 0 | Ubuntu 20.04 LTS | 2 |
| 325 | 2 | NULL | adaac3eb-cadc-43db-a4b9-ca415c044f0e | Debian GNU/Linux 11 (64-bit) | 2023-08-18 08:30:28 | NULL | 0 | Debian GNU/Linux 11 (64-bit) | 2 |
| 326 | 2 | NULL | 1419f866-af34-4766-9222-3a2b0aab67ac | Debian GNU/Linux 11 (32-bit) | 2023-08-18 08:30:28 | NULL | 0 | Debian GNU/Linux 11 (32-bit) | 2 |
| 329 | 1 | NULL | 599426db-b379-4464-854c-d17db3e40cfc | CentOS 9 | 2023-08-18 08:30:28 | NULL | 0 | CentOS 9 | 2 |
| 333 | 3 | NULL | c69de706-3dc8-434c-bc73-b9dbf6023cc7 | Oracle Linux 9 | 2023-08-18 08:30:28 | NULL | 0 | Oracle Linux 9 | 2 |
| 357 | 7 | NULL | 218dc79f-71b2-40f0-8648-d6853320f1f2 | SCO OpenServer 5 | 2023-08-18 08:30:28 | NULL | 0 | SCO OpenServer 5 | 2 |
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+------------------------------+-------+
12 rows in set (0.00 sec)
MariaDB [cloud]> MariaDB [cloud]> select * from guest_os where display_name like "Red Hat Enterprise Linux 9%";
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+
| id | category_id | name | uuid | display_name | created | removed | is_user_defined |
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+
| 316 | 1 | NULL | 7ba94fb7-3da1-11ee-aef3-1e004c000468 | Red Hat Enterprise Linux 9 | 2023-08-18 08:30:26 | NULL | 0 |
| 336 | 4 | NULL | 3f787f7a-203c-4196-8b2d-cddcf50e8874 | Red Hat Enterprise Linux 9.0 | 2023-08-18 08:30:28 | NULL | 0 |
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+
2 rows in set (0.00 sec)
MariaDB [cloud]> select * from guest_os_hypervisor where guest_os_id in (select id from guest_os where display_name like "Red Hat Enterprise Linux 9");
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| id | hypervisor_type | guest_os_name | guest_os_id | hypervisor_version | uuid | created | removed | is_user_defined |
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| 8584 | KVM | Red Hat Enterprise Linux 9 | 316 | default | 7ba95720-3da1-11ee-aef3-1e004c000468 | 2023-08-18 08:30:26 | NULL | 0 |
| 8588 | VMware | rhel9_64Guest, | 316 | 7.0 | 7ba99deb-3da1-11ee-aef3-1e004c000468 | 2023-08-18 08:30:26 | NULL | 0 |
| 8592 | VMware | rhel9_64Guest, | 316 | 7.0.1.0 | 7ba9e8c6-3da1-11ee-aef3-1e004c000468 | 2023-08-18 08:30:26 | NULL | 0 |
| 8596 | VMware | rhel9_64Guest, | 316 | 7.0.2.0 | 7baa2d84-3da1-11ee-aef3-1e004c000468 | 2023-08-18 08:30:26 | NULL | 0 |
| 8600 | VMware | rhel9_64Guest, | 316 | 7.0.3.0 | 7baa742c-3da1-11ee-aef3-1e004c000468 | 2023-08-18 08:30:26 | NULL | 0 |
| 8827 | VMware | rhel9_64Guest, | 316 | 8.0 | 7bab0348-3da1-11ee-aef3-1e004c000468 | 2023-08-18 08:30:26 | NULL | 0 |
| 9082 | VMware | rhel9_64Guest, | 316 | 8.0.0.1 | 7babb6c7-3da1-11ee-aef3-1e004c000468 | 2023-08-18 08:30:26 | NULL | 0 |
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
7 rows in set (0.00 sec)
MariaDB [cloud]> select * from guest_os_hypervisor where guest_os_id in (select id from guest_os where display_name like "Red Hat Enterprise Linux 9.0");
+------+-----------------+---------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| id | hypervisor_type | guest_os_name | guest_os_id | hypervisor_version | uuid | created | removed | is_user_defined |
+------+-----------------+---------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| 9138 | VMware | rhel9_64Guest | 336 | 7.0.1.0 | 97530a3d-7ae7-4bf9-896d-e6223efb4385 | 2023-08-18 08:30:28 | NULL | 0 |
+------+-----------------+---------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
1 row in set (0.00 sec)

upgrade to this PR, all look good

MariaDB [cloud]> select display_name,count(1) as count from guest_os group by display_name having count >1;
+------------------------------+-------+
| display_name | count |
+------------------------------+-------+
| CentOS 9 | 2 |
| Debian GNU/Linux 11 (32-bit) | 2 |
| Debian GNU/Linux 11 (64-bit) | 2 |
| Oracle Linux 9 | 2 |
| SCO OpenServer 5 | 2 |
| Ubuntu 20.04 LTS | 2 |
+------------------------------+-------+
6 rows in set (0.00 sec)
MariaDB [cloud]> select * from guest_os join (select display_name,count(1) as count from guest_os group by display_name having count >1) dup where guest_os.display_name = dup.display_name;
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+---------+------------------------------+-------+
| id | category_id | name | uuid | display_name | created | removed | is_user_defined | display | display_name | count |
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+---------+------------------------------+-------+
| 85 | 9 | NULL | 6ad2fab8-3da1-11ee-aef3-1e004c000468 | SCO OpenServer 5 | 2023-08-18 08:30:17 | NULL | 0 | 1 | SCO OpenServer 5 | 2 |
| 305 | 10 | NULL | 7ae9a5a8-3da1-11ee-aef3-1e004c000468 | Ubuntu 20.04 LTS | 2023-08-18 08:30:25 | NULL | 0 | 0 | Ubuntu 20.04 LTS | 2 |
| 311 | 2 | NULL | 7b9ce2c8-3da1-11ee-aef3-1e004c000468 | Debian GNU/Linux 11 (64-bit) | 2023-08-18 08:30:26 | NULL | 0 | 0 | Debian GNU/Linux 11 (64-bit) | 2 |
| 312 | 2 | NULL | 7b9cfc5e-3da1-11ee-aef3-1e004c000468 | Debian GNU/Linux 11 (32-bit) | 2023-08-18 08:30:26 | NULL | 0 | 1 | Debian GNU/Linux 11 (32-bit) | 2 |
| 314 | 1 | NULL | 7ba926e2-3da1-11ee-aef3-1e004c000468 | CentOS 9 | 2023-08-18 08:30:26 | NULL | 0 | 1 | CentOS 9 | 2 |
| 315 | 1 | NULL | 7ba93b0d-3da1-11ee-aef3-1e004c000468 | Oracle Linux 9 | 2023-08-18 08:30:26 | NULL | 0 | 0 | Oracle Linux 9 | 2 |
| 323 | 10 | NULL | 9683f899-208c-416d-a4e9-297354da87d0 | Ubuntu 20.04 LTS | 2023-08-18 08:30:28 | NULL | 0 | 1 | Ubuntu 20.04 LTS | 2 |
| 325 | 2 | NULL | adaac3eb-cadc-43db-a4b9-ca415c044f0e | Debian GNU/Linux 11 (64-bit) | 2023-08-18 08:30:28 | NULL | 0 | 1 | Debian GNU/Linux 11 (64-bit) | 2 |
| 326 | 2 | NULL | 1419f866-af34-4766-9222-3a2b0aab67ac | Debian GNU/Linux 11 (32-bit) | 2023-08-18 08:30:28 | NULL | 0 | 0 | Debian GNU/Linux 11 (32-bit) | 2 |
| 329 | 1 | NULL | 599426db-b379-4464-854c-d17db3e40cfc | CentOS 9 | 2023-08-18 08:30:28 | NULL | 0 | 0 | CentOS 9 | 2 |
| 333 | 3 | NULL | c69de706-3dc8-434c-bc73-b9dbf6023cc7 | Oracle Linux 9 | 2023-08-18 08:30:28 | NULL | 0 | 1 | Oracle Linux 9 | 2 |
| 357 | 7 | NULL | 218dc79f-71b2-40f0-8648-d6853320f1f2 | SCO OpenServer 5 | 2023-08-18 08:30:28 | NULL | 0 | 0 | SCO OpenServer 5 | 2 |
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+---------+------------------------------+-------+
12 rows in set (0.00 sec)
MariaDB [cloud]> MariaDB [cloud]> select * from guest_os where display_name like "Red Hat Enterprise Linux 9%";
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+---------+
| id | category_id | name | uuid | display_name | created | removed | is_user_defined | display |
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+---------+
| 316 | 1 | NULL | 7ba94fb7-3da1-11ee-aef3-1e004c000468 | Red Hat Enterprise Linux 9 | 2023-08-18 08:30:26 | NULL | 0 | 0 |
| 336 | 4 | NULL | 3f787f7a-203c-4196-8b2d-cddcf50e8874 | Red Hat Enterprise Linux 9.0 | 2023-08-18 08:30:28 | NULL | 0 | 1 |
+-----+-------------+------+--------------------------------------+------------------------------+---------------------+---------+-----------------+---------+
2 rows in set (0.00 sec)
MariaDB [cloud]> select * from guest_os_hypervisor where guest_os_id in (select id from guest_os where display_name like "Red Hat Enterprise Linux 9");
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| id | hypervisor_type | guest_os_name | guest_os_id | hypervisor_version | uuid | created | removed | is_user_defined |
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| 8584 | KVM | Red Hat Enterprise Linux 9 | 316 | default | 7ba95720-3da1-11ee-aef3-1e004c000468 | 2023-08-18 08:30:26 | NULL | 0 |
| 8588 | VMware | rhel9_64Guest | 316 | 7.0 | 7ba99deb-3da1-11ee-aef3-1e004c000468 | 2023-08-18 08:30:26 | NULL | 0 |
| 8592 | VMware | rhel9_64Guest | 316 | 7.0.1.0 | 7ba9e8c6-3da1-11ee-aef3-1e004c000468 | 2023-08-18 08:30:26 | NULL | 0 |
| 8596 | VMware | rhel9_64Guest | 316 | 7.0.2.0 | 7baa2d84-3da1-11ee-aef3-1e004c000468 | 2023-08-18 08:30:26 | NULL | 0 |
| 8600 | VMware | rhel9_64Guest | 316 | 7.0.3.0 | 7baa742c-3da1-11ee-aef3-1e004c000468 | 2023-08-18 08:30:26 | NULL | 0 |
| 8827 | VMware | rhel9_64Guest | 316 | 8.0 | 7bab0348-3da1-11ee-aef3-1e004c000468 | 2023-08-18 08:30:26 | NULL | 0 |
| 9082 | VMware | rhel9_64Guest | 316 | 8.0.0.1 | 7babb6c7-3da1-11ee-aef3-1e004c000468 | 2023-08-18 08:30:26 | NULL | 0 |
| 9631 | VMware | rhel9_64Guest | 316 | 8.0.1 | 8b9471e1-f580-4842-8010-7e6db1130e3a | 2023-08-21 07:56:23 | NULL | 0 |
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
8 rows in set (0.00 sec)
MariaDB [cloud]> select * from guest_os_hypervisor where guest_os_id in (select id from guest_os where display_name like "Red Hat Enterprise Linux 9.0");
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| id | hypervisor_type | guest_os_name | guest_os_id | hypervisor_version | uuid | created | removed | is_user_defined |
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| 9138 | VMware | rhel9_64Guest | 336 | 7.0.1.0 | 97530a3d-7ae7-4bf9-896d-e6223efb4385 | 2023-08-18 08:30:28 | NULL | 0 |
| 9657 | KVM | Red Hat Enterprise Linux 9 | 336 | default | 2966d4a1-8f0f-4710-b5bb-1237b62aa2a1 | 2023-08-21 07:56:23 | NULL | 0 |
| 9658 | VMware | rhel9_64Guest | 336 | 7.0 | 5f55b779-ccd1-4dd4-a8bd-f8eae7b21a50 | 2023-08-21 07:56:23 | NULL | 0 |
| 9659 | VMware | rhel9_64Guest | 336 | 7.0.2.0 | 085570c5-30fa-4045-93c3-e00ce72e4570 | 2023-08-21 07:56:23 | NULL | 0 |
| 9660 | VMware | rhel9_64Guest | 336 | 7.0.3.0 | d04fab14-c613-4cea-aa5e-f4fae613f6aa | 2023-08-21 07:56:23 | NULL | 0 |
| 9661 | VMware | rhel9_64Guest | 336 | 8.0 | 90ce0ba2-dba5-4531-a89f-5cc34f3e356f | 2023-08-21 07:56:23 | NULL | 0 |
| 9662 | VMware | rhel9_64Guest | 336 | 8.0.0.1 | f1fe08a7-6ef2-4605-beee-e0947c04916b | 2023-08-21 07:56:23 | NULL | 0 |
| 9663 | VMware | rhel9_64Guest | 336 | 8.0.1 | f3a57660-e0e3-45cc-9c27-045df50a7324 | 2023-08-21 07:56:23 | NULL | 0 |
+------+-----------------+----------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
8 rows in set (0.00 sec)
MariaDB [cloud]> MariaDB [cloud]> MariaDB [cloud]> select * from guest_os_hypervisor where guest_os_id in (select id from guest_os where display_name like "Ubuntu 20.04 LTS");
+------+-----------------+--------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| id | hypervisor_type | guest_os_name | guest_os_id | hypervisor_version | uuid | created | removed | is_user_defined |
+------+-----------------+--------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| 7808 | KVM | Ubuntu 20.04 LTS | 305 | default | 7ae9b058-3da1-11ee-aef3-1e004c000468 | 2023-08-18 08:30:25 | NULL | 0 |
| 9123 | Xenserver | Ubuntu Focal Fossa 20.04 | 323 | 8.2.0 | 58c41d0b-5958-48e3-847d-b8e32a7ae5aa | 2023-08-18 08:30:28 | NULL | 0 |
| 9375 | VMware | ubuntu64Guest | 323 | 6.5 | 3e2e0fd2-593e-40c9-a0ab-f3db31a74c96 | 2023-08-21 07:56:22 | NULL | 0 |
| 9376 | VMware | ubuntu64Guest | 323 | 6.7 | dc48835c-1c06-4f29-bca9-5f10b2433053 | 2023-08-21 07:56:22 | NULL | 0 |
| 9377 | VMware | ubuntu64Guest | 323 | 6.7.1 | 326d0ff7-c165-49a7-957d-5e42a75432fb | 2023-08-21 07:56:22 | NULL | 0 |
| 9378 | VMware | ubuntu64Guest | 323 | 6.7.2 | ca68fb82-254d-4f13-95e0-4d0c5ccf59e7 | 2023-08-21 07:56:22 | NULL | 0 |
| 9379 | VMware | ubuntu64Guest | 323 | 6.7.3 | 8e30e7ac-4b5b-4391-981b-f973fd00b913 | 2023-08-21 07:56:22 | NULL | 0 |
| 9380 | VMware | ubuntu64Guest | 323 | 7.0 | 01d44549-eaf4-40a0-8853-b7dbe0846ec2 | 2023-08-21 07:56:22 | NULL | 0 |
| 9381 | VMware | ubuntu64Guest | 323 | 7.0.1.0 | 41696fa6-c392-4163-a175-a92c6ec70010 | 2023-08-21 07:56:22 | NULL | 0 |
| 9382 | VMware | ubuntu64Guest | 323 | 7.0.2.0 | 64968cbe-c96e-43a7-a3f2-d813f4943113 | 2023-08-21 07:56:22 | NULL | 0 |
| 9383 | VMware | ubuntu64Guest | 323 | 7.0.3.0 | f23f2164-7e5a-4fdf-8b17-2d151b57abfd | 2023-08-21 07:56:22 | NULL | 0 |
| 9384 | VMware | ubuntu64Guest | 323 | 8.0 | 2220c7a2-26e6-40b0-ae0a-1722c4c2f9c7 | 2023-08-21 07:56:22 | NULL | 0 |
| 9634 | VMware | ubuntu64Guest | 323 | 8.0.1 | 2ca07362-cfed-4042-ba3a-6bf7277a9ef6 | 2023-08-21 07:56:23 | NULL | 0 |
| 9646 | KVM | Ubuntu 20.04 LTS | 323 | default | 9bccc90d-bd30-44c4-bda3-a42118b53d99 | 2023-08-21 07:56:23 | NULL | 0 |
+------+-----------------+--------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
14 rows in set (0.00 sec)
MariaDB [cloud]> MariaDB [cloud]> select * from guest_os_hypervisor where guest_os_id in (select id from guest_os where display_name like "Ubuntu 20.04 LTS" and display=1);
+------+-----------------+--------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| id | hypervisor_type | guest_os_name | guest_os_id | hypervisor_version | uuid | created | removed | is_user_defined |
+------+-----------------+--------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
| 9123 | Xenserver | Ubuntu Focal Fossa 20.04 | 323 | 8.2.0 | 58c41d0b-5958-48e3-847d-b8e32a7ae5aa | 2023-08-18 08:30:28 | NULL | 0 |
| 9375 | VMware | ubuntu64Guest | 323 | 6.5 | 3e2e0fd2-593e-40c9-a0ab-f3db31a74c96 | 2023-08-21 07:56:22 | NULL | 0 |
| 9376 | VMware | ubuntu64Guest | 323 | 6.7 | dc48835c-1c06-4f29-bca9-5f10b2433053 | 2023-08-21 07:56:22 | NULL | 0 |
| 9377 | VMware | ubuntu64Guest | 323 | 6.7.1 | 326d0ff7-c165-49a7-957d-5e42a75432fb | 2023-08-21 07:56:22 | NULL | 0 |
| 9378 | VMware | ubuntu64Guest | 323 | 6.7.2 | ca68fb82-254d-4f13-95e0-4d0c5ccf59e7 | 2023-08-21 07:56:22 | NULL | 0 |
| 9379 | VMware | ubuntu64Guest | 323 | 6.7.3 | 8e30e7ac-4b5b-4391-981b-f973fd00b913 | 2023-08-21 07:56:22 | NULL | 0 |
| 9380 | VMware | ubuntu64Guest | 323 | 7.0 | 01d44549-eaf4-40a0-8853-b7dbe0846ec2 | 2023-08-21 07:56:22 | NULL | 0 |
| 9381 | VMware | ubuntu64Guest | 323 | 7.0.1.0 | 41696fa6-c392-4163-a175-a92c6ec70010 | 2023-08-21 07:56:22 | NULL | 0 |
| 9382 | VMware | ubuntu64Guest | 323 | 7.0.2.0 | 64968cbe-c96e-43a7-a3f2-d813f4943113 | 2023-08-21 07:56:22 | NULL | 0 |
| 9383 | VMware | ubuntu64Guest | 323 | 7.0.3.0 | f23f2164-7e5a-4fdf-8b17-2d151b57abfd | 2023-08-21 07:56:22 | NULL | 0 |
| 9384 | VMware | ubuntu64Guest | 323 | 8.0 | 2220c7a2-26e6-40b0-ae0a-1722c4c2f9c7 | 2023-08-21 07:56:22 | NULL | 0 |
| 9634 | VMware | ubuntu64Guest | 323 | 8.0.1 | 2ca07362-cfed-4042-ba3a-6bf7277a9ef6 | 2023-08-21 07:56:23 | NULL | 0 |
| 9646 | KVM | Ubuntu 20.04 LTS | 323 | default | 9bccc90d-bd30-44c4-bda3-a42118b53d99 | 2023-08-21 07:56:23 | NULL | 0 |
+------+-----------------+--------------------------+-------------+--------------------+--------------------------------------+---------------------+---------+-----------------+
13 rows in set (0.00 sec)

DaanHoogland

tested and reviewed, @BryanMLima can you approve it this way?

weizhouapache · 2023-08-21T08:48:16Z

@rohityadavcloud @harikrishna-patnala
can you review it ?

yadvr

LGTM didn't test it

github-actions · 2023-08-22T09:44:42Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

weizhouapache · 2023-08-22T09:53:45Z

@blueorangutan package

blueorangutan · 2023-08-22T09:54:03Z

@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-08-22T10:51:42Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6854

weizhouapache · 2023-08-22T10:53:49Z

@blueorangutan test matrix

blueorangutan · 2023-08-22T10:54:03Z

@weizhouapache a [SF] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2023-08-22T23:02:31Z

[SF] Trillian test result (tid-7506)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42331 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7799-t7506-xenserver-71.zip
Smoke tests completed. 106 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_upgrade_kubernetes_cluster	`Failure`	596.75	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	`Error`	309.28	test_kubernetes_clusters.py
test_07_deploy_vm_with_extraconfig_xenserver	`Error`	27.03	test_deploy_vm_extra_config_data.py

blueorangutan · 2023-08-22T23:04:30Z

[SF] Trillian test result (tid-7508)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42329 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7799-t7508-kvm-centos7.zip
Smoke tests completed. 107 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_upgrade_kubernetes_cluster	`Failure`	582.29	test_kubernetes_clusters.py

blueorangutan · 2023-08-23T00:20:51Z

[SF] Trillian test result (tid-7507)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 46910 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7799-t7507-vmware-67u3.zip
Smoke tests completed. 108 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2023-08-23T06:46:31Z

@BryanMLima @weizhouapache are we ready with this?

weizhouapache · 2023-08-23T07:44:17Z

retested all steps above, got same results
looks good to me.

thanks @DaanHoogland for the fix, merging

weizhouapache changed the title ~~engine/schema: check if guest OS exists before adding a new guest OS~~engine/schema: fix duplicated guest OSes in 4.18.0.0Aug 2, 2023

weizhouapache mentioned this pull request Aug 2, 2023
Duplicated guest OSes in ACS 4.18.0.0 #7783
Closed

This was linked to issues Aug 2, 2023
Duplicated guest OSes in ACS 4.18.0.0 #7783
Closed
Problem with guest os mappings for Red Hat Enterprise Linux 9 in ACS 4.18.0.0 #7781
Closed

weizhouapache added this to the 4.18.1.0 milestone Aug 2, 2023

harikrishna-patnala reviewed Aug 2, 2023
View reviewed changes

DaanHoogland force-pushed the 4.18-fix-duplicated-guest-os branch from d10fa3e to 5f17012Compare August 4, 2023 14:08

github-actionsBot added the status:has-conflicts label Aug 7, 2023

DaanHoogland force-pushed the 4.18-fix-duplicated-guest-os branch from 2572ce5 to 8462915Compare August 7, 2023 10:40

github-actionsBot removed the status:has-conflicts label Aug 7, 2023

boring-cyborgBot added component:storage component:api component:management-server component:vmware labels Aug 7, 2023

DaanHoogland force-pushed the 4.18-fix-duplicated-guest-os branch from c8c82a1 to 7353166Compare August 10, 2023 12:42

DaanHoogland mentioned this pull request Aug 11, 2023
Problem with guest os mappings for Red Hat Enterprise Linux 9 in ACS 4.18.0.0 #7781
Closed

weizhouapache commented Aug 11, 2023
View reviewed changes

DaanHoogland force-pushed the 4.18-fix-duplicated-guest-os branch from 24f5f24 to 01ab9f3Compare August 11, 2023 15:19

weizhouapache commented Aug 11, 2023
View reviewed changes

weizhouapache requested review from harikrishna-patnala and yadvr August 21, 2023 08:18

DaanHoogland approved these changes Aug 21, 2023
View reviewed changes

yadvr approved these changes Aug 22, 2023
View reviewed changes

github-actionsBot added the status:has-conflicts label Aug 22, 2023

Merge branch '4.18' into 4.18-fix-duplicated-guest-os
317045f

github-actionsBot removed the status:has-conflicts label Aug 22, 2023

weizhouapache merged commit e4117e6 into apache:4.18Aug 23, 2023

DaanHoogland deleted the 4.18-fix-duplicated-guest-os branch August 23, 2023 07:45

- usage_type = 24 AND usage_display like '% io write'; No newline at end of file
+ usage_type = 24 AND usage_display like '% io write';
+CALL `cloud`.`IDEMPOTENT_ADD_COLUMN`('cloud.guest_os', 'display', 'tinyint(1) DEFAULT ''1'' COMMENT ''should this guest_os be shown to the end user'' '); No newline at end of file

Uh oh!

Conversation

weizhouapache commented Aug 2, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache commented Aug 2, 2023

Uh oh!

blueorangutan commented Aug 2, 2023

Uh oh!

blueorangutan commented Aug 2, 2023

Uh oh!

codecovBot commented Aug 2, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actionsBot commented Aug 7, 2023

Uh oh!

DaanHoogland commented Aug 10, 2023

Uh oh!

blueorangutan commented Aug 10, 2023

Uh oh!

blueorangutan commented Aug 10, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DaanHoogland commented Aug 14, 2023

Uh oh!

blueorangutan commented Aug 14, 2023

Uh oh!

blueorangutan commented Aug 14, 2023

Uh oh!

blueorangutan commented Aug 18, 2023

Uh oh!

blueorangutan commented Aug 18, 2023

Uh oh!

weizhouapache commented Aug 18, 2023

Uh oh!

blueorangutan commented Aug 18, 2023

Uh oh!

blueorangutan commented Aug 18, 2023

Uh oh!

blueorangutan commented Aug 18, 2023

Uh oh!

weizhouapache commented Aug 21, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weizhouapache commented Aug 2, 2023•
edited
Loading

codecovBot commented Aug 2, 2023•
edited
Loading

weizhouapache commented Aug 21, 2023•
edited
Loading