Skip to content

Details on add guest os optional - #7812

Merged
DaanHoogland merged 1 commit into
apache:4.18from
shapeblue:detailsOnAddGuestOs
Aug 4, 2023
Merged

Details on add guest os optional#7812
DaanHoogland merged 1 commit into
apache:4.18from
shapeblue:detailsOnAddGuestOs

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

This PR fixes a issue reported in the user mail list: https://lists.apache.org/thread/clsoyz3kgp47ppbhtqp8m0o2fkczqrmk

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@apacheapache deleted a comment from blueorangutanAug 3, 2023
@DaanHoogland

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6650

@codecov

codecovBot commented Aug 3, 2023

Copy link
Copy Markdown

Codecov Report

Merging #7812 (a2e5b1a) into 4.18 (c86684f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## 4.18 #7812 +/- ##
============================================
- Coverage 13.02% 13.02% -0.01% + Complexity 9031 9029 -2 
============================================
Files 2720 2720 Lines 257010 257010 Branches 40083 40083 ============================================
- Hits 33472 33467 -5 - Misses 219336 219342 +6 + Partials 4202 4201 -1 

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DaanHoogland

Copy link
Copy Markdown
ContributorAuthor

I don't think this will be touched by any smoke tests

@BryanMLimaBryanMLima left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, already manually tested this change with PR #6979.

@harikrishna-patnalaharikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@DaanHoogland
DaanHoogland merged commit 6b21825 into apache:4.18Aug 4, 2023
@DaanHoogland
DaanHoogland deleted the detailsOnAddGuestOs branch August 4, 2023 06:44
@DaanHooglandDaanHoogland added this to the 4.18.1.0 milestone Aug 4, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@DaanHoogland@blueorangutan@harikrishna-patnala@BryanMLima