NSX integration by Pearl1594 · Pull Request #7919 · apache/cloudstack

Pearl1594 · 2023-08-28T19:28:08Z

Description

This PR adds support for VMware NSX on CloudStack

Documentation: apache/cloudstack-documentation#378

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Testing on VMware NSX 4.1, CloudStack env vCenter 7.0

\n add nsx controller command

…integration

codecov · 2023-08-28T20:21:22Z

Codecov Report

Attention: Patch coverage is 41.89028% with 1949 lines in your changes are missing coverage. Please review.

Project coverage is 31.31%. Comparing base (3baa45b) to head (2187fdd).
Report is 19 commits behind head on main.

Files	Patch %	Lines
...va/org/apache/cloudstack/service/NsxApiClient.java	6.65%	614 Missing and 3 partials ⚠️
...java/org/apache/cloudstack/service/NsxElement.java	58.57%	117 Missing and 40 partials ⚠️
...va/org/apache/cloudstack/resource/NsxResource.java	49.80%	107 Missing and 22 partials ⚠️
...apache/cloudstack/service/NsxGuestNetworkGuru.java	42.10%	56 Missing and 32 partials ⚠️
ui/src/views/infra/zone/ZoneWizardLaunchZone.vue	0.00%	57 Missing ⚠️
ui/src/views/offering/AddNetworkOffering.vue	0.00%	52 Missing ⚠️
.../org/apache/cloudstack/service/NsxServiceImpl.java	44.70%	43 Missing and 4 partials ⚠️
...ain/java/com/cloud/network/NetworkServiceImpl.java	38.15%	40 Missing and 7 partials ⚠️
ui/src/views/offering/AddVpcOffering.vue	0.00%	45 Missing ⚠️
...tack/engine/orchestration/NetworkOrchestrator.java	36.66%	28 Missing and 10 partials ⚠️
... and 87 more

Additional details and impacted files

@@ Coverage Diff @@## main #7919 +/- ##
============================================
+ Coverage 29.92% 31.31% +1.39% - Complexity 32240 34740 +2500 
============================================
Files 5355 5397 +42 Lines 375771 386030 +10259 Branches 54912 57944 +3032 ============================================
+ Hits 112455 120903 +8448 - Misses 248321 249075 +754 - Partials 14995 16052 +1057

Flag	Coverage Δ
simulator-marvin-tests	`24.97% <13.78%> (+1.56%)`	⬆️
uitests	`4.33% <0.44%> (-0.04%)`	⬇️
unit-tests	`16.96% <35.88%> (+0.37%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…integration

nvazquez · 2024-02-26T12:01:15Z

@blueorangutan package

blueorangutan · 2024-02-26T12:02:03Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-02-26T13:08:46Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8786

github-actions · 2024-02-26T14:46:22Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

nvazquez · 2024-03-06T14:05:01Z

@blueorangutan package

blueorangutan · 2024-03-06T14:06:03Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-03-06T14:19:32Z

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8865

nvazquez · 2024-03-06T15:20:28Z

@blueorangutan package

blueorangutan · 2024-03-06T15:22:03Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-03-06T16:37:00Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8866

nvazquez · 2024-03-06T17:15:02Z

@blueorangutan test matrix

blueorangutan · 2024-03-06T17:16:03Z

@nvazquez a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

blueorangutan · 2024-03-07T05:50:44Z

[SF] Trillian test result (tid-9409)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43724 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7919-t9409-xenserver-71.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2024-03-07T07:13:27Z

[SF] Trillian test result (tid-9410)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 48686 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7919-t9410-vmware-67u3.zip
Smoke tests completed. 128 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_balanced_drs_algorithm	`Failure`	130.26	test_cluster_drs.py

blueorangutan · 2024-03-07T08:03:43Z

[SF] Trillian test result (tid-9411)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 51643 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7919-t9411-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

nvazquez · 2024-03-08T02:33:52Z

Merging based on approvals, test results and extensive testing on NSX 4.1 - vCenter 7.0.3u3

weizhouapache · 2024-03-08T15:56:41Z

Great work !
@Pearl1594 @nvazquez

Pearl1594and others added 15 commits August 15, 2023 07:23

NSX integration - skeletal code
446dd83

Fix module not loading on startup
e886165

add upgrade path and daos
2c0f51e
\n add nsx controller command

add support for adding and listing nsx provider to a zone
2b0ddc6

add license
50879ea

add default VPC offering and update upgrade path
3179a3e

add global setting to enable nsx plugin
357f217

add delete nsx controller operation
913d0bc

add nsxresource
9c22bda

add NSX resource , api client, create tier1 gw
e0244e2

Merge branch 'main' ofhttps://github.com/apache/cloudstackinto nsx-…
d8998d0
…integration

update db
bb9b644

update response and add license
937b34b

Merge branch 'main' ofhttps://github.com/apache/cloudstackinto nsx-…
b37a9f7
…integration

Add support to create and delete nsx tier-1 gateway
bedfe44

boring-cyborgBot added component:api component:build component:networking component:orchestration labels Aug 28, 2023

Pearl1594 changed the title ~~Nsx integration~~NSX integrationAug 28, 2023

add license
996821d

cleanup and add skeletal code for network creation
b0933bb

Pearl1594 force-pushed the nsx-integration branch from 3f48ac4 to b0933bbCompare August 29, 2023 19:01

Pearl1594 added 3 commits September 6, 2023 10:32

Merge branch 'main' ofhttps://github.com/apache/cloudstackinto nsx-…
2cccd53
…integration

add create/delete segment and UI integration
37d6344

add license
e443f13

Pearl1594 force-pushed the nsx-integration branch from 6f382e7 to 9685f87Compare September 7, 2023 14:03

address code smells - part 1
d378130

Pearl1594 force-pushed the nsx-integration branch from 9685f87 to d378130Compare September 7, 2023 14:56

Merge branch 'main' into nsx-integration
82217c0

github-actionsBot removed the status:has-conflicts label Feb 26, 2024

github-actionsBot added the status:has-conflicts label Feb 26, 2024

Merge branch 'main' into nsx-integration
869a51a

github-actionsBot removed the status:has-conflicts label Feb 26, 2024

NSX: Last Fixes
012dd03

Fix build
2187fdd

Pearl1594 mentioned this pull request Apr 12, 2024
NSX Integration fixes #8906
Merged
13 tasks

This was referenced Apr 24, 2024
vpc: create vpc tiers with dns server of vpc instead of zone #8621
Merged
CKS cluster with HA enabled has port forwarding rules to one control VM #8295
Closed

This was referenced Jun 5, 2024
NSX: Cleanup PF rule when VM is expunged and fix UDP - LB rules #8699
Closed
NSX: Support ACL Rules re-ordering in NSX #8618
Closed

weizhouapache mentioned this pull request Jul 9, 2024
Load balancer for Kube-API Kubernetes in VPC #9338
Closed

Uh oh!

Conversation

Pearl1594 commented Aug 28, 2023• edited by nvazquez Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

codecovBot commented Aug 28, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nvazquez commented Feb 26, 2024

Uh oh!

blueorangutan commented Feb 26, 2024

Uh oh!

blueorangutan commented Feb 26, 2024

Uh oh!

github-actionsBot commented Feb 26, 2024

Uh oh!

nvazquez commented Mar 6, 2024

Uh oh!

blueorangutan commented Mar 6, 2024

Uh oh!

blueorangutan commented Mar 6, 2024

Uh oh!

nvazquez commented Mar 6, 2024

Uh oh!

blueorangutan commented Mar 6, 2024

Uh oh!

blueorangutan commented Mar 6, 2024

Uh oh!

nvazquez commented Mar 6, 2024

Uh oh!

blueorangutan commented Mar 6, 2024

Uh oh!

blueorangutan commented Mar 7, 2024

Uh oh!

blueorangutan commented Mar 7, 2024

Uh oh!

blueorangutan commented Mar 7, 2024

Uh oh!

nvazquez commented Mar 8, 2024

Uh oh!

weizhouapache commented Mar 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Pearl1594 commented Aug 28, 2023•
edited by nvazquez
Loading

codecovBot commented Aug 28, 2023•
edited
Loading