Skip to content

schema: revert incorrect removal of oauth changes in #7417 - #8245

Merged
DaanHoogland merged 1 commit into
apache:mainfrom
shapeblue:revert-fix-oauth2schema
Nov 17, 2023
Merged

schema: revert incorrect removal of oauth changes in #7417#8245
DaanHoogland merged 1 commit into
apache:mainfrom
shapeblue:revert-fix-oauth2schema

Conversation

@shwstppr

@shwstpprshwstppr commented Nov 17, 2023

Copy link
Copy Markdown
Contributor

Description

Fixes OAuth(2) schema changes removed in Database VIEW Management improvement #7417

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
schema: revert incorrect removal of oauth changes inapache#7417
9ca1f36
Fixes OAuth(2) schema changes removed in Database VIEW Management
improvement apache#7417
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstpprshwstppr added this to the 4.19.0.0 milestone Nov 17, 2023
@shwstppr

shwstppr commented Nov 17, 2023

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

DaanHoogland
DaanHoogland approved these changes Nov 17, 2023
View reviewed changes

@DaanHooglandDaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

harikrishna-patnala
harikrishna-patnala approved these changes Nov 17, 2023
View reviewed changes

@harikrishna-patnalaharikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching and fixing it @shwstppr

@DaanHoogland

DaanHoogland commented Nov 17, 2023

Copy link
Copy Markdown
Contributor

@blueorangutan package

@DaanHooglandDaanHoogland mentioned this pull request Nov 17, 2023
Closed
11 tasks
@codecov

codecovBot commented Nov 17, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (adbb552) 29.16% compared to head (9ca1f36) 29.15%.

Additional details and impacted files
@@ Coverage Diff @@## main #8245 +/- ##
============================================
- Coverage 29.16% 29.15% -0.01% + Complexity 31050 31045 -5 
============================================
Files 5193 5193 Lines 366266 366266 Branches 53548 53548 ============================================
- Hits 106804 106785 -19 - Misses 244821 244840 +19 
Partials 14641 14641
FlagCoverage Δ
simulator-marvin-tests25.10% <ø> (-0.01%)⬇️
uitests4.49% <ø> (ø)
unit-tests14.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwstppr
shwstppr marked this pull request as ready for review November 17, 2023 12:56
@shwstppr

shwstppr commented Nov 17, 2023

Copy link
Copy Markdown
ContributorAuthor

@blueorangutan package

@blueorangutan

blueorangutan commented Nov 17, 2023

Copy link
Copy Markdown

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache
weizhouapache approved these changes Nov 17, 2023
View reviewed changes

@weizhouapacheweizhouapache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache

weizhouapache commented Nov 17, 2023

Copy link
Copy Markdown
Member

@DaanHoogland@shwstppr
should we merge this now ?
I think all other PRs against main branch might be impacted by the issue.

@DaanHoogland

DaanHoogland commented Nov 17, 2023

Copy link
Copy Markdown
Contributor

I think we can, but would like to await the package job

@weizhouapache

weizhouapache commented Nov 17, 2023

Copy link
Copy Markdown
Member

I think we can, but would like to await the package job

ok @DaanHoogland , let's wait.
The simulator CI looks fine btw

@blueorangutan

blueorangutan commented Nov 17, 2023

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 7784

@DaanHoogland
DaanHoogland merged commit c7ed4ca into apache:mainNov 17, 2023
@DaanHoogland
DaanHoogland deleted the revert-fix-oauth2schema branch November 17, 2023 14:11
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Nov 29, 2023
@shwstppr@dhslove
schema: revert incorrect removal of oauth changes inapache#7417(apa…
340a91b
…che#8245)
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHooglandDaanHooglandDaanHoogland approved these changes
@harikrishna-patnalaharikrishna-patnalaharikrishna-patnala approved these changes
@GutoVeroneziGutoVeroneziGutoVeronezi approved these changes
@weizhouapacheweizhouapacheweizhouapache approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.19.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@shwstppr@DaanHoogland@blueorangutan@weizhouapache@harikrishna-patnala@GutoVeronezi