Skip to content

api: return volumes in user vm response - #8330

Closed
shwstppr wants to merge 1 commit into
apache:mainfrom
shapeblue:add-vmresponse-volume
Closed

api: return volumes in user vm response#8330
shwstppr wants to merge 1 commit into
apache:mainfrom
shapeblue:add-vmresponse-volume

Conversation

@shwstppr

Copy link
Copy Markdown
Contributor

Description

TBA

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov

codecovBot commented Dec 7, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b00fd6b) 29.14% compared to head (4bab25d) 29.23%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #8330 +/- ##
============================================
+ Coverage 29.14% 29.23% +0.08% - Complexity 31270 31423 +153 
============================================
Files 5251 5260 +9 Lines 368801 369711 +910 Branches 53766 53890 +124 ============================================
+ Hits 107485 108081 +596 - Misses 246607 246853 +246 - Partials 14709 14777 +68 
FlagCoverage Δ
simulator-marvin-tests25.07% <100.00%> (+0.04%)⬆️
uitests4.42% <ø> (-0.03%)⬇️
unit-tests14.99% <ø> (+0.09%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland

Copy link
Copy Markdown
Contributor

@shwstppr you want to finish this or shall i take over?

@shwstppr

Copy link
Copy Markdown
ContributorAuthor

@DaanHoogland

@shwstppr you want to finish this or shall i take over?

I guess I should be able to make changes for this later today or tomorrow. Otherwise I'll sync with you to take this over

@shwstppr

Copy link
Copy Markdown
ContributorAuthor

Needs more work. Closing for now

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@shwstppr@DaanHoogland