Quota tariff order by JoaoJandre · Pull Request #8347 · apache/cloudstack

JoaoJandre · 2023-12-12T11:39:21Z

Description

Quota tariffs have been extended to make it possible to define the order of their execution. To achieve this, the position parameter was added to the quotaTariffCreate and quotaTariffUpdate APIs. This parameter is used to define the tariff execution sequence of tariffs with the same usage type. This order is ascending, that is, a tariff with position equal to 1 will be executed before a tariff with position equal to 2. If two tariffs of the same usage type have equal positions, the most recent one will be executed first.

During the processing of Quota tariffs, ACS will execute them in the defined order and inject the values into subsequent rates. To enable tariff injection, the preset variable lastTariffs was created. It will have a list of objects containing the id and value attributes of the tariffs executed before it. Below is an example of the variable value when executing 3 tariffs (A, B and C) of the same usage type:

When executing tariff A, the value of lastTariffs will be:

[ ]

When executing rule B, lastTariffs will have the value:

[
{
"id": <A_uuid>,
"value": <A_result>
}
]

When executing rule C, lastTariffs will have the values:

[
{
"id": <A_uuid>,
"value": <A_result>
},
{
"id": <B_uuid>,
"value": <B_result>
}
]

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

How Has This Been Tested?

About the quotaTariffCreate and quotaTariffUpdate APIs

Num	Test	Result	Expected result?
1	Create a tariff informing the position	Tariff was created with the position informed	Y
2	Create a tariff without informing the position	Tariff was created with default position 1	Y
3	Edit a tariff by entering a new position	Tariff was edited with the position given	Y
4	Edit a tariff without entering a new position	Tariff was edited maintaining the previous position	Y

About the lastTariffs preset variable:
I created three tariffs with activation rules:

the first with position 1 and always returning 10
the second with position 2 and the rule: lastTariffs[0].value + 7
the third with position 3 and the rule: lastTariffs[0].value + lastTariffs[1].value.

When running quotaUpdate, I looked in the logs for which values were calculated according to the tariffs, the first returned 10, the second 17 and the third 27.

codecov · 2023-12-12T11:47:28Z

Codecov Report

Attention: Patch coverage is 65.71429% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 31.04%. Comparing base (0e32380) to head (38b1f00).
Report is 1 commits behind head on main.

Files	Patch %	Lines
...e/cloudstack/api/command/QuotaTariffCreateCmd.java	0.00%	3 Missing ⚠️
...e/cloudstack/api/command/QuotaTariffUpdateCmd.java	0.00%	3 Missing ⚠️
...udstack/api/response/QuotaResponseBuilderImpl.java	62.50%	3 Missing ⚠️
...k/quota/activationrule/presetvariables/Tariff.java	80.00%	1 Missing ⚠️
.../org/apache/cloudstack/quota/vo/QuotaTariffVO.java	75.00%	1 Missing ⚠️
...e/cloudstack/api/response/QuotaTariffResponse.java	66.66%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #8347 +/- ##
============================================
+ Coverage 4.34% 31.04% +26.70% - Complexity 0 33910 +33910 
============================================
Files 361 5405 +5044 Lines 29004 380315 +351311 Branches 5092 55505 +50413 ============================================
+ Hits 1260 118079 +116819 - Misses 27604 246497 +218893 - Partials 140 15739 +15599

Flag	Coverage Δ
simulator-marvin-tests	`24.61% <0.00%> (?)`
uitests	`4.34% <ø> (ø)`
unit-tests	`16.88% <65.71%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DaanHoogland

clgtm and well covered by tests, however as this is user facinng functionality, doe sit make sense to add an integration test @JoaoJandre ?

JoaoJandre · 2023-12-13T11:11:28Z

clgtm and well covered by tests, however as this is user facinng functionality, doe sit make sense to add an integration test @JoaoJandre ?

Sure, I'll try to add some integration tests

github-actions · 2023-12-18T08:02:14Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

github-actions · 2024-01-09T11:08:26Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

JoaoJandre · 2024-02-05T16:31:49Z

@DaanHoogland I've created the integration test. However, while testing it, I found out that the test only works alongside #8581, thus, this PR now depends on #8581.

github-actions · 2024-02-08T13:19:03Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

JoaoJandre · 2024-02-14T16:42:15Z

@blueorangutan package

blueorangutan · 2024-02-14T16:44:04Z

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-02-14T17:48:45Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8651

DaanHoogland · 2024-02-15T08:53:43Z

@blueorangutan test alma9 kvm-alma9

blueorangutan · 2024-02-15T08:54:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

github-actions · 2024-06-03T06:14:08Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

JoaoJandre · 2024-06-11T11:30:00Z

@blueorangutan package

blueorangutan · 2024-06-11T11:32:04Z

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-06-11T12:42:19Z

Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9864

JoaoJandre · 2024-06-11T16:18:09Z

@DaanHoogland @sureshanaparti @rohityadavcloud could we run the CI here?

DaanHoogland · 2024-06-12T09:54:37Z

@JoaoJandre we are prioritising 4.19 now. /me postponing this.

github-actions · 2024-06-13T20:05:28Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2024-07-10T07:23:10Z

@blueorangutan package

blueorangutan · 2024-07-10T07:24:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-07-10T08:37:32Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10315

DaanHoogland · 2024-07-11T10:54:43Z

@blueorangutan test

blueorangutan · 2024-07-11T10:56:05Z

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

bernardodemarco

LGTM. I manually tested the PR in a local environment.

Tests Descriptions

`quotaTariffCreate` API

Firstly, I created a tariff without specifying a value for the position parameter.

quota tariffcreate usagetype=1 name="Running VM - Position 1" value=10
{
"quotatariff": {
"currency": "$",
"effectiveDate": "2024-07-11T22:03:45+0000",
"id": "7fcaf5f0-19e3-4211-8a2e-43c085db8cb7",
"name": "Running VM - Position 1",
"position": 1,
"tariffValue": 10,
"usageDiscriminator": "None",
"usageName": "RUNNING_VM",
"usageType": 1,
"usageTypeDescription": "Running Vm Usage",
"usageUnit": "Compute*Month"
}
}

The tariff has been created with the position set to 1, which is the expected behavior.

I created another tariff, with the same usage type, but this time I specified a position.

quota tariffcreate usagetype=1 name="Running VM - Position 2" position=2 value=20
{
"quotatariff": {
"currency": "$",
"effectiveDate": "2024-07-11T22:04:30+0000",
"id": "eb815532-97ce-4e1d-81c5-d5872b732502",
"name": "Running VM - Position 2",
"position": 2,
"tariffValue": 20,
"usageDiscriminator": "None",
"usageName": "RUNNING_VM",
"usageType": 1,
"usageTypeDescription": "Running Vm Usage",
"usageUnit": "Compute*Month"
}
}

The tariff has been created, and the position attribute was set to 2.

`quotaTariffUpdate` API

I updated the position of the Running VM - Position 1 tariff to 3.

quota tariffupdate name="Running VM - Position 1" position=3
{
"quotatariff": {
"currency": "$",
"effectiveDate": "2024-07-11T22:03:45+0000",
"id": "ef69dcba-51a6-462a-93f1-5e08178faeaf",
"name": "Running VM - Position 1",
"position": 3,
"tariffValue": 10,
"usageDiscriminator": "None",
"usageName": "RUNNING_VM",
"usageType": 1,
"usageTypeDescription": "Running Vm Usage",
"usageUnit": "Compute*Month"
}
}

The position attribute was updated accordingly to 3.

I edited the same tariff again without entering a new position.

quota tariffupdate name="Running VM - Position 1" value=15
{
"quotatariff": {
"currency": "$",
"effectiveDate": "2024-07-11T22:03:45+0000",
"id": "a2215dac-9901-43aa-bf99-aa2f7a6d65a3",
"name": "Running VM - Position 1",
"position": 3,
"tariffValue": 15,
"usageDiscriminator": "None",
"usageName": "RUNNING_VM",
"usageType": 1,
"usageTypeDescription": "Running Vm Usage",
"usageUnit": "Compute*Month"
}
}

The position value remained unchanged, which is the expected behavior.

`lastTariffs` preset variable

I updated the Running VM - Position 1 with its original value and position.

quota tariffupdate name="Running VM - Position 1" position=1 value=10
{
"quotatariff": {
"currency": "$",
"effectiveDate": "2024-07-11T22:03:45+0000",
"id": "24e25d39-9a4f-4915-8cf8-828b5c4fc9e3",
"name": "Running VM - Position 1",
"position": 1,
"tariffValue": 10,
"usageDiscriminator": "None",
"usageName": "RUNNING_VM",
"usageType": 1,
"usageTypeDescription": "Running Vm Usage",
"usageUnit": "Compute*Month"
}
}

I created a third tariff with a position equal to 3 and an activation rule that returns the sum of the values of the two previous tariffs increased by 20%.

quota tariffcreate usagetype=1 name="Running VM - Position 3" value=0 position=3 activationrule="(lastTariffs[0].value + lastTariffs[1].value) * 1.2"
{
"quotatariff": {
"activationRule": "(lastTariffs[0].value + lastTariffs[1].value) * 1.2",
"currency": "$",
"effectiveDate": "2024-07-11T22:09:18+0000",
"id": "733e1df4-c3b9-4e31-b9eb-535fdc7311a3",
"name": "Running VM - Position 3",
"position": 3,
"tariffValue": 0,
"usageDiscriminator": "None",
"usageName": "RUNNING_VM",
"usageType": 1,
"usageTypeDescription": "Running Vm Usage",
"usageUnit": "Compute*Month"
}
}

I executed quota update and checked the logs for the tariff values. The following log appeared, stating that the value of the third tariff is equal to 36 (10 + 20) * 1.2:

DEBUG [o.a.c.q.QuotaManagerImpl] (qtp1404565079-27:[ctx-692ce99d, ctx-a2776cd3]) (logid:22a7aec5) The script [(lastTariffs[0].value + lastTariffs[1].value) * 1.2] of quota tariff [{"name":"Running VM - Position 3","usageName":"RUNNING_VM","uuid":"733e1df4-c3b9-4e31-b9eb-535fdc7311a3","startDate":"2024-07-11T22:09:18+0000","endDate":"null"}] had a numeric value [36.0], therefore we will use it in the calculation.

bernardodemarco · 2024-07-11T22:51:02Z

@JoaoJandre, once this PR gets merged, I intend to add UI support for the position parameter on #9225.

blueorangutan · 2024-07-12T03:17:56Z

[SF] Trillian test result (tid-10803)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 57235 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8347-t10803-kvm-centos7.zip
Smoke tests completed. 113 look OK, 24 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_role_account_acls_multiple_mgmt_servers	`Error`	2.36	test_dynamicroles.py
test_query_async_job_result	`Error`	96.84	test_async_job.py
test_revoke_certificate	`Error`	0.02	test_certauthority_root.py
test_configure_ha_provider_invalid	`Error`	0.01	test_hostha_simulator.py
test_configure_ha_provider_valid	`Error`	0.01	test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones	`Error`	0.01	test_hostha_simulator.py
test_ha_disable_feature_invalid	`Error`	0.01	test_hostha_simulator.py
test_ha_enable_feature_invalid	`Error`	0.01	test_hostha_simulator.py
test_ha_list_providers	`Error`	0.01	test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership	`Error`	0.01	test_hostha_simulator.py
test_ha_verify_fsm_available	`Error`	0.01	test_hostha_simulator.py
test_ha_verify_fsm_degraded	`Error`	0.01	test_hostha_simulator.py
test_ha_verify_fsm_fenced	`Error`	0.01	test_hostha_simulator.py
test_ha_verify_fsm_recovering	`Error`	0.01	test_hostha_simulator.py
test_hostha_configure_default_driver	`Error`	0.01	test_hostha_simulator.py
test_hostha_configure_invalid_provider	`Error`	0.01	test_hostha_simulator.py
test_hostha_disable_feature_valid	`Error`	0.01	test_hostha_simulator.py
test_hostha_enable_feature_valid	`Error`	0.01	test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider	`Error`	0.01	test_hostha_simulator.py
test_list_ha_for_host	`Error`	0.01	test_hostha_simulator.py
test_list_ha_for_host_invalid	`Error`	0.01	test_hostha_simulator.py
test_list_ha_for_host_valid	`Error`	0.01	test_hostha_simulator.py
test_01_host_ping_on_alert	`Error`	0.07	test_host_ping.py
test_01_host_ping_on_alert	`Error`	0.07	test_host_ping.py
test_01_browser_migrate_template	`Error`	15.36	test_image_store_object_migration.py
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	245.78	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	250.66	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	227.13	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	236.31	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	236.63	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	233.50	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	336.10	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	`Failure`	259.87	test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle	`Error`	83.87	test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version	`Error`	0.11	test_kubernetes_supported_versions.py
login_test_saml_user	`Error`	2.99	test_login.py
test_01_deployVMInSharedNetwork	`Error`	75.27	test_network.py
test_03_destroySharedNetwork	`Failure`	1.08	test_network.py
ContextSuite context=TestSharedNetwork>:teardown	`Error`	2.19	test_network.py
test_oobm_issue_power_cycle	`Error`	3.30	test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_off	`Error`	3.29	test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_on	`Error`	3.29	test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_reset	`Error`	3.31	test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_soft	`Error`	3.32	test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_status	`Error`	2.22	test_outofbandmanagement_nestedplugin.py
test_oobm_background_powerstate_sync	`Failure`	21.69	test_outofbandmanagement.py
test_oobm_background_powerstate_sync	`Error`	21.69	test_outofbandmanagement.py
test_oobm_configure_default_driver	`Error`	0.05	test_outofbandmanagement.py
test_oobm_configure_invalid_driver	`Error`	0.05	test_outofbandmanagement.py
test_oobm_disable_feature_invalid	`Error`	0.04	test_outofbandmanagement.py
test_oobm_disable_feature_valid	`Error`	1.14	test_outofbandmanagement.py
test_oobm_enable_feature_invalid	`Error`	0.05	test_outofbandmanagement.py
test_oobm_enable_feature_valid	`Error`	1.13	test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones	`Error`	9.84	test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones	`Error`	9.84	test_outofbandmanagement.py
test_oobm_issue_power_cycle	`Error`	4.32	test_outofbandmanagement.py
test_oobm_issue_power_cycle	`Error`	4.32	test_outofbandmanagement.py
test_oobm_issue_power_off	`Error`	4.34	test_outofbandmanagement.py
test_oobm_issue_power_off	`Error`	4.34	test_outofbandmanagement.py
test_oobm_issue_power_on	`Error`	4.34	test_outofbandmanagement.py
test_oobm_issue_power_on	`Error`	4.34	test_outofbandmanagement.py
test_oobm_issue_power_reset	`Error`	4.32	test_outofbandmanagement.py
test_oobm_issue_power_reset	`Error`	4.32	test_outofbandmanagement.py
test_oobm_issue_power_soft	`Error`	3.31	test_outofbandmanagement.py
test_oobm_issue_power_soft	`Error`	3.31	test_outofbandmanagement.py
test_oobm_issue_power_status	`Error`	4.32	test_outofbandmanagement.py
test_oobm_issue_power_status	`Error`	4.32	test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership	`Error`	1.14	test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership	`Error`	1.14	test_outofbandmanagement.py
test_oobm_zchange_password	`Error`	2.25	test_outofbandmanagement.py
test_oobm_zchange_password	`Error`	2.25	test_outofbandmanagement.py
test_02_edit_primary_storage_tags	`Error`	0.01	test_primary_storage.py
test_01_primary_storage_scope_change	`Error`	0.11	test_primary_storage_scope.py
test_01_vpc_privategw_acl	`Error`	0.03	test_privategw_acl_ovs_gre.py
test_03_vpc_privategw_restart_vpc_cleanup	`Error`	0.02	test_privategw_acl_ovs_gre.py
test_05_vpc_privategw_check_interface	`Error`	0.02	test_privategw_acl_ovs_gre.py
test_01_vpc_privategw_acl	`Error`	55.77	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Error`	205.95	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Error`	212.06	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Error`	325.38	test_privategw_acl.py
test_01_purge_expunged_api_vm_start_date	`Error`	47.58	test_purge_expunged_vms.py
test_02_purge_expunged_api_vm_end_date	`Error`	45.05	test_purge_expunged_vms.py
test_03_purge_expunged_api_vm_start_end_date	`Error`	43.01	test_purge_expunged_vms.py
test_04_purge_expunged_api_vm_no_date	`Error`	44.84	test_purge_expunged_vms.py
test_05_purge_expunged_vm_service_offering	`Error`	267.07	test_purge_expunged_vms.py
test_06_purge_expunged_vm_background_task	`Error`	330.79	test_purge_expunged_vms.py
test_01_snapshot_root_disk	`Error`	4.30	test_snapshots.py
test_CreateTemplateWithDuplicateName	`Error`	23.88	test_templates.py
test_01_register_template_direct_download_flag	`Error`	0.16	test_templates.py
test_01_positive_tests_usage	`Error`	9.36	test_usage_events.py
test_01_ISO_usage	`Error`	1.09	test_usage.py
test_01_lb_usage	`Error`	4.24	test_usage.py
test_01_nat_usage	`Error`	8.35	test_usage.py
test_01_public_ip_usage	`Error`	1.08	test_usage.py
test_01_snapshot_usage	`Error`	38.30	test_usage.py
test_01_template_usage	`Error`	9.40	test_usage.py
test_01_vm_usage	`Error`	132.94	test_usage.py
test_01_volume_usage	`Error`	125.96	test_usage.py
test_01_vpn_usage	`Error`	9.52	test_usage.py
test_12_start_vm_multiple_volumes_allocated	`Error`	10.56	test_vm_life_cycle.py
test_01_vmschedule_create	`Error`	0.09	test_vm_schedule.py
test_disable_oobm_ha_state_ineligible	`Error`	0.06	test_hostha_kvm.py
test_hostha_configure_default_driver	`Error`	0.05	test_hostha_kvm.py
test_hostha_enable_ha_when_host_disabled	`Error`	0.05	test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconected	`Error`	0.04	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	0.04	test_hostha_kvm.py
test_hostha_kvm_host_degraded	`Error`	0.04	test_hostha_kvm.py
test_hostha_kvm_host_fencing	`Error`	0.04	test_hostha_kvm.py
test_hostha_kvm_host_recovering	`Error`	0.05	test_hostha_kvm.py
test_remove_ha_provider_not_possible	`Error`	0.05	test_hostha_kvm.py

DaanHoogland · 2024-07-12T08:00:48Z

[SF] Trillian test result (tid-10803) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 57235 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8347-t10803-kvm-centos7.zip Smoke tests completed. 113 look OK, 24 have errors, 0 did not run Only failed and skipped tests results shown below:
Test Result Time (s) Test File

...

I'm guessing these are flukes, apllyining well tested insanity method

DaanHoogland · 2024-07-12T08:00:54Z

@blueorangutan test

blueorangutan · 2024-07-12T08:02:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2024-07-13T02:46:07Z

[SF] Trillian test result (tid-10811)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 65827 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8347-t10811-kvm-centos7.zip
Smoke tests completed. 110 look OK, 27 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_role_account_acls_multiple_mgmt_servers	`Error`	2.25	test_dynamicroles.py
test_query_async_job_result	`Error`	102.06	test_async_job.py
test_revoke_certificate	`Error`	0.01	test_certauthority_root.py
test_configure_ha_provider_invalid	`Error`	0.02	test_hostha_simulator.py
test_configure_ha_provider_valid	`Error`	0.01	test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones	`Error`	0.01	test_hostha_simulator.py
test_ha_disable_feature_invalid	`Error`	0.01	test_hostha_simulator.py
test_ha_enable_feature_invalid	`Error`	0.01	test_hostha_simulator.py
test_ha_list_providers	`Error`	0.01	test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership	`Error`	0.01	test_hostha_simulator.py
test_ha_verify_fsm_available	`Error`	0.01	test_hostha_simulator.py
test_ha_verify_fsm_degraded	`Error`	0.01	test_hostha_simulator.py
test_ha_verify_fsm_fenced	`Error`	0.01	test_hostha_simulator.py
test_ha_verify_fsm_recovering	`Error`	0.01	test_hostha_simulator.py
test_hostha_configure_default_driver	`Error`	0.01	test_hostha_simulator.py
test_hostha_configure_invalid_provider	`Error`	0.01	test_hostha_simulator.py
test_hostha_disable_feature_valid	`Error`	0.01	test_hostha_simulator.py
test_hostha_enable_feature_valid	`Error`	0.01	test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider	`Error`	0.01	test_hostha_simulator.py
test_list_ha_for_host	`Error`	0.01	test_hostha_simulator.py
test_list_ha_for_host_invalid	`Error`	0.01	test_hostha_simulator.py
test_list_ha_for_host_valid	`Error`	0.01	test_hostha_simulator.py
test_01_host_ping_on_alert	`Error`	0.07	test_host_ping.py
test_01_host_ping_on_alert	`Error`	0.07	test_host_ping.py
test_01_browser_migrate_template	`Error`	15.35	test_image_store_object_migration.py
test_01_invalid_upgrade_kubernetes_cluster	`Failure`	261.55	test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster	`Failure`	234.03	test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster	`Failure`	232.03	test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster	`Failure`	223.40	test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster	`Failure`	228.62	test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster	`Failure`	227.60	test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster	`Failure`	344.10	test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster	`Failure`	237.35	test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle	`Error`	88.01	test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version	`Error`	0.12	test_kubernetes_supported_versions.py
login_test_saml_user	`Error`	2.92	test_login.py
test_01_deployVMInSharedNetwork	`Error`	75.28	test_network.py
test_03_destroySharedNetwork	`Failure`	1.09	test_network.py
ContextSuite context=TestSharedNetwork>:teardown	`Error`	2.18	test_network.py
test_oobm_issue_power_cycle	`Error`	3.30	test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_off	`Error`	3.29	test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_on	`Error`	3.30	test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_reset	`Error`	3.30	test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_soft	`Error`	3.29	test_outofbandmanagement_nestedplugin.py
test_oobm_issue_power_status	`Error`	2.22	test_outofbandmanagement_nestedplugin.py
test_oobm_background_powerstate_sync	`Failure`	21.65	test_outofbandmanagement.py
test_oobm_background_powerstate_sync	`Error`	21.65	test_outofbandmanagement.py
test_oobm_configure_default_driver	`Error`	0.06	test_outofbandmanagement.py
test_oobm_configure_invalid_driver	`Error`	0.05	test_outofbandmanagement.py
test_oobm_disable_feature_invalid	`Error`	0.04	test_outofbandmanagement.py
test_oobm_disable_feature_valid	`Error`	1.13	test_outofbandmanagement.py
test_oobm_enable_feature_invalid	`Error`	0.04	test_outofbandmanagement.py
test_oobm_enable_feature_valid	`Error`	1.12	test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones	`Error`	11.83	test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones	`Error`	11.83	test_outofbandmanagement.py
test_oobm_issue_power_cycle	`Error`	4.34	test_outofbandmanagement.py
test_oobm_issue_power_cycle	`Error`	4.34	test_outofbandmanagement.py
test_oobm_issue_power_off	`Error`	4.30	test_outofbandmanagement.py
test_oobm_issue_power_off	`Error`	4.30	test_outofbandmanagement.py
test_oobm_issue_power_on	`Error`	3.30	test_outofbandmanagement.py
test_oobm_issue_power_on	`Error`	3.30	test_outofbandmanagement.py
test_oobm_issue_power_reset	`Error`	4.34	test_outofbandmanagement.py
test_oobm_issue_power_reset	`Error`	4.34	test_outofbandmanagement.py
test_oobm_issue_power_soft	`Error`	4.33	test_outofbandmanagement.py
test_oobm_issue_power_soft	`Error`	4.34	test_outofbandmanagement.py
test_oobm_issue_power_status	`Error`	3.32	test_outofbandmanagement.py
test_oobm_issue_power_status	`Error`	3.32	test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership	`Error`	1.15	test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership	`Error`	1.15	test_outofbandmanagement.py
test_oobm_zchange_password	`Error`	2.20	test_outofbandmanagement.py
test_oobm_zchange_password	`Error`	2.20	test_outofbandmanagement.py
test_02_edit_primary_storage_tags	`Error`	0.02	test_primary_storage.py
test_01_primary_storage_scope_change	`Error`	0.08	test_primary_storage_scope.py
test_01_vpc_privategw_acl	`Error`	0.03	test_privategw_acl_ovs_gre.py
test_03_vpc_privategw_restart_vpc_cleanup	`Error`	0.02	test_privategw_acl_ovs_gre.py
test_05_vpc_privategw_check_interface	`Error`	0.02	test_privategw_acl_ovs_gre.py
test_01_vpc_privategw_acl	`Error`	53.80	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Error`	199.94	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Error`	200.88	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	`Error`	320.67	test_privategw_acl.py
test_01_purge_expunged_api_vm_start_date	`Error`	51.09	test_purge_expunged_vms.py
test_02_purge_expunged_api_vm_end_date	`Error`	47.38	test_purge_expunged_vms.py
test_03_purge_expunged_api_vm_start_end_date	`Error`	45.27	test_purge_expunged_vms.py
test_04_purge_expunged_api_vm_no_date	`Error`	43.13	test_purge_expunged_vms.py
test_05_purge_expunged_vm_service_offering	`Error`	271.11	test_purge_expunged_vms.py
test_06_purge_expunged_vm_background_task	`Error`	329.61	test_purge_expunged_vms.py
test_01_snapshot_root_disk	`Error`	5.34	test_snapshots.py
test_CreateTemplateWithDuplicateName	`Error`	20.75	test_templates.py
test_01_register_template_direct_download_flag	`Error`	0.18	test_templates.py
test_01_positive_tests_usage	`Error`	10.46	test_usage_events.py
test_01_ISO_usage	`Error`	1.09	test_usage.py
test_01_lb_usage	`Error`	4.25	test_usage.py
test_01_nat_usage	`Error`	8.34	test_usage.py
test_01_public_ip_usage	`Error`	1.07	test_usage.py
test_01_snapshot_usage	`Error`	22.68	test_usage.py
test_01_template_usage	`Error`	13.50	test_usage.py
test_01_vm_usage	`Error`	136.46	test_usage.py
test_01_volume_usage	`Error`	128.17	test_usage.py
test_01_vpn_usage	`Error`	8.48	test_usage.py
test_03_secured_to_nonsecured_vm_migration	`Error`	425.71	test_vm_life_cycle.py
test_10_attachAndDetach_iso	`Failure`	612.51	test_vm_life_cycle.py
test_12_start_vm_multiple_volumes_allocated	`Error`	12.65	test_vm_life_cycle.py
test_01_vmschedule_create	`Error`	0.12	test_vm_schedule.py
test_01_verify_ipv6_vpc	`Error`	611.24	test_vpc_ipv6.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	618.17	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	`Failure`	1018.54	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	469.89	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Failure`	578.74	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	578.75	test_vpc_redundant.py
test_02_cancel_host_maintenace_with_migration_jobs	`Error`	267.73	test_host_maintenance.py
test_disable_oobm_ha_state_ineligible	`Error`	0.06	test_hostha_kvm.py
test_hostha_configure_default_driver	`Error`	0.05	test_hostha_kvm.py
test_hostha_enable_ha_when_host_disabled	`Error`	0.05	test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconected	`Error`	0.05	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	0.04	test_hostha_kvm.py
test_hostha_kvm_host_degraded	`Error`	0.04	test_hostha_kvm.py
test_hostha_kvm_host_fencing	`Error`	0.04	test_hostha_kvm.py
test_hostha_kvm_host_recovering	`Error`	0.04	test_hostha_kvm.py
test_remove_ha_provider_not_possible	`Error`	0.04	test_hostha_kvm.py

DaanHoogland · 2024-07-13T19:44:10Z

@blueorangutan test alma9 kvm-alma9

blueorangutan · 2024-07-13T19:46:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

blueorangutan · 2024-07-14T10:37:27Z

[SF] Trillian test result (tid-10824)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 51626 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8347-t10824-kvm-alma9.zip
Smoke tests completed. 136 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_06_purge_expunged_vm_background_task	`Failure`	337.45	test_purge_expunged_vms.py

quota tariff positions
aecfb2f

boring-cyborgBot added the component:quota label Dec 12, 2023

JoaoJandre changed the title ~~quota tariff positions~~Quota tariff orderDec 12, 2023

DaanHoogland approved these changes Dec 12, 2023
View reviewed changes

github-actionsBot added the status:has-conflicts label Dec 18, 2023

Merge remote-tracking branch 'origin/main' into quota-tariff-order
0104ded

github-actionsBot removed the status:has-conflicts label Dec 19, 2023

github-actionsBot added the status:has-conflicts label Jan 9, 2024

JoaoJandre added 3 commits January 29, 2024 13:09

Create integration test
72f0cc2

Merge remote-tracking branch 'origin/main' into quota-tariff-order
418f78a

change sql file
c388bea

boring-cyborgBot added component:integration-test Python Warning... Python code Ahead! labels Feb 5, 2024

github-actionsBot removed the status:has-conflicts label Feb 5, 2024

Merge remote-tracking branch 'origin/main' into quota-tariff-order
2860a2d

github-actionsBot added the status:has-conflicts label Feb 8, 2024

github-actionsBot removed the status:has-conflicts label Feb 8, 2024

DaanHoogland added this to the 4.20.0.0 milestone Feb 9, 2024

GutoVeronezi reviewed Feb 15, 2024
View reviewed changes

Merge remote-tracking branch 'origin/main' into quota-tariff-order
1b1fa6b

github-actionsBot removed the status:has-conflicts label Jun 11, 2024

github-actionsBot added the status:has-conflicts label Jun 13, 2024

Merge remote-tracking branch 'origin/main' into quota-tariff-order
f0923dd

github-actionsBot removed the status:has-conflicts label Jun 14, 2024

Merge remote-tracking branch 'origin/main' into quota-tariff-order
9d31172

bernardodemarco approved these changes Jul 11, 2024
View reviewed changes

DaanHoogland merged commit b9c7275 into apache:mainJul 14, 2024

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 23, 2024
Quota tariff order (apache#8347)
05c6eba

Uh oh!

Conversation

JoaoJandre commented Dec 12, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

How Has This Been Tested?

Uh oh!

codecovBot commented Dec 12, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

JoaoJandre commented Dec 13, 2023

Uh oh!

github-actionsBot commented Dec 18, 2023

Uh oh!

github-actionsBot commented Jan 9, 2024

Uh oh!

JoaoJandre commented Feb 5, 2024

Uh oh!

github-actionsBot commented Feb 8, 2024

Uh oh!

JoaoJandre commented Feb 14, 2024

Uh oh!

blueorangutan commented Feb 14, 2024

Uh oh!

blueorangutan commented Feb 14, 2024

Uh oh!

DaanHoogland commented Feb 15, 2024

Uh oh!

blueorangutan commented Feb 15, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented Jun 3, 2024

Uh oh!

JoaoJandre commented Jun 11, 2024

Uh oh!

blueorangutan commented Jun 11, 2024

Uh oh!

blueorangutan commented Jun 11, 2024

Uh oh!

JoaoJandre commented Jun 11, 2024

Uh oh!

DaanHoogland commented Jun 12, 2024

Uh oh!

github-actionsBot commented Jun 13, 2024

Uh oh!

DaanHoogland commented Jul 10, 2024

Uh oh!

blueorangutan commented Jul 10, 2024

Uh oh!

blueorangutan commented Jul 10, 2024

Uh oh!

DaanHoogland commented Jul 11, 2024

Uh oh!

blueorangutan commented Jul 11, 2024

Uh oh!

bernardodemarco left a comment

Choose a reason for hiding this comment

Tests Descriptions

quotaTariffCreate API

quotaTariffUpdate API

lastTariffs preset variable

Uh oh!

bernardodemarco commented Jul 11, 2024

Uh oh!

blueorangutan commented Jul 12, 2024

Uh oh!

DaanHoogland commented Jul 12, 2024

Uh oh!

DaanHoogland commented Jul 12, 2024

Uh oh!

blueorangutan commented Jul 12, 2024

JoaoJandre commented Dec 12, 2023•
edited
Loading

codecovBot commented Dec 12, 2023•
edited
Loading

`quotaTariffCreate` API

`quotaTariffUpdate` API

`lastTariffs` preset variable