Skip to content

Fixup test_list_volumes.py failure - #8392

Closed
vishesh92 wants to merge 5 commits into
apache:mainfrom
shapeblue:fixup-e2e-list-volumes-failure
Closed

Fixup test_list_volumes.py failure#8392
vishesh92 wants to merge 5 commits into
apache:mainfrom
shapeblue:fixup-e2e-list-volumes-failure

Conversation

@vishesh92

@vishesh92vishesh92 commented Dec 21, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR fixes intermittent test failures due left over volumes from previous test runs by waiting for their cleanup.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborgboring-cyborgBot added component:integration-test Python Warning... Python code Ahead! labels Dec 21, 2023
@vishesh92

vishesh92 commented Dec 21, 2023

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

blueorangutan commented Dec 21, 2023

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecovBot commented Dec 21, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1411da1) 30.88% compared to head (49f385c) 26.10%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #8392 +/- ##
============================================
- Coverage 30.88% 26.10% -4.78% + Complexity 34079 27910 -6169 
============================================
Files 5341 5341 Lines 374861 374861 Branches 54518 54518 ============================================
- Hits 115769 97865 -17904 - Misses 243825 263898 +20073 + Partials 15267 13098 -2169
FlagCoverage Δ
simulator-marvin-tests18.29% <ø> (-6.53%)⬇️
uitests4.39% <ø> (ø)
unit-tests16.46% <ø> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sureshanaparti
sureshanaparti reviewed Dec 21, 2023
View reviewed changes
Comment threadtest/integration/smoke/test_list_volumes.py Outdated
@vishesh92@sureshanaparti
Update test/integration/smoke/test_list_volumes.py
7283100
Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
@sureshanaparti

sureshanaparti commented Dec 21, 2023

Copy link
Copy Markdown
Contributor

@vishesh92 can you update the description (about the issue, fix)

@blueorangutan

blueorangutan commented Dec 21, 2023

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8109

@shwstppr

shwstppr commented Dec 21, 2023

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

blueorangutan commented Dec 21, 2023

Copy link
Copy Markdown

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sureshanaparti
sureshanaparti approved these changes Dec 21, 2023
View reviewed changes

@sureshanapartisureshanaparti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@vishesh92

vishesh92 commented Dec 21, 2023

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

blueorangutan commented Dec 21, 2023

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

blueorangutan commented Dec 21, 2023

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8110

@vishesh92
vishesh92force-pushed the fixup-e2e-list-volumes-failure branch from 21fa3f5 to c2c2ae1CompareDecember 21, 2023 09:04
@vishesh92
vishesh92force-pushed the fixup-e2e-list-volumes-failure branch from c2c2ae1 to 3b47c56CompareDecember 21, 2023 09:05
@vishesh92

vishesh92 commented Dec 21, 2023

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

blueorangutan commented Dec 21, 2023

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@vishesh92

vishesh92 commented Dec 21, 2023•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@shwstppr@sureshanaparti After a discussion with @DaanHoogland, I have made changes to wait for cleanup of volumes after every test run to ensure that we don't have to wait for cleanup in all tests.

There might still be failures if some volume is not added in cleanup or there is a failure while cleaning up a volume.

@blueorangutan

blueorangutan commented Dec 21, 2023

Copy link
Copy Markdown

Packaging result [SF]: ✖️ el7 ✔️ debian. SL-JID 8112

@shwstppr

shwstppr commented Dec 21, 2023

Copy link
Copy Markdown
Contributor

@vishesh92 cc @DaanHoogland@sureshanaparti@weizhouapache
I do not like the idea of the listing tests failing if there are other resources present. I would prefer reverting the original PR to have stable results for the RC unless others are in line with the changes

@weizhouapache

weizhouapache commented Dec 21, 2023

Copy link
Copy Markdown
Member

@vishesh92 cc @DaanHoogland@sureshanaparti@weizhouapache I do not like the idea of the listing tests failing if there are other resources present. I would prefer reverting the original PR to have stable results for the RC unless others are in line with the changes

+1

@DaanHoogland

DaanHoogland commented Dec 21, 2023

Copy link
Copy Markdown
Contributor

@vishesh92 cc @DaanHoogland@sureshanaparti@weizhouapache I do not like the idea of the listing tests failing if there are other resources present. I would prefer reverting the original PR to have stable results for the RC unless others are in line with the changes

I think the changes here are good. What PR do you mean to revert @shwstppr ?

@shwstppr

shwstppr commented Dec 21, 2023

Copy link
Copy Markdown
Contributor

@DaanHoogland#8281
Yes, changes in this are fine but even with them I won't be able to successfully run some of the tests added in #8281 if my env already has some resources

@shwstpprshwstppr mentioned this pull request Dec 21, 2023
Merged
13 tasks
@blueorangutan

blueorangutan commented Dec 21, 2023

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8114

@yadvr

yadvr commented Dec 21, 2023

Copy link
Copy Markdown
Member

@blueorangutan test

@blueorangutan

blueorangutan commented Dec 21, 2023

Copy link
Copy Markdown

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@github-actions

github-actionsBot commented Dec 21, 2023

Copy link
Copy Markdown

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@vishesh92vishesh92 mentioned this pull request Dec 28, 2023
Merged
13 tasks
@vishesh92

vishesh92 commented Dec 28, 2023

Copy link
Copy Markdown
MemberAuthor

Included in #8410

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHooglandDaanHooglandDaanHoogland approved these changes
@sureshanapartisureshanapartiAwaiting requested review from sureshanaparti

Assignees

No one assigned

Labels

component:integration-testcomponent:marvinPythonWarning... Python code Ahead!status:has-conflicts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vishesh92@blueorangutan@sureshanaparti@shwstppr@weizhouapache@DaanHoogland@yadvr