[4.10] CLOUDSTACK-7985: assignVM in Advanced zone with Security Groups by ustcweizhou · Pull Request #844 · apache/cloudstack

ustcweizhou · 2015-09-16T13:10:06Z

This commit contains the following changes:
(1) implementation of assignVM in Advanced zone with Security Groups
(2) keep the default nic on shared network when assignVM
(3) allow migrate vm from/to project;
(4) UI change for selecting account/project/network

asfbot · 2015-09-16T13:11:59Z

cloudstack-pull-rats #636 SUCCESS
This pull request looks good

asfbot · 2015-09-16T14:21:07Z

cloudstack-pull-analysis #575 UNSTABLE
Looks like there's a problem with this pull request

miguelaferreira · 2015-09-16T18:25:29Z

Apache Jenkins build reports 5 failing tests (https://builds.apache.org/job/cloudstack-pull-analysis/575/testReport/)

I'm seeing the same tests failing in other PRs, and given that recently master has been broken quite often, it might be that the failing tests have nothing to do with this PR.

DaanHoogland · 2015-09-17T11:43:19Z

@ustcweizhou @miguelaferreira @karuturi @remibergsma so no merges till this is fixed?

wilderrodrigues · 2015-09-17T11:51:46Z

@ustcweizhou ,

Which tests did you execute?

I would say: no merge until it's fixed, tested by @ustcweizhou and he let us know how we should be able to test.

Cheers,
Wilder

DaanHoogland · 2015-09-17T12:08:56Z

@wilderrodrigues that is not fair, it is not @ustcweizhou 's bug that needs fixing!

miguelaferreira · 2015-09-17T12:12:12Z

@DaanHoogland @wilderrodrigues @ustcweizhou I agree with Daan, the problem is most likely elsewhere. But I also agree with Wilder, first we need to figure out where the problem is, fix it, rebase all PRs to branch off after the fix and then continue the normal process. We can't be merging things hoping all will be well.

@ustcweizhou could you please try rebasing on master to see if the build for this PR still fails? it would be something like this:

git pull --rebase upstream master

Where upstream is the https://github.com/apache/cloudstack remote

asfbot · 2015-09-17T12:27:09Z

cloudstack-pull-rats #644 SUCCESS
This pull request looks good

miguelaferreira · 2015-09-17T12:28:54Z

Thanks for rebasing @ustcweizhou

The pull-analysis is now running.
https://builds.apache.org/job/cloudstack-pull-analysis/583/
Lets keep an eye on it, hopefully the problem will be gone.

ustcweizhou · 2015-09-17T12:29:57Z

@DaanHoogland @miguelaferreira @wilderrodrigues
I have rebase with the lastest master, and force push to github.
let's see if it will be fixed.

miguelaferreira · 2015-09-17T13:33:24Z

The build job already passed the point it had failed before (fingers-crossed)

asfbot · 2015-09-17T13:36:21Z

cloudstack-pull-analysis #583 SUCCESS
This pull request looks good

wilderrodrigues · 2015-09-17T14:00:43Z

Hi @ustcweizhou ,

I will 👎 this PR until we get to know which integration tests you executed, against which environment and the steps so we can do the same.

Cheers,
Wilder

ustcweizhou · 2015-09-23T07:01:12Z

@wilderrodrigues

test cases

 1. advanced zone
(1) a shared network for domain domain1.
account1: in domain 1, one isolated network
acocunt2: in domain 1, two isolated networks
project1: in domain 1, no network
account3: in domain 2, one isolated network.
(2) assign vm1 (account1, isolated network) to account2. expectation: fail, new owner is account2, but no network attached to the vm after assignment.
assign vm2 (accoung2, isolated network) to account1. expectation: succeed. new owner is account1, one isolated network attached to vm.
assign vm3 (account1, shared network) to account2. expectation: succeed. new owner is account2, shared network attached to vm.
assign vm4 (account1, shared network) to account3. expectation: succeed. new owner is account3, one isolated network attached to vm.
assign vm5 (account1, shared network) to project1. expectation: succeed. new owner is project1, one isolated network created and attached to vm
2. advanced zone with security groups
(1) a shared network 1 for domain domain1.
a shared network 2 for domain domain2.
account1: in domain 1
account2: in domain 1
account3: in domain 2
(2) assign vm1 ((account1, shared network) to account2. expectation: succeed. new owner is account2, shared network 1 attached to vm, security group applied.
assign vm1 ((account1, shared network) to account3. expectation: succeed. new owner is account3, shared network 2 attached to vm, security group applied.

ustcweizhou · 2015-10-05T06:56:08Z

guys, anyone has update ?

wilderrodrigues · 2015-10-07T12:02:11Z

Hi @ustcweizhou

Thanks for the details. Are there some integration tests that we could use to cover the cases you described?

I can runt the following tests to make sure it doesn't break existing features:

echo "Running tests with required_hardware=true"
nosetests --with-marvin --marvin-config=[MARVIN_CONFIG_HERE] -s -a tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
component/test_routers_iptables_default_policy.py \
component/test_vpc_router_nics.py
echo "Running tests with required_hardware=false"
nosetests --with-marvin --marvin-config=[MARVIN_CONFIG_HERE] -s -a tags=advanced,required_hardware=false \
smoke/test_routers.py \
smoke/test_network_acl.py \
smoke/test_privategw_acl.py \
smoke/test_reset_vm_on_reboot.py \
smoke/test_vm_life_cycle.py \
smoke/test_vpc_vpn.py \
smoke/test_service_offerings.py \
component/test_vpc_offerings.py \
component/test_vpc_routers.py

But I'm not sure if those tests will cover all of your changes.

Cheers,
Wilder

wilderrodrigues · 2015-10-07T15:50:28Z

Hi @ustcweizhou @DaanHoogland @remibergsma @karuturi @miguelaferreira

I executed the tests on my side. Despite some exceptions with network cleanup and the VPC tests that will pass only after PR #908 gets merged, everything went fine.

This PR L1/2GTM (Look 1/2 Good to Me) taking into account that it doesn't break existing features. I need more time to tests the security groups bit - or @ustcweizhou can test it manually, or perhaps someone else can do help on that.

Results:

Create a redundant vpc with two networks with two vms in each network ... === TestName: test_01a_create_redundant_VPC | Status : FAILED ===
FAIL
=== TestName: test_01a_create_redundant_VPC | Status : EXCEPTION ===
ERROR
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
=== TestName: test_01_single_VPC_iptables_policies | Status : EXCEPTION ===
ERROR
Create a vpc with two networks with two vms in each network ... === TestName: test_01_VPC_nics_after_destroy | Status : SUCCESS ===
ok
=== TestName: test_01_VPC_nics_after_destroy | Status : EXCEPTION ===
ERROR
Test router internal advanced zone ... === TestName: test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS ===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS ===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : SUCCESS ===
ok
test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_privategw_acl | Status : SUCCESS ===
ok
Test reset virtual machine on reboot ... === TestName: test_01_reset_vm_on_reboot | Status : SUCCESS ===
ok
Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : SUCCESS ===
ok
Test migrate VM ... SKIP: At least two hosts should be present in the zone for migration
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS ===
ok
Test to create service offering ... === TestName: test_01_create_service_offering | Status : SUCCESS ===
ok
Test to update existing service offering ... === TestName: test_02_edit_service_offering | Status : SUCCESS ===
ok
Test to delete service offering ... === TestName: test_03_delete_service_offering | Status : SUCCESS ===
ok
Test create VPC offering ... === TestName: test_01_create_vpc_offering | Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName: test_03_vpc_off_without_lb | Status : EXCEPTION ===
ERROR
Test VPC offering without static NAT service ... === TestName: test_04_vpc_off_without_static_nat | Status : EXCEPTION ===
ERROR
Test VPC offering without port forwarding service ... === TestName: test_05_vpc_off_without_pf | Status : EXCEPTION ===
ERROR
Test VPC offering with invalid services ... === TestName: test_06_vpc_off_invalid_services | Status : SUCCESS ===
ok
Test update VPC offering ... === TestName: test_07_update_vpc_off | Status : SUCCESS ===
ok
Test list VPC offering ... === TestName: test_08_list_vpc_off | Status : SUCCESS ===
ok
test_09_create_redundant_vpc_offering (integration.component.test_vpc_offerings.TestVPCOffering) ... === TestName: test_09_create_redundant_vpc_offering | Status : SUCCESS ===
ok
Test start/stop of router after addition of one guest network ... === TestName: test_01_start_stop_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test reboot of router after addition of one guest network ... === TestName: test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to change service offering of router after addition of one guest network ... === TestName: test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test destroy of router after addition of one guest network ... === TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to stop and start router after creation of VPC ... === TestName: test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
ok
Test to reboot the router after creating a VPC ... === TestName: test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
ok
Tests to change service offering of the Router after ... === TestName: test_04_change_service_offerring_vpc | Status : SUCCESS ===
ok
Test to destroy the router after creating a VPC ... === TestName: test_05_destroy_router_after_creating_vpc | Status : SUCCESS ===
ok

ustcweizhou · 2015-10-09T11:35:42Z

@wilderrodrigues thanks for you testing. I believe this PR will not impact the current network/vr/storage.
It will only change the owner of a vm, and add the vm to a network /security group if applicable.

miguelaferreira · 2015-10-09T12:03:11Z

@ustcweizhou may I ask you if you believe that the change in this PR will not impact the areas you mention because you've tested it (even if manually)? Or because you assume that this change is isolated from hose areas of the system?

We have had production issues in the recent past due to "isolated" changes to plugins for hypervisors we don't even use. Therefore, the urge for testing!

ustcweizhou · 2015-10-12T07:28:35Z

@miguelaferreira I have tested the test cases listed above. I think it is isolated from other areas.

I agree more and careful testing are better. Can you show more details in your issues so maybe we can get some lessons from them?

miguelaferreira · 2015-10-12T07:36:20Z

@ustcweizhou It is not clear to me if you tested the same things @wilderrodrigues did, or if you tested "the security groups bit". Would you be so kind as to make that explicit.

Regarding the remark I made about seemingly isolated code: the PR that fixed the issue we had in production is #761. If you are interested, please have a look at the problem description and solution (arguably no the best!) in the PR comments.

ustcweizhou · 2015-10-12T08:11:41Z

@miguelaferreira

no, I did not test the same as @wilderrodrigues .
I've tested advanced zone (without security groups), it works fine. For Advanced zone with security group, I used this code in 4.2.1 for long time, then I ported to mainstream.sorry I did not test it in advanced zone with SG. However, compared to the implementation for Basic zone, I think this code is good.
Different from PR Have HyperV behave in 4.4 and return null instead of false #761 which might be called by other functions, this PR is just an implementation for AssignVM in advanced zone with SG. The worst problem I can see is that this functionality does not work, but it will never impact other functionalities.

miguelaferreira · 2015-10-12T08:13:56Z

Thanks for clarifying @ustcweizhou
I guess that we then need to wait for when @wilderrodrigues will have time to test the SGs.

ustcweizhou · 2015-10-12T08:19:13Z

no problem for me.
it is always good to get feedback from community. @miguelaferreira
I have some features/improvements to be ported from old CS to mainstream.
Looking forward to getting more feedback from you guys in the future.

DaanHoogland · 2015-10-19T08:40:39Z

@miguelaferreira @remibergsma are you satisfied with this PR, now?

miguelaferreira · 2015-10-19T08:45:17Z

@DaanHoogland I think the status is still the same as of 7 days ago. Or am I missing something?

DaanHoogland · 2015-10-19T08:51:24Z

So that means the SG tests are missing still. Ok, I will add it to my testing backlog.

DaanHoogland · 2015-10-31T19:13:12Z

did the regular regression suite in my sbp provided bubble and all passed.

network:

Create a redundant VPC with two networks with two VMs in each network ... === TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status : SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and check default routes ... === TestName: test_02_redundant_VPC_default_routes | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... === TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
Stop existing router, add a PF rule and check we can access the VM ... === TestName: test_isolate_network_FW_PF_default_routes | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_RVR_Network_FW_PF_SSH_default_routes | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test nics after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status : SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
Check the password file in the Router VM ... === TestName: test_isolate_network_password_server | Status : SUCCESS ===
ok
Check that the /etc/dhcphosts.txt doesn't contain duplicate IPs ... === TestName: test_router_dhcphosts | Status : SUCCESS ===
ok
Test to create Load balancing rule with source NAT ... === TestName: test_01_create_lb_rule_src_nat | Status : SUCCESS ===
ok
Test to create Load balancing rule with non source NAT ... === TestName: test_02_create_lb_rule_non_nat | Status : SUCCESS ===
ok
Test for assign & removing load balancing rule ... === TestName: test_assign_and_removal_lb | Status : SUCCESS ===
ok
Test to verify access to loadbalancer haproxy admin stats page ... === TestName: test02_internallb_haproxy_stats_on_all_interfaces | Status : SUCCESS ===
ok
Test create, assign, remove of an Internal LB with roundrobin http traffic to 3 vm's ... === TestName: test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Status : SUCCESS ===
ok
Test SSVM Internals ... === TestName: test_03_ssvm_internals | Status : SUCCESS ===
ok
Test CPVM Internals ... === TestName: test_04_cpvm_internals | Status : SUCCESS ===
ok
Test stop SSVM ... === TestName: test_05_stop_ssvm | Status : SUCCESS ===
ok
Test stop CPVM ... === TestName: test_06_stop_cpvm | Status : SUCCESS ===
ok
Test reboot SSVM ... === TestName: test_07_reboot_ssvm | Status : SUCCESS ===
ok
Test reboot CPVM ... === TestName: test_08_reboot_cpvm | Status : SUCCESS ===
ok
Test destroy SSVM ... === TestName: test_09_destroy_ssvm | Status : SUCCESS ===
ok
Test destroy CPVM ... === TestName: test_10_destroy_cpvm | Status : SUCCESS ===
ok
Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 29 tests in 13041.270s
OK

and vpc:

Test router internal advanced zone ... === TestName: test_02_router_internal_adv | Status : SUCCESS ===
ok
Test restart network ... === TestName: test_03_restart_network_cleanup | Status : SUCCESS ===
ok
Test router basic setup ... === TestName: test_05_router_basic | Status : SUCCESS ===
ok
Test router advanced setup ... === TestName: test_06_router_advanced | Status : SUCCESS ===
ok
Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS ===
ok
Test start router ... === TestName: test_08_start_router | Status : SUCCESS ===
ok
Test reboot router ... === TestName: test_09_reboot_router | Status : SUCCESS ===
ok
test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_privategw_acl | Status : SUCCESS ===
ok
Test reset virtual machine on reboot ... === TestName: test_01_reset_vm_on_reboot | Status : SUCCESS ===
ok
Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status : SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName: test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status : SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status : SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status : SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status : SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status : SUCCESS ===
ok
Test migrate VM ... SKIP: At least two hosts should be present in the zone for migration
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm | Status : SUCCESS ===
ok
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : SUCCESS ===
ok
Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS ===
ok
Test to create service offering ... === TestName: test_01_create_service_offering | Status : SUCCESS ===
ok
Test to update existing service offering ... === TestName: test_02_edit_service_offering | Status : SUCCESS ===
ok
Test to delete service offering ... === TestName: test_03_delete_service_offering | Status : SUCCESS ===
ok
Test for delete account ... === TestName: test_delete_account | Status : SUCCESS ===
ok
Test for Associate/Disassociate public IP address for admin account ... === TestName: test_public_ip_admin_account | Status : SUCCESS ===
ok
Test for Associate/Disassociate public IP address for user account ... === TestName: test_public_ip_user_account | Status : SUCCESS ===
ok
Test for release public IP address ... === TestName: test_releaseIP | Status : SUCCESS ===
ok
Test create VPC offering ... === TestName: test_01_create_vpc_offering | Status : SUCCESS ===
ok
Test VPC offering without load balancing service ... === TestName: test_03_vpc_off_without_lb | Status : SUCCESS ===
ok
Test VPC offering without static NAT service ... === TestName: test_04_vpc_off_without_static_nat | Status : SUCCESS ===
ok
Test VPC offering without port forwarding service ... === TestName: test_05_vpc_off_without_pf | Status : SUCCESS ===
ok
Test VPC offering with invalid services ... === TestName: test_06_vpc_off_invalid_services | Status : SUCCESS ===
ok
Test update VPC offering ... === TestName: test_07_update_vpc_off | Status : SUCCESS ===
ok
Test list VPC offering ... === TestName: test_08_list_vpc_off | Status : SUCCESS ===
ok
test_09_create_redundant_vpc_offering (integration.component.test_vpc_offerings.TestVPCOffering) ... === TestName: test_09_create_redundant_vpc_offering | Status : SUCCESS ===
ok
Test start/stop of router after addition of one guest network ... === TestName: test_01_start_stop_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test reboot of router after addition of one guest network ... === TestName: test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to change service offering of router after addition of one guest network ... === TestName: test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test destroy of router after addition of one guest network ... === TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : SUCCESS ===
ok
Test to stop and start router after creation of VPC ... === TestName: test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
ok
Test to reboot the router after creating a VPC ... === TestName: test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
ok
Tests to change service offering of the Router after ... === TestName: test_04_change_service_offerring_vpc | Status : SUCCESS ===
ok
Test to destroy the router after creating a VPC ... === TestName: test_05_destroy_router_after_creating_vpc | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 44 tests in 8842.630s
OK (SKIP=1)

the skip is because for migration at least 2 hosts are needed

LGTM (limitation of warranty: security groups are not covered by the standard regression tests) I will run these test in an advanced zone with sg enabled as well, time permitting. next specific tests are to be coded for ensuring sg. For now Wei's personal testing should do.

yadvr · 2016-01-27T14:58:14Z

@ustcweizhou Can you please meld the commits into a single commit, and incorporate any remaining changes asked in the review?

Ping, can we have a re-review

ustcweizhou · 2016-03-09T07:15:12Z

rebased, and fixed an issue in assignvm to project.

GabrielBrascher · 2016-03-09T23:51:00Z

 message.alert.state.detected=Alert state detected
 message.allow.vpn.access=Please enter a username and password of the user that you want to allow VPN access.
 message.apply.snapshot.policy=You have successfully updated your current snapshot policy.
+message.assign.instance.another=Please specify the account type, domain, account name and network (optional) of the new account. <br> If the default nic of the vm is on a shared network, CloudStack will check if the network can be used by the new account if you do not specify one network. <br> If the default nic of the vm is on a isolated network, and the new account has more one isolated networks, you should specify one.


Hi @ustcweizhou, just pointing a small typo: "on a isolated network" => "on an isolated network". Thanks.

yadvr · 2016-05-02T10:23:45Z

@ustcweizhou please rebase against latest master and push -f, update on status of your PR

bvbharatk · 2016-06-03T02:45:37Z

ACS CI BVT Run

Sumarry:
Build Number 117
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3

Link to logs Folder (search by build_no):https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

…for selecting account/project/network

ustcweizhou · 2016-12-27T11:48:47Z

rebased with latest master

DaanHoogland · 2017-02-08T13:41:37Z

@blueorangutan package

blueorangutan · 2017-02-08T13:42:25Z

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-02-08T14:09:46Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-475

DaanHoogland · 2017-02-08T14:14:19Z

@blueorangutan test

blueorangutan · 2017-02-08T14:14:26Z

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2017-02-08T23:46:25Z

Trillian test result (tid-807)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34311 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr844-t807-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Test completed. 47 look ok, 2 have error(s)

Test	Result	Time (s)	Test File
test_02_redundant_VPC_default_routes	`Failure`	869.41	test_vpc_redundant.py
test_04_rvpc_privategw_static_routes	`Failure`	340.78	test_privategw_acl.py
test_01_vpc_site2site_vpn	Success	155.48	test_vpc_vpn.py
test_01_vpc_remote_access_vpn	Success	66.21	test_vpc_vpn.py
test_01_redundant_vpc_site2site_vpn	Success	250.93	test_vpc_vpn.py
test_02_VPC_default_routes	Success	277.36	test_vpc_router_nics.py
test_01_VPC_nics_after_destroy	Success	520.18	test_vpc_router_nics.py
test_05_rvpc_multi_tiers	Success	518.31	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	Success	1416.80	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	Success	548.16	test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	Success	1285.50	test_vpc_redundant.py
test_09_delete_detached_volume	Success	156.67	test_volumes.py
test_08_resize_volume	Success	156.42	test_volumes.py
test_07_resize_fail	Success	161.53	test_volumes.py
test_06_download_detached_volume	Success	156.38	test_volumes.py
test_05_detach_volume	Success	155.81	test_volumes.py
test_04_delete_attached_volume	Success	151.29	test_volumes.py
test_03_download_attached_volume	Success	156.36	test_volumes.py
test_02_attach_volume	Success	89.64	test_volumes.py
test_01_create_volume	Success	712.28	test_volumes.py
test_03_delete_vm_snapshots	Success	275.25	test_vm_snapshots.py
test_02_revert_vm_snapshots	Success	95.73	test_vm_snapshots.py
test_01_create_vm_snapshots	Success	158.70	test_vm_snapshots.py
test_deploy_vm_multiple	Success	242.59	test_vm_life_cycle.py
test_deploy_vm	Success	0.03	test_vm_life_cycle.py
test_advZoneVirtualRouter	Success	0.02	test_vm_life_cycle.py
test_10_attachAndDetach_iso	Success	26.69	test_vm_life_cycle.py
test_09_expunge_vm	Success	125.26	test_vm_life_cycle.py
test_08_migrate_vm	Success	40.98	test_vm_life_cycle.py
test_07_restore_vm	Success	0.14	test_vm_life_cycle.py
test_06_destroy_vm	Success	130.88	test_vm_life_cycle.py
test_03_reboot_vm	Success	125.85	test_vm_life_cycle.py
test_02_start_vm	Success	10.18	test_vm_life_cycle.py
test_01_stop_vm	Success	40.34	test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName	Success	50.93	test_templates.py
test_08_list_system_templates	Success	0.03	test_templates.py
test_07_list_public_templates	Success	0.04	test_templates.py
test_05_template_permissions	Success	0.06	test_templates.py
test_04_extract_template	Success	5.16	test_templates.py
test_03_delete_template	Success	5.11	test_templates.py
test_02_edit_template	Success	90.18	test_templates.py
test_01_create_template	Success	20.31	test_templates.py
test_10_destroy_cpvm	Success	161.62	test_ssvm.py
test_09_destroy_ssvm	Success	133.57	test_ssvm.py
test_08_reboot_cpvm	Success	131.59	test_ssvm.py
test_07_reboot_ssvm	Success	133.50	test_ssvm.py
test_06_stop_cpvm	Success	131.78	test_ssvm.py
test_05_stop_ssvm	Success	133.68	test_ssvm.py
test_04_cpvm_internals	Success	1.15	test_ssvm.py
test_03_ssvm_internals	Success	3.27	test_ssvm.py
test_02_list_cpvm_vm	Success	0.13	test_ssvm.py
test_01_list_sec_storage_vm	Success	0.14	test_ssvm.py
test_01_snapshot_root_disk	Success	11.27	test_snapshots.py
test_04_change_offering_small	Success	239.73	test_service_offerings.py
test_03_delete_service_offering	Success	0.05	test_service_offerings.py
test_02_edit_service_offering	Success	0.08	test_service_offerings.py
test_01_create_service_offering	Success	0.14	test_service_offerings.py
test_02_sys_template_ready	Success	0.14	test_secondary_storage.py
test_01_sys_vm_start	Success	0.20	test_secondary_storage.py
test_09_reboot_router	Success	35.34	test_routers.py
test_08_start_router	Success	30.28	test_routers.py
test_07_stop_router	Success	10.19	test_routers.py
test_06_router_advanced	Success	0.06	test_routers.py
test_05_router_basic	Success	0.04	test_routers.py
test_04_restart_network_wo_cleanup	Success	5.70	test_routers.py
test_03_restart_network_cleanup	Success	60.56	test_routers.py
test_02_router_internal_adv	Success	1.06	test_routers.py
test_01_router_internal_basic	Success	0.58	test_routers.py
test_router_dns_guestipquery	Success	76.81	test_router_dns.py
test_router_dns_externalipquery	Success	0.09	test_router_dns.py
test_router_dhcphosts	Success	277.14	test_router_dhcphosts.py
test_router_dhcp_opts	Success	21.79	test_router_dhcphosts.py
test_01_updatevolumedetail	Success	0.08	test_resource_detail.py
test_01_reset_vm_on_reboot	Success	131.00	test_reset_vm_on_reboot.py
test_createRegion	Success	0.04	test_regions.py
test_create_pvlan_network	Success	5.22	test_pvlan.py
test_dedicatePublicIpRange	Success	0.42	test_public_ip_range.py
test_03_vpc_privategw_restart_vpc_cleanup	Success	490.42	test_privategw_acl.py
test_02_vpc_privategw_static_routes	Success	355.52	test_privategw_acl.py
test_01_vpc_privategw_acl	Success	92.22	test_privategw_acl.py
test_01_primary_storage_nfs	Success	35.96	test_primary_storage.py
test_createPortablePublicIPRange	Success	15.20	test_portable_publicip.py
test_createPortablePublicIPAcquire	Success	15.50	test_portable_publicip.py
test_isolate_network_password_server	Success	89.35	test_password_server.py
test_UpdateStorageOverProvisioningFactor	Success	0.15	test_over_provisioning.py
test_oobm_zchange_password	Success	30.89	test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership	Success	16.33	test_outofbandmanagement.py
test_oobm_issue_power_status	Success	10.26	test_outofbandmanagement.py
test_oobm_issue_power_soft	Success	15.34	test_outofbandmanagement.py
test_oobm_issue_power_reset	Success	15.52	test_outofbandmanagement.py
test_oobm_issue_power_on	Success	15.33	test_outofbandmanagement.py
test_oobm_issue_power_off	Success	15.37	test_outofbandmanagement.py
test_oobm_issue_power_cycle	Success	15.33	test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones	Success	82.83	test_outofbandmanagement.py
test_oobm_enable_feature_valid	Success	5.17	test_outofbandmanagement.py
test_oobm_enable_feature_invalid	Success	0.10	test_outofbandmanagement.py
test_oobm_disable_feature_valid	Success	5.21	test_outofbandmanagement.py
test_oobm_disable_feature_invalid	Success	0.13	test_outofbandmanagement.py
test_oobm_configure_invalid_driver	Success	0.12	test_outofbandmanagement.py
test_oobm_configure_default_driver	Success	0.09	test_outofbandmanagement.py
test_oobm_background_powerstate_sync	Success	23.43	test_outofbandmanagement.py
test_extendPhysicalNetworkVlan	Success	15.34	test_non_contigiousvlan.py
test_01_nic	Success	434.58	test_nic.py
test_releaseIP	Success	257.98	test_network.py
test_reboot_router	Success	393.45	test_network.py
test_public_ip_user_account	Success	10.29	test_network.py
test_public_ip_admin_account	Success	40.29	test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule	Success	67.03	test_network.py
test_network_rules_acquired_public_ip_2_nat_rule	Success	61.83	test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule	Success	124.22	test_network.py
test_delete_account	Success	272.95	test_network.py
test_02_port_fwd_on_non_src_nat	Success	55.69	test_network.py
test_01_port_fwd_on_src_nat	Success	111.78	test_network.py
test_nic_secondaryip_add_remove	Success	202.56	test_multipleips_per_nic.py
login_test_saml_user	Success	19.26	test_login.py
test_assign_and_removal_lb	Success	133.45	test_loadbalance.py
test_02_create_lb_rule_non_nat	Success	187.27	test_loadbalance.py
test_01_create_lb_rule_src_nat	Success	217.81	test_loadbalance.py
test_03_list_snapshots	Success	0.07	test_list_ids_parameter.py
test_02_list_templates	Success	0.04	test_list_ids_parameter.py
test_01_list_volumes	Success	0.03	test_list_ids_parameter.py
test_07_list_default_iso	Success	0.07	test_iso.py
test_05_iso_permissions	Success	0.07	test_iso.py
test_04_extract_Iso	Success	5.18	test_iso.py
test_03_delete_iso	Success	95.20	test_iso.py
test_02_edit_iso	Success	0.06	test_iso.py
test_01_create_iso	Success	21.00	test_iso.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	Success	194.05	test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	Success	148.85	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	Success	509.97	test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	Success	425.94	test_internal_lb.py
test_dedicateGuestVlanRange	Success	10.28	test_guest_vlan_range.py
test_UpdateConfigParamWithScope	Success	0.15	test_global_settings.py
test_rolepermission_lifecycle_update	Success	6.20	test_dynamicroles.py
test_rolepermission_lifecycle_list	Success	6.00	test_dynamicroles.py
test_rolepermission_lifecycle_delete	Success	6.20	test_dynamicroles.py
test_rolepermission_lifecycle_create	Success	5.92	test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates	Success	6.04	test_dynamicroles.py
test_role_lifecycle_update_role_inuse	Success	6.02	test_dynamicroles.py
test_role_lifecycle_update	Success	11.02	test_dynamicroles.py
test_role_lifecycle_list	Success	5.95	test_dynamicroles.py
test_role_lifecycle_delete	Success	10.97	test_dynamicroles.py
test_role_lifecycle_create	Success	5.92	test_dynamicroles.py
test_role_inuse_deletion	Success	5.88	test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers	Success	8.13	test_dynamicroles.py
test_role_account_acls	Success	8.38	test_dynamicroles.py
test_default_role_deletion	Success	6.00	test_dynamicroles.py
test_04_create_fat_type_disk_offering	Success	0.08	test_disk_offerings.py
test_03_delete_disk_offering	Success	0.04	test_disk_offerings.py
test_02_edit_disk_offering	Success	0.06	test_disk_offerings.py
test_02_create_sparse_type_disk_offering	Success	0.07	test_disk_offerings.py
test_01_create_disk_offering	Success	0.08	test_disk_offerings.py
test_deployvm_userdispersing	Success	20.62	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated	Success	20.63	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit	Success	65.75	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post	Success	10.40	test_deploy_vm_with_userdata.py
test_deployvm_userdata	Success	55.98	test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize	Success	5.99	test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize	Success	6.00	test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize	Success	207.49	test_deploy_vm_root_resize.py
test_deploy_vm_from_iso	Success	212.50	test_deploy_vm_iso.py
test_DeployVmAntiAffinityGroup	Success	86.22	test_affinity_groups.py
test_01_test_vm_volume_snapshot	Skipped	0.00	test_vm_snapshots.py
test_06_copy_template	Skipped	0.00	test_templates.py
test_static_role_account_acls	Skipped	0.03	test_staticroles.py
test_11_ss_nfs_version_on_ssvm	Skipped	0.02	test_ssvm.py
test_01_scale_vm	Skipped	0.00	test_scale_vm.py
test_01_primary_storage_iscsi	Skipped	0.04	test_primary_storage.py
test_nested_virtualization_vmware	Skipped	0.00	test_nested_virtualization.py
test_06_copy_iso	Skipped	0.00	test_iso.py
test_deploy_vgpu_enabled_vm	Skipped	0.03	test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support	Skipped	0.04	test_deploy_vgpu_enabled_vm.py

karuturi · 2017-02-09T06:21:11Z

merging

[4.10] CLOUDSTACK-7985: assignVM in Advanced zone with Security GroupsThis commit contains the following changes: (1) implementation of assignVM in Advanced zone with Security Groups (2) keep the default nic on shared network when assignVM (3) allow migrate vm from/to project; (4) UI change for selecting account/project/network * pr/844: CLOUDSTACK-7985: assignVM in Advanced zone with Security Groups CLOUDSTACK-7985: keep the default nic on shared network when assignVM CLOUDSTACK-7985: (1) allow migrate vm from/to project; (2) UI change for selecting account/project/network Signed-off-by: Rajani Karuturi <rajani.karuturi@accelerite.com>

ustcweizhou force-pushed the assignvm-master branch from 4896e47 to 2cf3c7cCompare September 17, 2015 12:25

ustcweizhou force-pushed the assignvm-master branch from 2cf3c7c to c497fddCompare October 29, 2015 20:39

ustcweizhou force-pushed the assignvm-master branch 2 times, most recently from e523ffd to 1fd66d6Compare November 16, 2015 09:15

ustcweizhou force-pushed the assignvm-master branch from 1fd66d6 to 59db8a9Compare November 30, 2015 08:16

ustcweizhou force-pushed the assignvm-master branch from 5e1a2b2 to c6558caCompare December 10, 2015 07:06

ustcweizhou force-pushed the assignvm-master branch from c6558ca to e89bb2dCompare March 1, 2016 08:30

ustcweizhou force-pushed the assignvm-master branch from e89bb2d to b13148bCompare March 9, 2016 07:14

GabrielBrascher reviewed Mar 9, 2016
View reviewed changes

ustcweizhou added 3 commits December 27, 2016 11:58

CLOUDSTACK-7985: (1) allow migrate vm from/to project; (2) UI change …
a1d2fba
…for selecting account/project/network

CLOUDSTACK-7985: keep the default nic on shared network when assignVM
3f16740

CLOUDSTACK-7985: assignVM in Advanced zone with Security Groups
ab0d04d

ustcweizhou force-pushed the assignvm-master branch from b13148b to ab0d04dCompare December 27, 2016 11:35

ustcweizhou changed the title ~~CLOUDSTACK-7985: assignVM in Advanced zone with Security Groups~~[4.10] CLOUDSTACK-7985: assignVM in Advanced zone with Security GroupsDec 27, 2016

asfgit merged commit ab0d04d into apache:masterFeb 9, 2017

Uh oh!

Conversation

ustcweizhou commented Sep 16, 2015

Uh oh!

asfbot commented Sep 16, 2015

Uh oh!

asfbot commented Sep 16, 2015

Uh oh!

miguelaferreira commented Sep 16, 2015

Uh oh!

DaanHoogland commented Sep 17, 2015

Uh oh!

wilderrodrigues commented Sep 17, 2015

Uh oh!

DaanHoogland commented Sep 17, 2015

Uh oh!

miguelaferreira commented Sep 17, 2015

Uh oh!

asfbot commented Sep 17, 2015

Uh oh!

miguelaferreira commented Sep 17, 2015

Uh oh!

ustcweizhou commented Sep 17, 2015

Uh oh!

miguelaferreira commented Sep 17, 2015

Uh oh!

asfbot commented Sep 17, 2015

Uh oh!

wilderrodrigues commented Sep 17, 2015

Uh oh!

ustcweizhou commented Sep 23, 2015

Uh oh!

ustcweizhou commented Oct 5, 2015

Uh oh!

wilderrodrigues commented Oct 7, 2015

Uh oh!

wilderrodrigues commented Oct 7, 2015

Uh oh!

ustcweizhou commented Oct 9, 2015

Uh oh!

miguelaferreira commented Oct 9, 2015

Uh oh!

ustcweizhou commented Oct 12, 2015

Uh oh!

miguelaferreira commented Oct 12, 2015

Uh oh!

ustcweizhou commented Oct 12, 2015

Uh oh!

miguelaferreira commented Oct 12, 2015

Uh oh!

ustcweizhou commented Oct 12, 2015

Uh oh!

DaanHoogland commented Oct 19, 2015

Uh oh!

miguelaferreira commented Oct 19, 2015

Uh oh!

DaanHoogland commented Oct 19, 2015

Uh oh!

DaanHoogland commented Oct 31, 2015

Uh oh!

yadvr commented Jan 27, 2016

Uh oh!

ustcweizhou commented Mar 9, 2016

Uh oh!

GabrielBrascherMar 9, 2016

Choose a reason for hiding this comment

Uh oh!

yadvr commented May 2, 2016

Uh oh!

bvbharatk commented Jun 3, 2016

ACS CI BVT Run

Uh oh!

ustcweizhou commented Dec 27, 2016

Uh oh!

DaanHoogland commented Feb 8, 2017

Uh oh!

blueorangutan commented Feb 8, 2017

Uh oh!

blueorangutan commented Feb 8, 2017

Uh oh!