assertion improvement on cluster DRS by DaanHoogland · Pull Request #8508 · apache/cloudstack

DaanHoogland · 2024-01-15T08:57:53Z

Description

This PR ...

Fixes: #8507

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2024-01-15T09:09:48Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.95%. Comparing base (d77998c) to head (bc4885a).
Report is 30 commits behind head on 4.19.

Additional details and impacted files

@@ Coverage Diff @@## 4.19 #8508 +/- ##
============================================
- Coverage 14.96% 14.95% -0.01% - Complexity 10997 10998 +1 
============================================
Files 5373 5377 +4 Lines 469188 469509 +321 Branches 60324 57223 -3101 ============================================
+ Hits 70217 70227 +10 - Misses 391196 391508 +312 + Partials 7775 7774 -1

Flag	Coverage Δ
uitests	`4.29% <ø> (-0.02%)`	⬇️
unittests	`15.66% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vishesh92

clgtm

shwstppr · 2024-06-03T07:36:52Z

@DaanHoogland should this target to 4.19 branch?

DaanHoogland · 2024-06-03T10:48:43Z

@shwstppr I can rebase if needed, but didn´t think it relevant or 4.19 (might be mistaking)

vishesh92 · 2024-06-03T10:54:24Z

@DaanHoogland Test is in 4.19 as well. So, we need to fix this for 4.19 as well.

github-actions · 2024-06-03T11:15:26Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

blueorangutan · 2024-06-12T11:08:04Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-06-12T12:08:39Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9897

vishesh92 · 2024-06-12T12:24:39Z

@blueorangutan package

blueorangutan · 2024-06-12T12:26:04Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-06-12T13:30:37Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9901

DaanHoogland · 2024-06-12T14:11:39Z

@blueorangutan test alma9 vmware-70u3

blueorangutan · 2024-06-12T14:14:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2024-06-13T08:57:44Z

[SF] Trillian test result (tid-10422)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9
Total time taken: 65623 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8508-t10422-vmware-70u3.zip
Smoke tests completed. 130 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_list_vms_metrics_admin	`Error`	3625.41	test_metrics_api.py
test_list_vms_metrics_history	`Error`	4.72	test_metrics_api.py
test_list_volumes_metrics_history	`Error`	3618.26	test_metrics_api.py

sureshanaparti · 2024-06-18T06:35:50Z

@blueorangutan package

blueorangutan · 2024-06-18T06:38:03Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-06-18T07:44:53Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9988

vishesh92 · 2024-06-18T07:49:48Z

@blueorangutan test alma9 vmware-70u3

blueorangutan · 2024-06-18T07:52:03Z

@vishesh92 a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests

blueorangutan · 2024-06-18T19:32:11Z

[SF] Trillian test result (tid-10483)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9
Total time taken: 40151 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8508-t10483-vmware-70u3.zip
Smoke tests completed. 104 look OK, 8 have errors, 19 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_restore_vm	`Error`	3614.72	test_restore_vm.py
test_02_restore_vm_allocated_root	`Error`	7.78	test_restore_vm.py
ContextSuite context=TestRestoreVM>:teardown	`Error`	15.15	test_restore_vm.py
test_01_prepare_and_cancel_shutdown	`Error`	2.60	test_safe_shutdown.py
test_02_trigger_shutdown	`Failure`	301.37	test_safe_shutdown.py
test_01_scale_vm	`Error`	0.03	test_scale_vm.py
test_02_scale_vm_negative_offering_disable_scaling	`Error`	0.02	test_scale_vm.py
test_03_scale_vm_negative_vm_disable_scaling	`Error`	0.02	test_scale_vm.py
test_04_scale_vm_with_user_account	`Error`	3.76	test_scale_vm.py
test_04_scale_vm_with_user_account	`Error`	3.77	test_scale_vm.py
test_05_scale_vm_dont_allow_disk_offering_change	`Error`	0.11	test_scale_vm.py
ContextSuite context=TestScaleVm>:teardown	`Error`	0.30	test_scale_vm.py
ContextSuite context=TestServiceOfferings>:setup	`Error`	3.56	test_service_offerings.py
ContextSuite context=TestSetSourceNatIp>:setup	`Error`	0.00	test_set_sourcenat.py
ContextSuite context=TestSnapshotRootDisk>:setup	`Error`	0.00	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:setup	`Error`	0.00	test_snapshots.py
test_05_stop_ssvm	`Error`	0.15	test_ssvm.py
test_06_stop_cpvm	`Error`	0.17	test_ssvm.py
test_07_reboot_ssvm	`Error`	0.15	test_ssvm.py
test_08_reboot_cpvm	`Error`	0.16	test_ssvm.py
test_09_reboot_ssvm_forced	`Error`	0.15	test_ssvm.py
test_10_reboot_cpvm_forced	`Error`	0.19	test_ssvm.py
test_11_destroy_ssvm	`Error`	0.13	test_ssvm.py
test_12_destroy_cpvm	`Error`	0.13	test_ssvm.py
test_01_import_storage_policies	`Error`	5.94	test_storage_policy.py
ContextSuite context=TestVMWareStoragePolicies>:teardown	`Error`	5.98	test_storage_policy.py
all_test_templates	`Skipped`	---	test_templates.py
all_test_update_security_group	`Skipped`	---	test_update_security_group.py
all_test_usage_events	`Skipped`	---	test_usage_events.py
all_test_usage	`Skipped`	---	test_usage.py
all_test_vm_autoscaling	`Skipped`	---	test_vm_autoscaling.py
all_test_vm_deployment_planner	`Skipped`	---	test_vm_deployment_planner.py
all_test_vm_life_cycle	`Skipped`	---	test_vm_life_cycle.py
all_test_vm_lifecycle_unmanage_import	`Skipped`	---	test_vm_lifecycle_unmanage_import.py
all_test_vm_schedule	`Skipped`	---	test_vm_schedule.py
all_test_vm_snapshot_kvm	`Skipped`	---	test_vm_snapshot_kvm.py
all_test_vm_snapshots	`Skipped`	---	test_vm_snapshots.py
all_test_vnf_templates	`Skipped`	---	test_vnf_templates.py
all_test_volumes	`Skipped`	---	test_volumes.py
all_test_vpc_ipv6	`Skipped`	---	test_vpc_ipv6.py
all_test_vpc_redundant	`Skipped`	---	test_vpc_redundant.py
all_test_vpc_router_nics	`Skipped`	---	test_vpc_router_nics.py
all_test_vpc_vpn	`Skipped`	---	test_vpc_vpn.py
all_test_host_maintenance	`Skipped`	---	test_host_maintenance.py
all_test_hostha_kvm	`Skipped`	---	test_hostha_kvm.py

vishesh92 · 2024-06-18T20:44:42Z

@blueorangutan test alma9 vmware-70u3

blueorangutan · 2024-06-18T20:46:04Z

@vishesh92 a [SL] Trillian-Jenkins test job (alma9 mgmt + vmware-70u3) has been kicked to run smoke tests

sureshanaparti

clgtm

blueorangutan · 2024-06-19T11:40:01Z

[SF] Trillian test result (tid-10503)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server a9
Total time taken: 48300 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8508-t10503-vmware-70u3.zip
Smoke tests completed. 129 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_trigger_shutdown	`Failure`	341.39	test_safe_shutdown.py
test_05_stop_ssvm	`Failure`	102.15	test_ssvm.py

DaanHoogland · 2024-06-19T14:41:45Z

At least the cluster DRS test errors are gone now. What do we think @vishesh92 @sureshanaparti ?

vishesh92 · 2024-06-19T14:43:14Z

At least the cluster DRS test errors are gone now. What do we think @vishesh92 @sureshanaparti ?

Yeah. Let's merge it.

sureshanaparti · 2024-06-20T05:21:12Z

No issues with cluster DRS test here, merging this based on review / test result.

* PR template enhanced * assertion improvement on cluster DRS * Update test/integration/smoke/test_cluster_drs.py * Fix host id check for balanced drs e2e test * Update test/integration/smoke/test_cluster_drs.py Co-authored-by: Vishesh <vishesh92@gmail.com>

boring-cyborgBot added component:integration-test Python Warning... Python code Ahead! labels Jan 15, 2024

DaanHoogland requested a review from vishesh92 January 15, 2024 08:57

vishesh92 approved these changes Jan 16, 2024
View reviewed changes

DaanHoogland commented Jan 17, 2024
View reviewed changes

Comment threadtest/integration/smoke/test_cluster_drs.py

apache deleted a comment from blueorangutan Jan 17, 2024

apache deleted a comment from blueorangutan Jan 18, 2024

DaanHoogland mentioned this pull request Jan 19, 2024
[HEALTH] 4.19/main Health Check, please don't merge this! #7344
Closed
12 tasks

DaanHoogland added this to the 4.19.1.0 milestone Jan 22, 2024

DaanHoogland force-pushed the clusterDrsAssertion branch from dbb2335 to cc63e6dCompare May 31, 2024 08:48

DaanHoogland added 2 commits June 3, 2024 13:14

PR template enhanced
e3e2a47

assertion improvement on cluster DRS
f041490

DaanHoogland force-pushed the clusterDrsAssertion branch from f48af70 to f041490Compare June 3, 2024 11:15

boring-cyborgBot added the component:UI label Jun 3, 2024

github-actionsBot added the status:has-conflicts label Jun 3, 2024

vishesh92 reviewed Jun 12, 2024
View reviewed changes

Comment threadtest/integration/smoke/test_cluster_drs.py Outdated

Update test/integration/smoke/test_cluster_drs.py
bc4885a

yadvr requested review from sureshanaparti and vishesh92 June 18, 2024 07:36

sureshanaparti approved these changes Jun 19, 2024
View reviewed changes

vishesh92 approved these changes Jun 20, 2024
View reviewed changes

sureshanaparti merged commit 84b91cc into apache:4.19Jun 20, 2024

sureshanaparti mentioned this pull request Jun 20, 2024
Improve test_cluster_drs.py for VMware #8507
Closed

DaanHoogland deleted the clusterDrsAssertion branch June 20, 2024 06:30

Uh oh!

Conversation

DaanHoogland commented Jan 15, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecovBot commented Jan 15, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shwstppr commented Jun 3, 2024

Uh oh!

DaanHoogland commented Jun 3, 2024

Uh oh!

vishesh92 commented Jun 3, 2024

Uh oh!

github-actionsBot commented Jun 3, 2024

Uh oh!

blueorangutan commented Jun 12, 2024

Uh oh!

blueorangutan commented Jun 12, 2024

Uh oh!

Uh oh!

vishesh92 commented Jun 12, 2024

Uh oh!

blueorangutan commented Jun 12, 2024

Uh oh!

blueorangutan commented Jun 12, 2024

Uh oh!

DaanHoogland commented Jun 12, 2024

Uh oh!

blueorangutan commented Jun 12, 2024

Uh oh!

blueorangutan commented Jun 13, 2024

Uh oh!

sureshanaparti commented Jun 18, 2024

Uh oh!

blueorangutan commented Jun 18, 2024

Uh oh!

blueorangutan commented Jun 18, 2024

Uh oh!

vishesh92 commented Jun 18, 2024

Uh oh!

blueorangutan commented Jun 18, 2024

Uh oh!

blueorangutan commented Jun 18, 2024

Uh oh!

vishesh92 commented Jun 18, 2024

Uh oh!

blueorangutan commented Jun 18, 2024

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Jun 19, 2024

Uh oh!

DaanHoogland commented Jun 19, 2024

Uh oh!

vishesh92 commented Jun 19, 2024

Uh oh!

sureshanaparti commented Jun 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecovBot commented Jan 15, 2024•
edited
Loading