Uh oh!
There was an error while loading. Please reload this page.
Removed unnecessary @Local annotations and their respective imports - #853
Conversation
asfbot
commented
Sep 19, 2015
cloudstack-pull-rats #657 SUCCESS |
asfbot
commented
Sep 19, 2015
cloudstack-pull-analysis #606 FAILURE |
asfbot
commented
Sep 19, 2015
cloudstack-pull-rats #661 SUCCESS |
asfbot
commented
Sep 19, 2015
cloudstack-pull-analysis #610 FAILURE |
rafaelweingartner
commented
Sep 19, 2015
Hi @critofolini, I think that there was a problem in your PR in class: SecurityGroupManagerImpl |
asfbot
commented
Sep 19, 2015
cloudstack-pull-rats #662 SUCCESS |
asfbot
commented
Sep 19, 2015
cloudstack-pull-analysis #611 FAILURE |
asfbot
commented
Sep 20, 2015
cloudstack-pull-rats #664 SUCCESS |
asfbot
commented
Sep 20, 2015
cloudstack-pull-analysis #613 FAILURE |
asfbot
commented
Sep 20, 2015
cloudstack-pull-rats #665 SUCCESS |
asfbot
commented
Sep 20, 2015
cloudstack-pull-analysis #614 SUCCESS |
rafaelweingartner
commented
Sep 20, 2015
@cristofolini, could you squash your commits into a single one? |
9e4e17d to
b4c8db4Compareasfbot
commented
Sep 20, 2015
cloudstack-pull-rats #666 SUCCESS |
cristofolini
commented
Sep 20, 2015
@rafaelweingartner Done. |
asfbot
commented
Sep 20, 2015
cloudstack-pull-analysis #615 SUCCESS |
b4c8db4 to
a5ca762Compare…-006 Removed unnecessary @Local annotations and their respective importsFollowing @rafaelweingartner 's findings in PR #714 that many spring beans contained an @Local annotation, we've decided to remove said annotations and their imports from the ComponentLifecycleBase class and its subclasses seeking a reduction of a few hundred lines of useless code. I had already opened a pull request for this (#853) but at some point my commit disappeared from the PR entirely, showing no new changes in code, which caused it to be merged automatically (with no changes). * pr/1102: Removed unnecessary @Local annotations and their respective imports from the ComponentLifecycleBase class and its subclasses. Signed-off-by: Remi Bergsma <github@remi.nl>
Following @rafaelweingartner 's findings in PR #714 that many spring beans contained an @Local annotation, we've decided to remove said annotations and their imports seeking a reduction of a few hundred lines of useless code.