Skip to content

engine-schema: fix wrong cloud.domain_view - #8705

Merged
DaanHoogland merged 1 commit into
apache:4.19from
shapeblue:fix-view-domain-view
Feb 26, 2024
Merged

engine-schema: fix wrong cloud.domain_view#8705
DaanHoogland merged 1 commit into
apache:4.19from
shapeblue:fix-view-domain-view

Conversation

@shwstppr

Copy link
Copy Markdown
Contributor

Description

Fixes cloud.domain_view.sql added in #8647
View source is taken from schema-41520to41600.sql

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fixes cloud.domain_view.sql added in apache#8647
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstpprshwstppr changed the title db: fix wrong cloud.domain_viewengine-schema: fix wrong cloud.domain_viewFeb 26, 2024
@codecov

codecovBot commented Feb 26, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.91%. Comparing base (2a56c61) to head (883b892).

Additional details and impacted files
@@ Coverage Diff @@## 4.19 #8705 +/- ##
============================================
- Coverage 30.95% 30.91% -0.04% + Complexity 34243 34207 -36 
============================================
Files 5347 5347 Lines 375615 375615 Branches 54626 54626 ============================================
- Hits 116260 116124 -136 - Misses 244051 244207 +156 + Partials 15304 15284 -20 
FlagCoverage Δ
simulator-marvin-tests24.76% <ø> (-0.07%)⬇️
uitests4.39% <ø> (ø)
unit-tests16.57% <ø> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishesh92vishesh92 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@vishesh92

Copy link
Copy Markdown
Member

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✖️ el7 ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 8776

@GutoVeroneziGutoVeronezi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @shwstppr

@DaanHoogland

Copy link
Copy Markdown
Contributor

Wouw, how could this have happened? I checked main, and there the file cloud.domain_view.sql contains the domain_view, but mea culpa for sure

@DaanHoogland
DaanHoogland merged commit b4404fb into apache:4.19Feb 26, 2024
@DaanHoogland
DaanHoogland deleted the fix-view-domain-view branch February 26, 2024 13:47
@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8790

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Mar 5, 2024
@DaanHooglandDaanHoogland added this to the 4.19.1.0 milestone May 28, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants

@shwstppr@vishesh92@blueorangutan@DaanHoogland@GutoVeronezi