CLOUDSTACK-8928: While adding VMs to LB rule, default NIC IP is always displayed rather than the IP corresponding to the NIC where LB is being created

[nitin-maharana]

While calling the listNics API, instead of sending the default nic id as parameter, it should send the network id as a parameter.

So, replaced that nicid parameter as networkid parameter.

[sebgoa]

@nitin-maharana Any automated tests for this ? if not, can you spend the time to write some. thanks

[nitin-maharana]

@Runseb I think there is no automated tests for this. I will try to write one. Thanks.

[remibergsma]

@nitin-maharana Any update on this?

[nitin-maharana]

@remibergsma I was busy in some other works. Within 3-4 days I will work on this and will give an update. Thank you.

[nitin-maharana]

Hi @Runseb@remibergsma I don't understand what to test and how to write a test for this. If you have any idea of how to write one, please help me out. Thanks.

[karuturi]

great find @nitin-maharana
manually tested the fix
In my setup, I had a vm with two nics
isolated1 - 10.1.1.14 - default
isolated 2 - 10.1.1.187 - non default

When I add a LB rule in network isolated2 for the VM, this is API call before the change and it failed.

After the fix, it took the right IP and succeeded.

👍 LGTM

[remibergsma]

Nice small fix, LGTM.

[nitin-maharana]

Thanks @karuturi@remibergsma.