BUG-ID: CLOUDSTACK-8922: Unable to delete IP tag by yvsubhash · Pull Request #905 · apache/cloudstack

yvsubhash · 2015-10-01T09:51:54Z

Root Cause: Due to wrong search string we are fetching a resource which does not belong to current account and domain. This results in permission exception.
Solution: Code changes has been done to fix the incorrect search string.

wilderrodrigues · 2015-10-01T09:55:29Z

Hi @yvsubhash

Any details about how you tested it?

Cheers,
Wilder

yvsubhash · 2015-10-01T09:58:37Z

It is tested manually with the data similar to the one mentioned in the bug

sebgoa · 2015-10-05T20:38:29Z

@yvsubhash we should try to remove manual testing. Can you write a marvin test for it. thanks. cc @wilderrodrigues

rajesh-battala · 2016-04-21T08:42:58Z

Marvin test really helps for validating this bug fix.

yadvr · 2016-05-02T10:42:49Z

@yvsubhash please rebase against latest master and push -f, update on status of your PR; please add a marvin test that can validate the fix

bvbharatk · 2016-06-09T18:06:22Z

ACS CI BVT Run

Sumarry:
Build Number 170
Hypervisor xenserver
NetworkType Advanced
Passed=73
Failed=0
Skipped=3

Link to logs Folder (search by build_no):https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0

Failed tests:

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vpc_vpn.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_routers.py
test_reset_vm_on_reboot.py
test_snapshots.py
test_deploy_vms_with_varied_deploymentplanners.py
test_login.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_disk_offerings.py

niteshsarda · 2017-03-27T10:11:01Z

I have tested this and LGTM for test.

yvsubhash · 2017-04-09T13:05:33Z

tag:mergeready

DaanHoogland · 2017-05-22T13:58:39Z

 "List tags should return empty response"
 )
 return
+ @attr(tags=["advanced"], required_hardware="false")


Do we really need hardware to test this, @yvsubhash ?

@DaanHoogland it can be run on simulator. that is the reason required_hardware is set to false. May I now the concern here

I frased my question wrong. can this be moved to the smoke tests?

@DaanHoogland this test can be moved to smoke tests.

@DaanHoogland all the tests in test_tags moved to smoke as they all run on simulator

DaanHoogland · 2017-05-22T14:00:26Z

 @ActionEvent(eventType = EventTypes.EVENT_TAGS_DELETE, eventDescription = "deleting resource tags")
 public boolean deleteTags(List<String> resourceIds, ResourceObjectType resourceType, Map<String, String> tags) {
 Account caller = CallContext.current().getCallingAccount();
+ List<String> uuids = new ArrayList<String>();


deleteTags() is already to big. Please factor out the new code in a separate set of methods.

karuturi · 2017-06-06T10:51:38Z

@DaanHoogland Can you review?

cloudmonger · 2017-09-04T10:53:29Z

ACS CI BVT Run

Sumarry:
Build Number 1188
Hypervisor xenserver
NetworkType Advanced
Passed=129
Failed=8
Skipped=41

Link to logs Folder (search by build_no):https://www.dropbox.com/sh/r2si930m8xxzavs/AAAzNrnoF1fC3auFrvsKo_8-a?dl=0

Failed tests:

test_scale_vm.py
ContextSuite context=TestScaleVm>:setup Failing since 45 runs
test_portforwardingrules.py
test_01_create_delete_portforwarding_fornonvpc Failed
test_01_create_delete_portforwarding_fornonvpc Failing since 2 runs
test_non_contigiousvlan.py
test_extendPhysicalNetworkVlan Failing since 2 runs
test_list_ids_parameter.py
ContextSuite context=TestListIdsParams>:setup Failing since 63 runs
test_routers_network_ops.py
test_01_isolate_network_FW_PF_default_routes_egress_true Failing since 49 runs
test_02_isolate_network_FW_PF_default_routes_egress_false Failing since 176 runs
ContextSuite context=TestRedundantIsolateNetworks>:setup Failing since 12 runs

Skipped tests:
test_vm_nic_adapter_vmxnet3
test_04_vpn_tag
test_01_verify_libvirt
test_02_verify_libvirt_after_restart
test_03_verify_libvirt_attach_disk
test_04_verify_guest_lspci
test_05_change_vm_ostype_restart
test_06_verify_guest_lspci_again
test_disable_oobm_ha_state_ineligible
test_hostha_configure_default_driver
test_hostha_enable_ha_when_host_disabled
test_hostha_enable_ha_when_host_disconected
test_hostha_enable_ha_when_host_in_maintenance
test_hostha_kvm_host_degraded
test_hostha_kvm_host_fencing
test_hostha_kvm_host_recovering
test_remove_ha_provider_not_possible
test_configure_ha_provider_invalid
test_configure_ha_provider_valid
test_ha_configure_enabledisable_across_clusterzones
test_ha_disable_feature_invalid
test_ha_enable_feature_invalid
test_ha_list_providers
test_ha_multiple_mgmt_server_ownership
test_ha_verify_fsm_available
test_ha_verify_fsm_degraded
test_ha_verify_fsm_fenced
test_ha_verify_fsm_recovering
test_hostha_configure_default_driver
test_hostha_configure_invalid_provider
test_hostha_disable_feature_valid
test_hostha_enable_feature_valid
test_hostha_enable_feature_without_setting_provider
test_list_ha_for_host
test_list_ha_for_host_invalid
test_list_ha_for_host_valid
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

Passed test suits:
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_vm_snapshots.py
test_over_provisioning.py
test_global_settings.py
test_router_dnsservice.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_outofbandmanagement_nestedplugin.py
test_login.py
test_deploy_vm_iso.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_metrics_api.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_disk_offerings.py

niteshsarda · 2017-10-30T09:08:12Z

Tested this fix and it seems to be working as per expectations. LGTM for test. Following are the results of the test cases that I have executed locally :

Test Create tag on LB rule and remove the LB rule ... === TestName: test_01_lbrule_tag | Status : SUCCESS ===
ok
Test Create tag on nat rule and remove the nat rule ... === TestName: test_02_natrule_tag | Status : SUCCESS ===
ok
Test Create tag on firewall rule and remove the firewall rule ... === TestName: test_03_firewallrule_tag | Status : SUCCESS ===
ok
Test Create tag on vpn and remove the vpn ... SKIP: VPN resource tags are unsupported in 4.0
Test creation, listing and deletion tags on UserVM ... === TestName: test_05_vm_tag | Status : SUCCESS ===
ok
Test creation, listing and deletion tag on templates ... === TestName: test_06_template_tag | Status : SUCCESS ===
ok
Test creation, listing and deletion tags on ISO ... === TestName: test_07_iso_tag | Status : SUCCESS ===
ok
Test creation, listing and deletion tagson volume ... === TestName: test_08_volume_tag | Status : SUCCESS ===
ok
Test creation, listing and deletion tag son snapshot ... === TestName: test_09_snapshot_tag | Status : SUCCESS ===
ok
Testcreation, listing and deletion tags on guest network ... === TestName: test_10_network_tag | Status : SUCCESS ===
ok
Test migration of a tagged vm and delete the tag ... === TestName: test_11_migrate_tagged_vm_del | Status : SUCCESS ===
ok
Test to verify that tags are not case sensitive ... === TestName: test_13_tag_case_insensitive | Status : SUCCESS ===
ok
Test multiple tags and with special characters on same machine ... === TestName: test_14_special_char_mutiple_tags | Status : SUCCESS ===
ok
Test creation, listing and deletion tags on projects ... === TestName: test_15_project_tag | Status : SUCCESS ===
ok
Test Query the tags from other account ... === TestName: test_16_query_tags_other_account | Status : SUCCESS ===
ok
Test Query the tags from admin account ... === TestName: test_17_query_tags_admin_account | Status : SUCCESS ===
ok
Test listAPI with invalid tags parameter ... === TestName: test_18_invalid_list_parameters | Status : SUCCESS ===
ok
Test deletion and addition of same tag on a resource. ... === TestName: test_19_delete_add_same_tag | Status : SUCCESS ===
ok
Test creation of same tag on multiple resources ... === TestName: test_20_create_tags_multiple_resources | Status : SUCCESS ===
ok
Test creation of tag on stopped vm. ... === TestName: test_21_create_tag_stopped_vm | Status : SUCCESS ===
ok
Test creation of tag on stopped vm. ... === TestName: test_22_create_tag_destroyed_vm | Status : SUCCESS ===
ok
Hosts without tag are not listed while listing the hosts for migration for instance with tag ... === TestName: test_23_list_untagged_host_for_vm_migration | Status : SUCCESS ===
ok
Testcreation, adding and removing tag on public IP address ... === TestName: test_24_public_IP_tag | Status : SUCCESS ===
ok
Testcreation, adding and removing tag on public IP address ... === TestName: test_25_IP_Address_tag | Status : SUCCESS ===
ok

Ran 24 tests in 502.723s

OK (SKIP=1)

yadvr · 2017-11-22T11:56:45Z

LGTM, pending travis results.
@blueorangutan package

blueorangutan · 2017-11-22T11:57:19Z

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2017-11-22T12:33:45Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1284

yadvr · 2017-11-22T21:36:44Z

@blueorangutan test

blueorangutan · 2017-11-22T21:37:22Z

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

rafaelweingartner

@yvsubhash Thanks for the PR.

I have some remarks for you.

rafaelweingartner · 2017-11-22T21:53:42Z

+ try {
+ internalId = Long.parseLong(resourceId);
+ } catch (final NumberFormatException e) {
+ internalId = null;


What about throwing the InvalidParameterValueException here?

@rafaelweingartner addressed

rafaelweingartner · 2017-11-22T21:55:00Z

+ private List<? extends ResourceTag> getResourceTags(final List<String> resourceIds, ResourceObjectType resourceType) {
+
+ List<String> uuids = new ArrayList<String>();
+ List<String> internalIds = new ArrayList<String>();


The type of this List should be Long, right?

No, having internalIds as interger does not help in anyway, as we get are using them again to construct the query

What do you mean by using them to construct query?

rafaelweingartner · 2017-11-22T21:59:09Z

+ }else{
+ Long internalId = null;
+ try {
+ internalId = Long.parseLong(resourceId);


What about executing the code internalIds.add(resourceId); here?
Then we do not need that IF there. We also would not need to declare Long internalId = null;

@rafaelweingartner taken care of this

rafaelweingartner · 2017-11-22T22:02:57Z


-List<? extends ResourceTag> resourceTags = _resourceTagDao.search(sc, null);
- ;
+Account caller = CallContext.current().getCallingAccount();


This variable called is not used?

It seems be about caller. that got used in
_accountMgr.checkAccess(caller, null, false, owner);

rafaelweingartner · 2017-11-22T22:05:46Z

+ List<String> uuids = new ArrayList<String>();
+ List<String> internalIds = new ArrayList<String>();
+ for(String resourceId : resourceIds){
+ if(resourceId.matches("^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$")){


What about simplifying this ?
You can use org.apache.commons.lang.math.NumberUtils.isDigits(String), to check if you have a long there, then you can convert it directly to Long, otherwise, you can check if it empty using org.apache.commons.lang3.StringUtils.isNotBlank(CharSequence), and if it is not blank, you can add in the UUID list.

yes. But validating uuid also is possibly more foolproof

Well, yes and no. I was thinking about it yesterday, do we need to validate it really?
If it is a string, we could simply use it, if it is invalid, we will not find anything.
I see validation useful when you display a message back to the user saying, "hey, the data you entered is not following the expected format, which should be ...."
That is not what is happening here.

blueorangutan · 2017-11-23T09:16:53Z

Trillian test result (tid-1685)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41408 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr905-t1685-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_host_annotations.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_ssvm.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 64 look OK, 4 have error(s)

Test	Result	Time (s)	Test File
test_01_vpc_remote_access_vpn	`Failure`	61.03	test_vpc_vpn.py
test_07_resize_fail	`Failure`	15.38	test_volumes.py
test_04_rvpc_privategw_static_routes	`Failure`	294.05	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	132.94	test_privategw_acl.py
test_02_vpc_privategw_static_routes	`Failure`	248.63	test_privategw_acl.py
test_01_vpc_privategw_acl	`Failure`	66.69	test_privategw_acl.py
test_05_add_annotation_for_invalid_entityType	`Error`	0.07	test_host_annotations.py
test_change_service_offering_for_vm_with_snapshots	Skipped	0.00	test_vm_snapshots.py
test_09_copy_delete_template	Skipped	0.03	test_templates.py
test_06_copy_template	Skipped	0.00	test_templates.py
test_04_vpn_tag	Skipped	0.00	test_tags.py
test_static_role_account_acls	Skipped	0.03	test_staticroles.py
test_11_ss_nfs_version_on_ssvm	Skipped	0.02	test_ssvm.py
test_01_scale_vm	Skipped	0.00	test_scale_vm.py
test_01_primary_storage_iscsi	Skipped	0.13	test_primary_storage.py
test_vm_nic_adapter_vmxnet3	Skipped	0.00	test_nic_adapter_type.py
test_03_nic_multiple_vmware	Skipped	1.13	test_nic.py
test_nested_virtualization_vmware	Skipped	0.00	test_nested_virtualization.py
test_06_copy_iso	Skipped	0.00	test_iso.py
test_list_ha_for_host_valid	Skipped	0.02	test_hostha_simulator.py
test_list_ha_for_host_invalid	Skipped	0.02	test_hostha_simulator.py
test_list_ha_for_host	Skipped	0.02	test_hostha_simulator.py
test_hostha_enable_feature_without_setting_provider	Skipped	0.02	test_hostha_simulator.py
test_hostha_enable_feature_valid	Skipped	0.02	test_hostha_simulator.py
test_hostha_disable_feature_valid	Skipped	0.03	test_hostha_simulator.py
test_hostha_configure_invalid_provider	Skipped	0.02	test_hostha_simulator.py
test_hostha_configure_default_driver	Skipped	0.02	test_hostha_simulator.py
test_ha_verify_fsm_recovering	Skipped	0.02	test_hostha_simulator.py
test_ha_verify_fsm_fenced	Skipped	0.02	test_hostha_simulator.py
test_ha_verify_fsm_degraded	Skipped	0.02	test_hostha_simulator.py
test_ha_verify_fsm_available	Skipped	0.02	test_hostha_simulator.py
test_ha_multiple_mgmt_server_ownership	Skipped	0.03	test_hostha_simulator.py
test_ha_list_providers	Skipped	0.03	test_hostha_simulator.py
test_ha_enable_feature_invalid	Skipped	0.03	test_hostha_simulator.py
test_ha_disable_feature_invalid	Skipped	0.02	test_hostha_simulator.py
test_ha_configure_enabledisable_across_clusterzones	Skipped	0.03	test_hostha_simulator.py
test_configure_ha_provider_valid	Skipped	0.03	test_hostha_simulator.py
test_configure_ha_provider_invalid	Skipped	0.03	test_hostha_simulator.py
test_deploy_vgpu_enabled_vm	Skipped	0.03	test_deploy_vgpu_enabled_vm.py
test_3d_gpu_support	Skipped	0.03	test_deploy_vgpu_enabled_vm.py

bwsw · 2017-11-23T11:11:54Z

It looks overcomplicated, really, search over resourceId is a wrong logic. It should search only against uuds. We discussed the problem in a mail list with @rafaelweingartner.
Right now I'm working on fix for it too. The code is here:

https://github.com/bwsw/cloudstack/blob/4.10.1-NP/server/src/com/cloud/tags/TaggedResourceManagerImpl.java

All marvin component and smoke are passing, and tag specific too:

nosetests-2.7 --with-marvin --marvin-config=setup/dev/advanced.cfg -w test/integration/component --with-xunit --xunit-file=/tmp/bvt_selfservice_cases.xml --zone=Sandbox-simulator --hypervisor=simulator -a tags=advanced,required_hardware=false -a speed=0 `pwd`/test/integration/component/test_tags.py

I believe, leaving internal id search is a wrong way to deal with it, because they can not and shouldn't appear in API. Also, the code I'm working on includes security fix for listing resource tags because right now the code from the PR doesn't even checks privileges for listing:

 @Override
public List<? extends ResourceTag> listByResourceTypeAndId(ResourceObjectType type, long resourceId) {
return _resourceTagDao.listBy(resourceId, type);
}

Mine:

@Override
public List<? extends ResourceTag> listByResourceTypeAndId(ResourceObjectType resourceType, long resourceId) {
Account caller = CallContext.current().getCallingAccount();
Pair<Long, Long> accountDomainPair = getAccountDomain(resourceId, resourceType);
Long domainId = accountDomainPair.second();
Long accountId = accountDomainPair.first();
checkResourceAccessible(accountId, domainId, "Account '" + caller + "' doesn't have permissions to list tags" +
" for resource '" + resourceId + "' of type '" + resourceType + "'.");
return _resourceTagDao.listBy(resourceId, resourceType);
}

So, basically the PR:

it doesn't fix the semantical problem allowing to search with internal ids
doesn't fix security fault when listing resource tags.

I need couple of days to finish the code because I want to add account tags feature and have to implement set of marvin tests for it.

rafaelweingartner · 2017-11-23T11:15:40Z

@bwsw I thought this was your PR, sorry for my lack of attention. So it seems someone else also ran into the same problem as you.

Well, if you will still open another PR for this, we can check and discuss both solutions (pros and cons).

bwsw · 2017-11-23T11:22:19Z

@rafaelweingartner looks reasonable

bwsw · 2017-12-04T10:26:46Z

@rafaelweingartner @yvsubhash Take a look at
#2350

…s support (#2350) This PR introduces several features and fixes some bugs: - account tags feature - fixed resource tags bugs which happened during tags search (found wrong entries because of mysql string to number translation - see #905, but this PR does more and fixes also resource access - vulnerability during list resource tags) - some marvin improvements (speed, sanity) Improved resource tags code: 1. Enhanced listTags security 2. Added support for account tags (account tags are required to support tags common for all users of an account) 3. Improved the tag management code (refactoring and cleanup) Marvin: 1. Fixed Marvin wait timeout between async pools. To decrease polling interval and improve CI speed. 2. Fixed /tmp/ to /tmp in zone configuration files. 3. Fixed + to os.path.join in log class. 4. Fixed + to os.path.join in deployDataCenter class. 5. Fixed typos in tag tests. 6. Modified Tags base class delete method. Deploy Datacenter script: 1. Improved deployDatacenter. Added option logdir to specify where script places results of evaluation. ConfigurationManagerImpl: 1. Added logging to ConfigurationManagerImpl to log when vlan is not found. Added test stubs for tags. Found accidental exception during simulator running after CI. tests_tags.py: 1. Fixed stale undeleted tags. 2. Changed region:India to scope:TestName.

yvsubhash · 2018-01-09T08:26:57Z

closing this pr as #2350 takes care of this

Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com> Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yvsubhash force-pushed the CLOUDSTACK-8922 branch from c0b98d3 to ef500e8Compare June 8, 2016 12:51

yvsubhash force-pushed the CLOUDSTACK-8922 branch from ef500e8 to 2969780Compare October 20, 2016 09:39

yvsubhash force-pushed the CLOUDSTACK-8922 branch 5 times, most recently from 2d7ea7a to d40fbc7Compare April 7, 2017 12:04

DaanHoogland requested changes May 22, 2017
View reviewed changes

yvsubhash force-pushed the CLOUDSTACK-8922 branch from d40fbc7 to 8dac74cCompare May 24, 2017 08:55

yvsubhash force-pushed the CLOUDSTACK-8922 branch from 8dac74c to a8be33dCompare July 31, 2017 05:01

yvsubhash force-pushed the CLOUDSTACK-8922 branch 4 times, most recently from 9bf58c5 to a7ab48eCompare September 4, 2017 06:10

yvsubhash force-pushed the CLOUDSTACK-8922 branch from a7ab48e to 21a267eCompare October 30, 2017 09:12

yvsubhash force-pushed the CLOUDSTACK-8922 branch from 21a267e to b3308baCompare November 20, 2017 08:34

rafaelweingartner requested changes Nov 22, 2017
View reviewed changes

yvsubhash force-pushed the CLOUDSTACK-8922 branch from b3308ba to eec9aefCompare November 23, 2017 08:57

bwsw mentioned this pull request Dec 4, 2017
Cloudstack 10170 - fixes resource tags security bugs and adds account tags support #2350
Merged

yvsubhash force-pushed the CLOUDSTACK-8922 branch 2 times, most recently from 840037f to e1c5f26Compare December 21, 2017 15:24

CLOUDSTACK-8922: Unable to delete IP tag
3693f23

yvsubhash force-pushed the CLOUDSTACK-8922 branch from e1c5f26 to 3693f23Compare December 25, 2017 09:27

yadvr added this to the 4.12 milestone Jan 6, 2018

yvsubhash closed this Jan 9, 2018

yadvr pushed a commit that referenced this pull request Jan 20, 2021
Fix description for api parameter (#905)
2c30e27
Co-authored-by: Pearl Dsilva <pearl.dsilva@shapeblue.com> Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

Uh oh!

Conversation

yvsubhash commented Oct 1, 2015

Uh oh!

wilderrodrigues commented Oct 1, 2015

Uh oh!

yvsubhash commented Oct 1, 2015

Uh oh!

sebgoa commented Oct 5, 2015

Uh oh!

rajesh-battala commented Apr 21, 2016

Uh oh!

yadvr commented May 2, 2016

Uh oh!

bvbharatk commented Jun 9, 2016

ACS CI BVT Run

Uh oh!

niteshsarda commented Mar 27, 2017

Uh oh!

yvsubhash commented Apr 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

karuturi commented Jun 6, 2017

Uh oh!

cloudmonger commented Sep 4, 2017

ACS CI BVT Run

Uh oh!

niteshsarda commented Oct 30, 2017

Uh oh!

yadvr commented Nov 22, 2017

Uh oh!

blueorangutan commented Nov 22, 2017

Uh oh!

blueorangutan commented Nov 22, 2017

Uh oh!

yadvr commented Nov 22, 2017

Uh oh!

blueorangutan commented Nov 22, 2017

Uh oh!

rafaelweingartner left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yvsubhashNov 23, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Nov 23, 2017

yvsubhashNov 23, 2017•
edited
Loading