kvm: replace ISO path in vm XML configuration during vm migration

[weizhouapache]

Description

This PR fixes#8901

steps to reproduce the issue

• create env with 2 image store
• create a vm
• register an ISO
• attach the ISO to the vm
• migrate the vm to another host

expected result: migration succeeds.
actually result: sometimes migration works, sometimes not

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 67.79661% with 19 lines in your changes missing coverage. Please review.

Project coverage is 14.96%. Comparing base (4bd0b1c) to head (d77fa0b).
Report is 4 commits behind head on 4.19.

Files	Patch %	Lines
...resource/wrapper/LibvirtMigrateCommandWrapper.java	68.96%	10 Missing and 8 partials ⚠️
...dstack/storage/datastore/db/ImageStoreDaoImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 4.19 #9212 +/- ##
===========================================
Coverage 14.96% 14.96% - Complexity 10994 11006 +12 
===========================================
Files 5373 5373 Lines 469303 469365 +62 Branches 61048 58589 -2459 ===========================================
+ Hits 70215 70251 +36 - Misses 391314 391335 +21 - Partials 7774 7779 +5 

Flag	Coverage Δ
uitests	4.30% <ø> (-0.01%)	⬇️
unittests	15.67% <67.79%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

clgtm

[shwstppr]

Code LGTM. Minor comment. Unit tests can be added if feasible

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9869

[weizhouapache]

@blueorangutan test rocky8 kvm-rocky8

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-10414)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 47174 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9212-t10414-kvm-rocky8.zip
Smoke tests completed. 130 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_trigger_shutdown	Failure	336.54	test_safe_shutdown.py

[vladimirpetrov]

LGTM based on manual testing. I cannot reproduce the problem after this patch.

[weizhouapache]

LGTM based on manual testing. I cannot reproduce the problem after this patch.

thanks @vladimirpetrov !

merging