Usage event fixes for deleted accounts

[nnesic]

Fixes regarding usage event emission.

UsageEventUtils was previously not checking deleted accounts, which meant that if an account was deleted that had some resources running on it, those resources would get destroyed without emitting any events.

Furthermore, the VOLUME_DELETE event of ROOT volumes is the responsibility of the UserVmManager, which gets circumvented when expunging resources following the account deletion. Added a check to the AccountManager which catches the ROOT volumes that need to be deleted and emits events for them.

To test this: Create a new user. As that user, create and destroy an instance. This should cause the VM_CREATE, VM_START, VM_STOP, VM_DESTROY, VOLUME_CREATE, and VOLUME_DELETE events to be emitted.
Create a new instance as the same user. Log in as admin, and delete the user. The same set of events should be emitted, and there should be no duplicate DELETE events for the ROOT volume of the previous instance.

[nnesic]

Hi, could you please re-trigger the build, since it seems to have crashed?

[remibergsma]

Hi @nnesic, you can do that by force pushing your commits again to the PR branch. The tests will then run again.

[kishankavala]

@remibergsma We not have any tests that will check for correct events on account delete.
@nnesic Would you be able to add one?

[nnesic]

I added two unit tests to check that the account manager adheres to its new responsibility of emitting the usage events for root volumes of instances which were not in destroyed state prior to the account deletion.

[remibergsma]

Pinging @borisroman@michaelandersen to review this PR.

[nnesic]

Hello, how is the review on this going?

[DaanHoogland]

code reviewed LGTM, @remibergsma kan you start a bubble with this?

[remibergsma]

I tried rebasing against current master but I run into build issues. Tried again but same thing.

@nnesic Could you try rebasing the PR against master and run a build?

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:35.871s
[INFO] Finished at: Fri Nov 20 09:51:10 GMT 2015
[INFO] Final Memory: 50M/329M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:testCompile (default-testCompile) on project cloud-server: Compilation failure
[ERROR] /data/git/cs1/cloudstack/dist/rpmbuild/BUILD/cloudstack-4.7.0-SNAPSHOT/server/test/com/cloud/user/MockUsageEventDao.java:[19,7] error: MockUsageEventDao is not abstract and does not override abst
ract method searchAndDistinctCount(SearchCriteria<UsageEventVO>,Filter) in GenericDao

[ProjectMoon]

The PR has been fixed by the application of two more commits. Maybe squashing is in order before a merge.

The abuse of reflection required to make the unit test play nice is an indicator that maybe the UsageEventUtils class should be made non-static though.

[ProjectMoon]

What's the status of this pull request? Do we need to redo this PR on 4.6 instead? Also what are the thoughts about squashing some of these commits down?

[yadvr]

@ProjectMoon can you rebase against latest master, and squash changes to a single commit

[ProjectMoon]

Squashing and rebasing is definitely needed. But isn't this a bug fix though? And thus should go on to 4.6 and then be forward merged?

[yadvr]

@ProjectMoon yes please squash them and maybe open a new PR against 4.7 (or 4.6) closing this one as github won't allow you to edit/change the source/dest branches.

[ProjectMoon]

New request is located at #1372.

[ProjectMoon]

I don't have the close button, so this one needs to be closed again.

[yadvr]

@nnesic since you're the author you can close this PR @ProjectMoon thanks for the new PR