Skip to content

test: fix test/integration/smoke/test_register_userdata.py which caused networks not to be deleted - #9244

Merged
DaanHoogland merged 1 commit into
apache:4.19from
weizhouapache:4.19-fix-test_register_userdata
Jun 14, 2024
Merged

test: fix test/integration/smoke/test_register_userdata.py which caused networks not to be deleted#9244
DaanHoogland merged 1 commit into
apache:4.19from
weizhouapache:4.19-fix-test_register_userdata

Conversation

@weizhouapache

Copy link
Copy Markdown
Member

Description

This PR fixes part of #8586

by moving the test under new domain/account instead of ROOT account

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

…ed networks not to be deleted
by moving the test under new domain/account instead of ROOT account
@boring-cyborgboring-cyborgBot added component:integration-test Python Warning... Python code Ahead! labels Jun 13, 2024
@weizhouapacheweizhouapache linked an issue Jun 13, 2024 that may be closed by this pull request
6 tasks
@weizhouapache

Copy link
Copy Markdown
MemberAuthor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecovBot commented Jun 13, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.96%. Comparing base (19e9020) to head (a590078).

Additional details and impacted files
@@ Coverage Diff @@## 4.19 #9244 +/- ##
============================================
- Coverage 14.96% 14.96% -0.01% + Complexity 11015 11010 -5 
============================================
Files 5377 5377 Lines 469605 469605 Branches 60258 58370 -1888 ============================================
- Hits 70296 70275 -21 - Misses 391523 391548 +25 + Partials 7786 7782 -4 
FlagCoverage Δ
uitests4.29% <ø> (ø)
unittests15.67% <ø> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9922

@weizhouapache

Copy link
Copy Markdown
MemberAuthor

@blueorangutan test rocky8 xcpng82

@blueorangutan

Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + xcpng82) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-10431)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server r8
Total time taken: 70781 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9244-t10431-xcpng82.zip
Smoke tests completed. 129 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File
test_01_condensed_drs_algorithmFailure169.60test_cluster_drs.py
test_02_balanced_drs_algorithmFailure180.76test_cluster_drs.py
test_01_non_strict_host_anti_affinityError204.38test_nonstrict_affinity_group.py
test_02_non_strict_host_affinityError116.58test_nonstrict_affinity_group.py

@weizhouapache
weizhouapache marked this pull request as ready for review June 14, 2024 06:20
@weizhouapache

weizhouapache commented Jun 14, 2024

Copy link
Copy Markdown
MemberAuthor

this is ready for review
@DaanHoogland@sureshanaparti

the rest failures are caused by live migration on xcpng82, see ##8586#7340 (comment)

@yadvryadvr added this to the 4.19.1.0 milestone Jun 14, 2024

@DaanHooglandDaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
DaanHoogland merged commit 8d02e5f into apache:4.19Jun 14, 2024
@DaanHoogland
DaanHoogland deleted the 4.19-fix-test_register_userdata branch June 14, 2024 07:06
@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-10440)
Environment: kvm-ubuntu24 (x2), Advanced Networking with Mgmt server u24
Total time taken: 47816 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9244-t10440-kvm-ubuntu24.zip
Smoke tests completed. 128 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

TestResultTime (s)Test File
test_oobm_background_powerstate_syncFailure21.01test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzonesError31.48test_outofbandmanagement.py
test_oobm_issue_power_cycleError20.07test_outofbandmanagement.py
test_oobm_issue_power_offError20.05test_outofbandmanagement.py
test_oobm_issue_power_onError20.04test_outofbandmanagement.py
test_oobm_issue_power_resetError20.05test_outofbandmanagement.py
test_oobm_issue_power_softError20.06test_outofbandmanagement.py
test_oobm_issue_power_statusError20.04test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownershipFailure28.31test_outofbandmanagement.py
test_oobm_zchange_passwordError6.50test_outofbandmanagement.py
test_01_service_offering_cpu_limit_useError1.11test_service_offerings.py
test_hostha_kvm_host_degradedError11.03test_hostha_kvm.py
test_hostha_kvm_host_fencingError11.11test_hostha_kvm.py
test_hostha_kvm_host_recoveringError9.81test_hostha_kvm.py

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
…ed networks not to be deleted (apache#9244)
by moving the test under new domain/account instead of ROOT account
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:integration-testPythonWarning... Python code Ahead!

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

Stabilize the smoke test on xcp-ng 81/82

4 participants

@weizhouapache@blueorangutan@yadvr@DaanHoogland