Shared Network Firewall (Security groups) in Advanced zone without security groups by vishesh92 · Pull Request #9415 · apache/cloudstack

vishesh92 · 2024-07-18T11:40:27Z

Doc PR: apache/cloudstack-documentation#422

Description

This PR allows creating shared networks with Security Groups in a Zone with securitygroupenabled set to false. This flag is used to prevent creation of isolated networks as of now to maintain backward compatibility for Zone with Security Groups.

To enable SG, enable the SecurityGroupProvider for Guest physical network. After this change, you will be able to create a shared network with Security Groups.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

vishesh92 · 2024-07-18T11:40:42Z

@blueorangutan package

blueorangutan · 2024-07-18T11:42:05Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2024-07-18T11:50:00Z

Codecov Report

Attention: Patch coverage is 12.24490% with 43 lines in your changes missing coverage. Please review.

Project coverage is 15.57%. Comparing base (47a6b70) to head (5637b12).
Report is 92 commits behind head on main.

Files with missing lines	Patch %	Lines
.../main/java/com/cloud/network/NetworkModelImpl.java	12.00%	19 Missing and 3 partials ⚠️
...g/apache/cloudstack/api/response/ZoneResponse.java	0.00%	9 Missing ⚠️
...er/actionworkers/KubernetesClusterStartWorker.java	0.00%	5 Missing ⚠️
...isor/xenserver/discoverer/XcpServerDiscoverer.java	0.00%	2 Missing ⚠️
...loudstack/api/command/user/vm/AddIpToVmNicCmd.java	0.00%	1 Missing ⚠️
...tack/api/command/user/vm/RemoveIpFromVmNicCmd.java	0.00%	1 Missing ⚠️
...KubernetesClusterResourceModifierActionWorker.java	0.00%	1 Missing ⚠️
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	50.00%	1 Missing ⚠️
...stack/storage/template/VnfTemplateManagerImpl.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #9415 +/- ##
============================================
+ Coverage 15.53% 15.57% +0.03% - Complexity 11988 12049 +61 
============================================
Files 5496 5505 +9 Lines 481450 482703 +1253 Branches 60738 62405 +1667 ============================================
+ Hits 74809 75187 +378 - Misses 398364 399209 +845 - Partials 8277 8307 +30

Flag	Coverage Δ
uitests	`4.16% <ø> (-0.02%)`	⬇️
unittests	`16.35% <12.24%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-07-18T13:01:32Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10398

weizhouapache · 2024-07-18T13:14:31Z

@blueorangutan test alma9 kvm-alma9

blueorangutan · 2024-07-18T13:16:06Z

@weizhouapache a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

vishesh92 · 2024-07-18T15:11:55Z

@weizhouapache This PR is still in progress and needs more work. All the simulators tests have also failed. Add WIP in the PR title for now.

vishesh92 · 2024-07-19T08:06:53Z

@blueorangutan package

blueorangutan · 2024-07-19T08:08:03Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-07-19T09:19:59Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10409

github-actions · 2024-07-19T11:58:08Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

vishesh92 · 2024-09-02T08:04:33Z

@blueorangutan package

blueorangutan · 2024-09-02T08:06:04Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-02T09:23:34Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10904

vishesh92 · 2024-09-03T12:58:14Z

@blueorangutan package

blueorangutan · 2024-09-03T13:00:04Z

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-03T14:17:03Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10931

DaanHoogland

clgtm, needs testing

DaanHoogland · 2024-09-04T09:40:40Z

@blueorangutan test keepEnv

blueorangutan · 2024-09-04T09:42:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-09-05T00:50:57Z

[SF] Trillian test result (tid-11335)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51957 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9415-t11335-kvm-ol8.zip
Smoke tests completed. 139 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2024-09-05T07:11:47Z

basic functional test done:
secgroup network can be created.
old style shared network and isolated networks can still be created.

kiranchavala

LGTM,

Tested the security groups for shared network on a Cloudstack advanced zone +kvm

The SG Rules are applied successfully to the vm's and I was also able to change the security groups associated to the vm from the UI

…curity groups (apache#9415)

boring-cyborgBot added component:networking component:UI labels Jul 18, 2024

vishesh92 changed the title ~~Enable Security groups for Shared networks in Advanced zone without security groups~~WIP - Enable Security groups for Shared networks in Advanced zone without security groupsJul 18, 2024

vishesh92 force-pushed the sg-for-shared-network branch 2 times, most recently from a7c3f8e to 84895aaCompare July 19, 2024 06:30

boring-cyborgBot added the component:api label Jul 19, 2024

apache deleted a comment from blueorangutan Jul 19, 2024

vishesh92 force-pushed the sg-for-shared-network branch from 76ff68c to 191f7d3Compare July 19, 2024 11:57

boring-cyborgBot added component:agent component:build component:database component:orchestration component:storage distro:ubuntu labels Jul 19, 2024

github-actionsBot added the status:has-conflicts label Jul 19, 2024

vishesh92 force-pushed the sg-for-shared-network branch from 191f7d3 to 76ff68cCompare July 19, 2024 11:59

github-actionsBot removed the status:has-conflicts label Jul 19, 2024

boring-cyborgBot added component:integration-test Python Warning... Python code Ahead! labels Jul 22, 2024

boring-cyborgBot added the component:XenServer label Sep 2, 2024

fixup
ce25e83

vishesh92 force-pushed the sg-for-shared-network branch from 27ea1fe to ce25e83Compare September 2, 2024 08:04

apache deleted a comment from blueorangutan Sep 2, 2024

UI: allow editing sg for a vm
5637b12

DaanHoogland approved these changes Sep 4, 2024
View reviewed changes

DaanHoogland added the status:needs-testing label Sep 4, 2024

yadvr marked this pull request as ready for review September 4, 2024 09:56

yadvr requested review from nvazquez and shwstppr September 4, 2024 10:00

yadvr assigned kiranchavala Sep 4, 2024

yadvr changed the title ~~Enable Security groups for Shared networks in Advanced zone without security groups~~Shared Network Firewall (Security groups) in Advanced zone without security groupsSep 5, 2024

DaanHoogland removed the status:needs-testing label Sep 5, 2024

kiranchavala approved these changes Sep 5, 2024
View reviewed changes

DaanHoogland merged commit 72d0546 into apache:mainSep 5, 2024

DaanHoogland deleted the sg-for-shared-network branch September 5, 2024 08:35

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 6, 2024
Shared Network Firewall (Security groups) in Advanced zone without se…
77dca4c
…curity groups (apache#9415)

eduardovra mentioned this pull request Feb 7, 2025
Unable to update the security groups of a VM #10347
Closed

weizhouapache mentioned this pull request Jan 15, 2026
UI: fix issues when deploy VNF applicance on network with SG #12436
Merged
14 tasks

Uh oh!

Conversation

vishesh92 commented Jul 18, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

vishesh92 commented Jul 18, 2024

Uh oh!

blueorangutan commented Jul 18, 2024

Uh oh!

codecovBot commented Jul 18, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jul 18, 2024

Uh oh!

weizhouapache commented Jul 18, 2024

Uh oh!

blueorangutan commented Jul 18, 2024

Uh oh!

vishesh92 commented Jul 18, 2024

Uh oh!

vishesh92 commented Jul 19, 2024

Uh oh!

blueorangutan commented Jul 19, 2024

Uh oh!

blueorangutan commented Jul 19, 2024

Uh oh!

github-actionsBot commented Jul 19, 2024

Uh oh!

vishesh92 commented Sep 2, 2024

Uh oh!

blueorangutan commented Sep 2, 2024

Uh oh!

blueorangutan commented Sep 2, 2024

Uh oh!

vishesh92 commented Sep 3, 2024

Uh oh!

blueorangutan commented Sep 3, 2024

Uh oh!

blueorangutan commented Sep 3, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Sep 4, 2024

Uh oh!

blueorangutan commented Sep 4, 2024

Uh oh!

blueorangutan commented Sep 5, 2024

Uh oh!

DaanHoogland commented Sep 5, 2024

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vishesh92 commented Jul 18, 2024•
edited
Loading

codecovBot commented Jul 18, 2024•
edited
Loading