Skip to content

[VMware] Consider CD/DVD drive when calculating next free unit number for volume attachment over IDE controller#9644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 2 commits into from
Jan 15, 2025
Merged

[VMware] Consider CD/DVD drive when calculating next free unit number for volume attachment over IDE controller #9644

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d843ad
Consider CD/DVD drive when calculating next free IDE unit number on v…
winterhazel Sep 5, 2024
dddfea4
Update vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/Virtu…
winterhazel Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3169,9 +3169,12 @@ public int getFreeUnitNumberOnIDEController(int controllerKey) throws Exception

int deviceCount = 0;
int ideDeviceUnitNumber = -1;
if (devices != null && devices.size() > 0) {
if (devices != null) {
for (VirtualDevice device : devices) {
if (device instanceof VirtualDisk && (controllerKey == device.getControllerKey())) {
if (device.getControllerKey() == null || device.getControllerKey() != controllerKey) {
continue;
}
if (device instanceof VirtualDisk || device instanceof VirtualCdrom) {
deviceCount++;
ideDeviceUnitNumber = device.getUnitNumber();
}
Expand Down