server: fix vm_stats records are not removed if batchsize is 0 by weizhouapache · Pull Request #9818 · apache/cloudstack

weizhouapache · 2024-10-17T11:12:27Z

Description

Prior to this change

2024-10-17T10:32:55,455 DEBUG [c.c.v.d.VmStatsDaoImpl] (StatsCollector-5:[ctx-ec4b3698]) (logid:708dd27c) Starting to remove all vm_stats rows older than [Wed Oct 16 22:32:55 UTC 2024].
2024-10-17T10:32:55,456 INFO [c.c.v.d.VmStatsDaoImpl] (StatsCollector-5:[ctx-ec4b3698]) (logid:708dd27c) Removed a total of [0] vm_stats rows older than [Wed Oct 16 22:32:55 UTC 2024].

With this change

2024-10-17T10:41:33,315 DEBUG [c.c.v.d.VmStatsDaoImpl] (StatsCollector-5:[ctx-dd8d7e09]) (logid:338dd659) Starting to remove all vm_stats rows older than [Wed Oct 16 22:41:33 UTC 2024].
2024-10-17T10:43:03,184 INFO [c.c.v.d.VmStatsDaoImpl] (StatsCollector-5:[ctx-dd8d7e09]) (logid:338dd659) Removed a total of [1661329] vm_stats rows older than [Wed Oct 16 22:41:33 UTC 2024].

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2024-10-17T11:19:43Z

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.78%. Comparing base (20901c7) to head (9a1bdaf).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...java/com/cloud/storage/dao/VolumeStatsDaoImpl.java	0.00%	1 Missing ⚠️
...src/main/java/com/cloud/vm/dao/VmStatsDaoImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## main #9818 +/- ##
=========================================
Coverage 15.78% 15.78% - Complexity 12564 12565 +1 
=========================================
Files 5627 5627 Lines 492266 492250 -16 Branches 63860 63795 -65 =========================================
+ Hits 77707 77710 +3 + Misses 406084 406066 -18 + Partials 8475 8474 -1

Flag	Coverage Δ
uitests	`4.04% <ø> (ø)`
unittests	`16.60% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yadvr

LGTM didn't test it

weizhouapache · 2024-10-17T11:36:01Z

@blueorangutan package

blueorangutan · 2024-10-17T11:38:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache · 2024-10-17T11:38:57Z

related to
@JoaoJandre 's PR #8740
@shwstppr 's PR #8999
@vishesh92 's merge commit 3923f80#diff-1ccbb9294e1b4e876df4f865c95f8f302ccea7a2ce6cfe574d0efa76e8f88868R1238

JoaoJandre

LGTM

vishesh92 · 2024-10-17T11:53:17Z

@weizhouapache We need this change in 4.19 since the PRs you mentioned are part of 4.19 branch.

shwstppr

code lgtm

sureshanaparti

clgtm

weizhouapache · 2024-10-17T12:35:39Z

@weizhouapache We need this change in 4.19 since the PRs you mentioned are part of 4.19 branch.

4.19 has similar change introduced in #8740 , it works

blueorangutan · 2024-10-17T12:44:55Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11379

weizhouapache · 2024-10-17T12:56:52Z

@blueorangutan test

blueorangutan · 2024-10-17T12:58:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-10-18T06:30:46Z

[SF] Trillian test result (tid-11682)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60826 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9818-t11682-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_create_pvlan_network	`Error`	0.10	test_pvlan.py
test_disable_oobm_ha_state_ineligible	`Error`	322.16	test_hostha_kvm.py
test_hostha_configure_default_driver	`Error`	112.52	test_hostha_kvm.py
test_hostha_enable_ha_when_host_disconected	`Error`	553.63	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	548.49	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	548.49	test_hostha_kvm.py
test_hostha_kvm_host_degraded	`Error`	41.62	test_hostha_kvm.py
test_hostha_kvm_host_fencing	`Error`	37.88	test_hostha_kvm.py
test_hostha_kvm_host_recovering	`Error`	35.38	test_hostha_kvm.py
test_remove_ha_provider_not_possible	`Error`	35.32	test_hostha_kvm.py

weizhouapache · 2024-10-18T06:59:47Z

@blueorangutan test

blueorangutan · 2024-10-18T07:02:05Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

yadvr · 2024-10-18T09:22:44Z

host_ha test failures are intermittent in nature. Let's merge this for sake of time & kick test matrix on the health check PR cc @JoaoJandre

blueorangutan · 2024-10-18T21:59:47Z

[SF] Trillian test result (tid-11686)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51586 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9818-t11686-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

…e#9818)

server: fix vm_stats records are not removed if batchsize is 0
9a1bdaf

weizhouapache added this to the 4.20.0.0 milestone Oct 17, 2024

boring-cyborgBot added component:database component:storage labels Oct 17, 2024

yadvr approved these changes Oct 17, 2024
View reviewed changes

weizhouapache requested review from JoaoJandre, shwstppr, vishesh92 and yadvr October 17, 2024 11:34

yadvr approved these changes Oct 17, 2024
View reviewed changes

weizhouapache marked this pull request as ready for review October 17, 2024 11:35

JoaoJandre approved these changes Oct 17, 2024
View reviewed changes

JoaoJandre added the Severity:BLOCKER label Oct 17, 2024

shwstppr approved these changes Oct 17, 2024
View reviewed changes

sureshanaparti approved these changes Oct 17, 2024
View reviewed changes

yadvr merged commit 019f2c6 into apache:mainOct 18, 2024

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 24, 2024
server: fix vm_stats records are not removed if batchsize is 0 (apach…
f44fbb1
…e#9818)

Uh oh!

Conversation

weizhouapache commented Oct 17, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecovBot commented Oct 17, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yadvr left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Oct 17, 2024

Uh oh!

blueorangutan commented Oct 17, 2024

Uh oh!

weizhouapache commented Oct 17, 2024

Uh oh!

JoaoJandre left a comment

Choose a reason for hiding this comment

Uh oh!

vishesh92 commented Oct 17, 2024

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Oct 17, 2024

Uh oh!

blueorangutan commented Oct 17, 2024

Uh oh!

weizhouapache commented Oct 17, 2024

Uh oh!

blueorangutan commented Oct 17, 2024

Uh oh!

blueorangutan commented Oct 18, 2024

Uh oh!

weizhouapache commented Oct 18, 2024

Uh oh!

blueorangutan commented Oct 18, 2024

Uh oh!

yadvr commented Oct 18, 2024

Uh oh!

blueorangutan commented Oct 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

codecovBot commented Oct 17, 2024•
edited
Loading